[rekonq] Re: Review Request: Add bookmar by dragging and dropping the url from the urlbar

[Furkan Üzümcü]

> On April 5, 2011, 10:15 p.m., Andrea Diamantini wrote:
> > In general I like this feature, but I don't like the way it is implemented. IMHO, you have in mind just your feature and are forgetting about everything else. When you drag text, IT IS TEXT. You cannot behave as it was an url. The icon in the drag object is nice, but I'm not sure it is ok for text. What if users drag urlbar content to an external application? Should they think they are dragging an url?
> > Last, we have another developer (Johannes Troscher) working on drag n drop features. This patch breaks his work, so it is a no go "as-is".
> 
> Furkan Üzümcü wrote:
>     It doesn't break Johannes Troscher (at least the one just got on the main repo).
>     And I know the solution to what you mentioned. I'll fix it.

When you drag url it shows the icon of current web page. If you drag text (text that is not related to the current page's url) it doesn't show icon.


- Furkan


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/101018/#review2416
-----------------------------------------------------------


On April 6, 2011, 4:36 p.m., Furkan Üzümcü wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/101018/
> -----------------------------------------------------------
> 
> (Updated April 6, 2011, 4:36 p.m.)
> 
> 
> Review request for rekonq.
> 
> 
> Summary
> -------
> 
> Drag and rop the url from the urlbar to add it as a bookmark.
> 
> 
> Diffs
> -----
> 
>   src/urlbar/urlbar.cpp 0a6783a 
>   src/bookmarks/bookmarkstoolbar.cpp 8da30c6 
>   src/urlbar/urlbar.h 9ed89da 
> 
> Diff: http://git.reviewboard.kde.org/r/101018/diff
> 
> 
> Testing
> -------
> 
> Compiles and works.
> 
> 
> Thanks,
> 
> Furkan
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: http://mail.kde.org/pipermail/rekonq/attachments/20110406/1872ddcb/attachment-0001.htm