[rekonq] Re: Review Request: Add bookmar by dragging and dropping the url from the urlbar

[Furkan Üzümcü]

> On April 5, 2011, 10:10 p.m., Andrea Diamantini wrote:
> > src/urlbar/urlbar.cpp, line 346
> > <http://git.reviewboard.kde.org/r/101018/diff/4/?file=13757#file13757line346>
> >
> >     I'm not sure to understand the difference between the stringToDrag and the selectedText() output. Can the last be used instead?

Strangely, selected text in the url bar changes when starting drag. That's why I use that.


- Furkan


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/101018/#review2415
-----------------------------------------------------------


On April 4, 2011, 4:18 a.m., Furkan Üzümcü wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/101018/
> -----------------------------------------------------------
> 
> (Updated April 4, 2011, 4:18 a.m.)
> 
> 
> Review request for rekonq.
> 
> 
> Summary
> -------
> 
> Drag and rop the url from the urlbar to add it as a bookmark.
> 
> 
> Diffs
> -----
> 
>   src/bookmarks/bookmarkstoolbar.cpp 8da30c6 
>   src/urlbar/urlbar.h 9ed89da 
>   src/urlbar/urlbar.cpp 4d53e17 
> 
> Diff: http://git.reviewboard.kde.org/r/101018/diff
> 
> 
> Testing
> -------
> 
> Compiles and works.
> 
> 
> Thanks,
> 
> Furkan
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: http://mail.kde.org/pipermail/rekonq/attachments/20110406/0284cdbc/attachment-0001.htm