[rekonq] fix url decoding

Andrea Diamantini adjam7 at gmail.com
Sun Nov 1 12:04:26 CET 2009


On Sunday 01 November 2009 02:49:01 Ronny Scholz wrote:
> I tested again what happens if we remove hardcoded google setting as
>  default search engine completely and could not find any drawbacks.
> 
> With the attached patch the default search engine is chosen and web
>  shortcuts are working again, both with colon or space set as delimiter.
> It was tested on Qt 4.5.2 and Qt 4.6 and fixes bugs 205848, 210945 and
>  204708.
> 
> 
> The following use cases were tested (having space set as delimiter):
> 
> open URL
> - "http://www.winehq.org" loads "http://www.winehq.org/"
> - "www.winehq.org" loads "http://www.winehq.org/"
> - "kde.org" loads "http://kde.org"
> 
> use default search engine (google is the default setting)
> - "test" loads google with "test" as search term
> - "test 123" loads google with both search terms
> 
> use web shortcuts
> - "qt qwebpage" loads http://doc.trolltech.com/4.5/qwebpage.html
> 
> open local files
> - "~/.kderc" displays the file content
> 
> 
> The tests have been repeated with colon as delimiter and resulted in the
>  same decoded URLs.
> 

one good, one bad news about.

The bad news is that this is not working here as you describe.
The good news is that (perhaps) I understood why :D
Ronny, can you please apply this patch to mainline and let me know the plugin 
names in the kDebug output?

-- 
Andrea Diamantini, adjam
GPG Fingerprint: 57DE 8E32 7D1A 0E16 AA52 59D8 84F9 3ECD DBF9 730F

rekonq project
WEB: http://rekonq.sourceforge.net
IRC: rekonq at freenode



More information about the rekonq mailing list