<html>
<head>
<meta http-equiv="Content-Type" content="text/html;
charset=windows-1252">
</head>
<body>
<p><br>
</p>
<div class="moz-cite-prefix">On 29/07/2021 15:50, Alexander Lohnau
wrote:<br>
</div>
<blockquote type="cite"
cite="mid:10717990.T7Z3S40VBb@user-20frs0y40z">
<meta http-equiv="content-type" content="text/html;
charset=windows-1252">
<p
style="margin-top:0;margin-bottom:0;margin-left:0;margin-right:0;">Hi,</p>
<br>
<p
style="margin-top:0;margin-bottom:0;margin-left:0;margin-right:0;">in
<a
href="https://invent.kde.org/frameworks/kpackage/-/blob/master/KF5PackageMacros.cmake#L109"
moz-do-not-send="true">https://invent.kde.org/frameworks/kpackage/-/blob/master/KF5PackageMacros.cmake#L109</a> there
is the a JSON file created.</p>
</blockquote>
<p>I think the problem is that this file is installed next to the
rcc bundle, but KPackage expects it inside the bundle, so loading
the metadata from it doesn't work and it falls back to the
.desktop file inside the bundle.<br>
</p>
<blockquote type="cite"
cite="mid:10717990.T7Z3S40VBb@user-20frs0y40z">
<br>
<p
style="margin-top:0;margin-bottom:0;margin-left:0;margin-right:0;">The
initial discussion about this function was in <a
href="https://phabricator.kde.org/D9197
" moz-do-not-send="true">https://phabricator.kde.org/D9197</a>.
In <a href="https://phabricator.kde.org/D19383"
moz-do-not-send="true">https://phabricator.kde.org/D19383</a> the
topic was also discussed, but without getting a conclusion.</p>
<br>
<p
style="margin-top:0;margin-bottom:0;margin-left:0;margin-right:0;">There
only being two users in all these years might be a sign that we
don't really need it, especially since in the initial patch
description it was stated that it is experimental :)</p>
<br>
<p
style="margin-top:0;margin-bottom:0;margin-left:0;margin-right:0;">Regards</p>
<p
style="margin-top:0;margin-bottom:0;margin-left:0;margin-right:0;">Alex</p>
<br>
<br>
<p
style="margin-top:0;margin-bottom:0;margin-left:0;margin-right:0;">On
Thursday, July 29, 2021 2:29:01 PM CEST Nicolas Fella wrote:</p>
<p
style="margin-top:0;margin-bottom:0;margin-left:0;margin-right:0;">>
Hi,</p>
<p
style="margin-top:0;margin-bottom:0;margin-left:0;margin-right:0;">>
</p>
<p
style="margin-top:0;margin-bottom:0;margin-left:0;margin-right:0;">>
in</p>
<p
style="margin-top:0;margin-bottom:0;margin-left:0;margin-right:0;">>
<a class="moz-txt-link-freetext" href="https://invent.kde.org/frameworks/plasma-framework/-/blob/master/KF5PlasmaMa">https://invent.kde.org/frameworks/plasma-framework/-/blob/master/KF5PlasmaMa</a></p>
<p
style="margin-top:0;margin-bottom:0;margin-left:0;margin-right:0;">>
cros.cmake#L12 we recommend using plasma_install_bundled_package
over</p>
<p
style="margin-top:0;margin-bottom:0;margin-left:0;margin-right:0;">>
plasma_install_package.</p>
<p
style="margin-top:0;margin-bottom:0;margin-left:0;margin-right:0;">>
</p>
<p
style="margin-top:0;margin-bottom:0;margin-left:0;margin-right:0;">>
However in practice we always use the latter, except for
plasma-pa and</p>
<p
style="margin-top:0;margin-bottom:0;margin-left:0;margin-right:0;">>
plasma-nm.</p>
<p
style="margin-top:0;margin-bottom:0;margin-left:0;margin-right:0;">>
</p>
<p
style="margin-top:0;margin-bottom:0;margin-left:0;margin-right:0;">>
I stumbled across this because the bundled version does not seem
to</p>
<p
style="margin-top:0;margin-bottom:0;margin-left:0;margin-right:0;">>
create a metadata.json from the metadata.desktop like the other
macro</p>
<p
style="margin-top:0;margin-bottom:0;margin-left:0;margin-right:0;">>
does. That means that the desktop file needs to be converted to
json at</p>
<p
style="margin-top:0;margin-bottom:0;margin-left:0;margin-right:0;">>
runtime which comes with a significant performance overhead when
loading</p>
<p
style="margin-top:0;margin-bottom:0;margin-left:0;margin-right:0;">>
a plasmoid.</p>
<p
style="margin-top:0;margin-bottom:0;margin-left:0;margin-right:0;">>
</p>
<p
style="margin-top:0;margin-bottom:0;margin-left:0;margin-right:0;">>
Now I'm wondering whether we should fix
plasma_install_bundled_package</p>
<p
style="margin-top:0;margin-bottom:0;margin-left:0;margin-right:0;">>
or port the two users away from it and abandon it.</p>
<p
style="margin-top:0;margin-bottom:0;margin-left:0;margin-right:0;">>
</p>
<p
style="margin-top:0;margin-bottom:0;margin-left:0;margin-right:0;">>
Thoughts?</p>
<p
style="margin-top:0;margin-bottom:0;margin-left:0;margin-right:0;">>
</p>
<p
style="margin-top:0;margin-bottom:0;margin-left:0;margin-right:0;">>
Cheers</p>
<p
style="margin-top:0;margin-bottom:0;margin-left:0;margin-right:0;">>
</p>
<p
style="margin-top:0;margin-bottom:0;margin-left:0;margin-right:0;">>
Nico</p>
<br>
<br>
</blockquote>
</body>
</html>