<table><tr><td style="">jpalecek added a comment.
</td><a style="text-decoration: none; padding: 4px 8px; margin: 0 8px 8px; float: right; color: #464C5C; font-weight: bold; border-radius: 3px; background-color: #F7F7F9; background-image: linear-gradient(to bottom,#fff,#f1f0f1); display: inline-block; border: 1px solid rgba(71,87,120,.2);" href="https://phabricator.kde.org/D29808">View Revision</a></tr></table><br /><div><div><blockquote style="border-left: 3px solid #8C98B8;
color: #6B748C;
font-style: italic;
margin: 4px 0 12px 0;
padding: 8px 12px;
background-color: #F8F9FC;">
<div style="font-style: normal;
padding-bottom: 4px;">In <a href="https://phabricator.kde.org/D29808#673157" style="background-color: #e7e7e7;
border-color: #e7e7e7;
border-radius: 3px;
padding: 0 4px;
font-weight: bold;
color: black;text-decoration: none;">D29808#673157</a>, <a href="https://phabricator.kde.org/p/sandsmark/" style="
border-color: #f1f7ff;
color: #19558d;
background-color: #f1f7ff;
border: 1px solid transparent;
border-radius: 3px;
font-weight: bold;
padding: 0 4px;">@sandsmark</a> wrote:</div>
<div style="margin: 0;
padding: 0;
border: 0;
color: rgb(107, 116, 140);"><blockquote style="border-left: 3px solid #a7b5bf; color: #464c5c; font-style: italic; margin: 4px 0 12px 0; padding: 4px 12px; background-color: #f8f9fc;"><p>It's all C code whereas the rest of the helper is C++. It also relies very heavily on magic numbers now.</p></blockquote>
<blockquote style="border-left: 3px solid #a7b5bf; color: #464c5c; font-style: italic; margin: 4px 0 12px 0; padding: 4px 12px; background-color: #f8f9fc;"><p>I think a much simpler implementation would be to split each line on " ", select the fields we want and clean them up.</p></blockquote>
<p>I assume this is for performance reasons, but a tiny microbenchmark showing that it is actually faster would be nice.</p></div>
</blockquote>
<p>Hi! Just out of curiosity (I'm not the OP), I created a microbenchmark here: <a href="https://github.com/jpalecek/ksysguard-network-microbenchmark" class="remarkup-link" target="_blank" rel="noreferrer">https://github.com/jpalecek/ksysguard-network-microbenchmark</a>. As a fun project, I added a Boost.Sphinx implementation, which was remarkably easy. Not the most readable code ever, beware. Some bugs were found while doing this (in both old and new implementation), see the code.</p></div></div><br /><div><strong>INLINE COMMENTS</strong><div><div style="margin: 6px 0 12px 0;"><div style="border: 1px solid #C7CCD9; border-radius: 3px;"><div style="padding: 0; background: #F7F7F7; border-color: #e3e4e8; border-style: solid; border-width: 0 0 1px 0; margin: 0;"><div style="color: #74777d; background: #eff2f4; padding: 6px 8px; overflow: hidden;"><a style="float: right; text-decoration: none;" href="https://phabricator.kde.org/D29808#inline-170834">View Inline</a><span style="color: #4b4d51; font-weight: bold;">sandsmark</span> wrote in <span style="color: #4b4d51; font-weight: bold;">ConnectionMapping.cpp:167</span></div>
<div style="margin: 8px 0; padding: 0 12px; color: #74777D;"><p style="padding: 0; margin: 8px;">instead of 87 + 1, maybe have a <tt style="background: #ebebeb; font-size: 13px;">constexpr int lineLength = strlen("0: 00000000000000000000000001000000:0277 00000000000000000000000000000000:0000 0A 00000000:00000000 00:00000000 00000000 0 0 16741");</tt> above with the comment?<br />
or:</p>
<div class="remarkup-code-block" style="margin: 12px 0;" data-code-lang="text" data-sigil="remarkup-code-block"><pre class="remarkup-code" style="font: 11px/15px "Menlo", "Consolas", "Monaco", monospace; padding: 12px; margin: 0; background: rgba(71, 87, 120, 0.08);">constexpr const char *exampleLine = "0: 00000000000000000000000001000000:0277 00000000000000000000000000000000:0000 0A 00000000:00000000 00:00000000 00000000 0 0 16741";
constexpr int lineLength = strlen(exampleLine);</pre></div>
<p style="padding: 0; margin: 8px;">both more understandable and less prone to accidentally putting in the wrong number.</p>
<p style="padding: 0; margin: 8px;">same with all other magic string offset numbers here.</p></div></div>
<div style="margin: 8px 0; padding: 0 12px;"><p style="padding: 0; margin: 8px;">Actually I don't agree with that view. I don't think <tt style="background: #ebebeb; font-size: 13px;">lineLength = strlen("0: 00000000000000000000000...</tt>)<tt style="background: #ebebeb; font-size: 13px;"> is readable and less error prone than </tt>87`, only longer by ~100 characters and a nightmare to check. With numbers, I can check with an editor that shows column numbers and simple arithmetic, but comparing such long strings made of spaces is hard.</p>
<p style="padding: 0; margin: 8px;">If you want more robustness, I would suggest using the fact that the number columns are aligned with the header and using something like <tt style="background: #ebebeb; font-size: 13px;">inode_col = header.find("inode")</tt>. Or counting the fields. That would also take care of the possibility that the columns may not be same width across architectures (?)</p></div></div></div></div></div><br /><div><strong>REPOSITORY</strong><div><div>R106 KSysguard</div></div></div><br /><div><strong>REVISION DETAIL</strong><div><a href="https://phabricator.kde.org/D29808">https://phabricator.kde.org/D29808</a></div></div><br /><div><strong>To: </strong>dkorth, ahiemstra<br /><strong>Cc: </strong>sandsmark, ahiemstra, jpalecek, plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, jraleigh, zachus, fbampaloukas, ragreen, ZrenBot, ngraham, himcesjf, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart<br /></div>