<table><tr><td style="">alex updated this revision to Diff 83116.<br />alex retitled this revision from "WIP: Change Chrome API design" to "Change Chrome API design".<br />alex edited the summary of this revision. <a href="https://phabricator.kde.org/transactions/detail/PHID-XACT-DREV-lu252psaquvpjvt/">(Show Details)</a><br />alex added reviewers: ngraham, meven.<br />alex added a comment.
</td><a style="text-decoration: none; padding: 4px 8px; margin: 0 8px 8px; float: right; color: #464C5C; font-weight: bold; border-radius: 3px; background-color: #F7F7F9; background-image: linear-gradient(to bottom,#fff,#f1f0f1); display: inline-block; border: 1px solid rgba(71,87,120,.2);" href="https://phabricator.kde.org/D29807">View Revision</a></tr></table><br /><div><div><p>Change import, formatting</p></div></div><br /><div><strong>CHANGES TO REVISION SUMMARY</strong><div><div style="white-space: pre-wrap; color: #74777D;"><div style="padding: 8px 0;">...</div>- Better error handling<span style="padding: 0 2px; color: #333333; background: rgba(251, 175, 175, .7);"><br />
<br />
TODO: Adjust tests for chrome<br />
Have a second look at the changes ;-)</span></div></div></div><br /><div><strong>REPOSITORY</strong><div><div>R120 Plasma Workspace</div></div></div><br /><div><strong>CHANGES SINCE LAST UPDATE</strong><div><a href="https://phabricator.kde.org/D29807?vs=83029&id=83116">https://phabricator.kde.org/D29807?vs=83029&id=83116</a></div></div><br /><div><strong>BRANCH</strong><div><div>api_inconsistencies (branched from master)</div></div></div><br /><div><strong>REVISION DETAIL</strong><div><a href="https://phabricator.kde.org/D29807">https://phabricator.kde.org/D29807</a></div></div><br /><div><strong>AFFECTED FILES</strong><div><div>runners/bookmarks/CMakeLists.txt<br />
runners/bookmarks/browserfactory.cpp<br />
runners/bookmarks/browsers/chrome.cpp<br />
runners/bookmarks/browsers/chrome.h<br />
runners/bookmarks/browsers/chromefindprofile.cpp<br />
runners/bookmarks/browsers/chromefindprofile.h<br />
runners/bookmarks/browsers/chromeprofile.cpp<br />
runners/bookmarks/browsers/chromeprofile.h<br />
runners/bookmarks/browsers/findprofile.h<br />
runners/bookmarks/faviconfromblob.cpp<br />
runners/bookmarks/faviconfromblob.h<br />
runners/bookmarks/fetchsqlite.cpp<br />
runners/bookmarks/fetchsqlite.h<br />
runners/bookmarks/tests/CMakeLists.txt<br />
runners/bookmarks/tests/chrome-config-home/.config/chromium/Local State<br />
runners/bookmarks/tests/chrome-config-home/Chrome-Bookmarks-Sample.json<br />
runners/bookmarks/tests/chrome-config-home/Chrome-Bookmarks-SecondProfile.json<br />
runners/bookmarks/tests/chromium/Default/Bookmarks<br />
runners/bookmarks/tests/chromium/Local State<br />
runners/bookmarks/tests/chromium/Profile 1/Bookmarks<br />
runners/bookmarks/tests/testchromebookmarks.cpp<br />
runners/bookmarks/tests/testchromebookmarks.h</div></div></div><br /><div><strong>To: </strong>alex, broulik, Plasma, ngraham, meven<br /><strong>Cc: </strong>anthonyfieroni, plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, jraleigh, zachus, fbampaloukas, ragreen, ZrenBot, ngraham, himcesjf, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart<br /></div>