<table><tr><td style="">mvourlakos added a comment.
</td><a style="text-decoration: none; padding: 4px 8px; margin: 0 8px 8px; float: right; color: #464C5C; font-weight: bold; border-radius: 3px; background-color: #F7F7F9; background-image: linear-gradient(to bottom,#fff,#f1f0f1); display: inline-block; border: 1px solid rgba(71,87,120,.2);" href="https://phabricator.kde.org/D29823">View Revision</a></tr></table><br /><div><div><ol class="remarkup-list">
<li class="remarkup-list-item">Provide videos with before and after</li>
<li class="remarkup-list-item">I dont think I am interested in adding a bounce slider in Tasks for this</li>
<li class="remarkup-list-item">You increase the max zoom factor to 500% this is out of scope</li>
<li class="remarkup-list-item">I can accept an improvement for bouncing animation but without [2] and [3] and as long as the improvement is not subjective</li>
</ol></div></div><br /><div><strong>INLINE COMMENTS</strong><div><div style="margin: 6px 0 12px 0;"><div style="border: 1px solid #C7CCD9; border-radius: 3px;"><div style="padding: 0; background: #F7F7F7; border-color: #e3e4e8; border-style: solid; border-width: 0 0 1px 0; margin: 0;"><div style="color: #74777d; background: #eff2f4; padding: 6px 8px; overflow: hidden;"><a style="float: right; text-decoration: none;" href="https://phabricator.kde.org/D29823#inline-170883">View Inline</a><span style="color: #4b4d51; font-weight: bold;">LauncherAnimation.qml:54</span></div>
<div style="font: 11px/15px "Menlo", "Consolas", "Monaco", monospace; white-space: pre-wrap; clear: both; padding: 4px 0; margin: 0;"><div style="padding: 0 8px; margin: 0 4px; "> <span style="color: #aa4000">property:</span> <span class="p">(</span><span style="color: #004012">icList</span><span class="p">.</span><span style="color: #004012">orientation</span> <span style="color: #aa2211">==</span> <span style="color: #004012">Qt</span><span class="p">.</span><span style="color: #004012">Vertical</span><span class="p">)</span> <span style="color: #aa2211">?</span> <span style="color: #766510">"tempScaleWidth"</span> <span style="color: #aa2211">:</span> <span style="color: #766510">"tempScaleHeight"</span>
</div><div style="padding: 0 8px; margin: 0 4px; background: rgba(251, 175, 175, .7);"> <span class="bright"></span><span style="color: #aa4000"><span class="bright">to:</span></span><span class="bright"> </span><span style="color: #004012"><span class="bright">taskItem</span></span><span class="bright"></span><span class="p"><span class="bright">.</span></span><span class="bright"></span><span style="color: #004012"><span class="bright">containsMouse</span></span><span class="bright"> </span><span style="color: #aa2211"><span class="bright">?</span></span><span class="bright"> </span><span style="color: #601200"><span class="bright">1</span></span><span class="bright"></span><span style="color: #aa2211"><span class="bright">+</span></span><span class="bright"></span><span style="color: #601200"><span class="bright">2</span></span><span class="bright"></span><span style="color: #aa2211"><span class="bright">*</span></span><span class="bright"></span><span class="p"><span class="bright">(</span></span><span class="bright"></span><span style="color: #004012"><span class="bright">taskItem</span></span><span class="bright"></span><span class="p"><span class="bright">.</span></span><span class="bright"></span><span style="color: #004012"><span class="bright">parabolic</span></span><span class="bright"></span><span class="p"><span class="bright">.</span></span><span class="bright"></span><span style="color: #004012"><span class="bright">factor</span></span><span class="bright"></span><span class="p"><span class="bright">.</span></span><span class="bright"></span><span style="color: #004012"><span class="bright">maxZoom</span></span><span class="bright"></span><span style="color: #aa2211"><span class="bright">-</span></span><span class="bright"></span><span style="color: #601200"><span class="bright">1</span></span><span class="bright"></span><span class="p"><span class="bright">)</span></span><span class="bright"> </span><span style="color: #aa2211"><span class="bright">:</span></span><span class="bright"> </span><span style="color: #601200"><span class="bright">1</span></span><span class="bright"> </span><span style="color: #aa2211"><span class="bright">+</span></span><span class="bright"> </span><span class="p"><span class="bright">(</span></span><span class="bright"></span><span style="color: #601200"><span class="bright">0.65</span></span><span class="bright"> </span><span style="color: #aa2211"><span class="bright">*</span></span><span class="bright"> </span><span class="p"><span class="bright">(</span></span><span class="bright"></span><span style="color: #004012"><span class="bright">taskItem</span></span><span class="bright"></span><span class="p"><span class="bright">.</span></span><span class="bright"></span><span style="color: #004012"><span class="bright">parabolic</span></span><span class="bright"></span><span class="p"><span class="bright">.</span></span><span class="bright"></span><span style="color: #004012"><span class="bright">factor</span></span><span class="bright"></span><span class="p"><span class="bright">.</span></span><span class="bright"></span><span style="color: #004012"><span class="bright">maxZoom</span></span><span class="bright"></span><span style="color: #aa2211"><span class="bright">-</span></span><span class="bright"></span><span style="color: #601200"><span class="bright">1</span></span><span class="bright"></span><span class="p"><span class="bright">))</span></span>
</div><div style="padding: 0 8px; margin: 0 4px; background: rgba(151, 234, 151, .6);"> <span class="bright"></span><span style="color: #74777d"><span class="bright">//TODO Add a slider in the AppearanceConfig to adjust the launcherBounceLevel value</span></span>
</div><div style="padding: 0 8px; margin: 0 4px; background: rgba(151, 234, 151, .6);"> <span style="color: #aa4000">to:</span> <span style="color: #004012">taskItem</span><span class="p">.</span><span style="color: #004012">containsMouse</span> <span style="color: #aa2211">?</span> <span style="color: #601200">1</span><span style="color: #aa2211">+</span><span style="color: #601200">2</span><span style="color: #aa2211">*</span><span class="p">(</span><span style="color: #004012">plasmoid</span><span class="p">.</span><span style="color: #004012">configuration</span><span class="p">.</span><span style="color: #004012">launcherBounceLevel</span><span style="color: #aa2211">/</span><span style="color: #601200">10</span> <span style="color: #aa2211">-</span><span style="color: #601200">1</span><span class="p">)</span> <span style="color: #aa2211">:</span> <span style="color: #601200">1</span> <span style="color: #aa2211">+</span> <span class="p">(</span><span style="color: #601200">0.65</span> <span style="color: #aa2211">*</span> <span class="p">(</span><span style="color: #004012">plasmoid</span><span class="p">.</span><span style="color: #004012">configuration</span><span class="p">.</span><span style="color: #004012">launcherBounceLevel</span> <span style="color: #aa2211">/</span><span style="color: #601200">10</span><span style="color: #aa2211">-</span><span style="color: #601200">1</span><span class="p">))</span>
</div></div></div>
<div style="margin: 8px 0; padding: 0 12px;"><p style="padding: 0; margin: 8px;">I am not interested in adding a launcher bounce level slider</p></div></div><br /><div style="border: 1px solid #C7CCD9; border-radius: 3px;"><div style="padding: 0; background: #F7F7F7; border-color: #e3e4e8; border-style: solid; border-width: 0 0 1px 0; margin: 0;"><div style="color: #74777d; background: #eff2f4; padding: 6px 8px; overflow: hidden;"><a style="float: right; text-decoration: none;" href="https://phabricator.kde.org/D29823#inline-170882">View Inline</a><span style="color: #4b4d51; font-weight: bold;">AppearanceConfig.qml:283</span></div>
<div style="font: 11px/15px "Menlo", "Consolas", "Monaco", monospace; white-space: pre-wrap; clear: both; padding: 4px 0; margin: 0;"><div style="padding: 0 8px; margin: 0 4px; "> <span style="color: #aa4000">from:</span> <span style="color: #601200">1</span>
</div><div style="padding: 0 8px; margin: 0 4px; background: rgba(251, 175, 175, .7);"> <span style="color: #aa4000">to:</span> <span class="bright"></span><span style="color: #601200"><span class="bright">2</span></span>
</div><div style="padding: 0 8px; margin: 0 4px; background: rgba(151, 234, 151, .6);"> <span style="color: #aa4000">to:</span> <span class="bright"></span><span style="color: #601200"><span class="bright">5</span></span>
</div><div style="padding: 0 8px; margin: 0 4px; "> <span style="color: #aa4000">stepSize:</span> <span style="color: #601200">0.05</span>
</div></div></div>
<div style="margin: 8px 0; padding: 0 12px;"><p style="padding: 0; margin: 8px;">how this is relevant to your comments?<br />
you increase the maximum zoom level from 200% to 500%</p></div></div></div></div></div><br /><div><strong>REPOSITORY</strong><div><div>R878 Latte Dock</div></div></div><br /><div><strong>REVISION DETAIL</strong><div><a href="https://phabricator.kde.org/D29823">https://phabricator.kde.org/D29823</a></div></div><br /><div><strong>To: </strong>parsa, mvourlakos<br /><strong>Cc: </strong>plasma-devel, acemond, Orage, LeGast00n, The-Feren-OS-Dev, cblack, kkoma, jraleigh, zachus, mbehrendt, fbampaloukas, niccolove, ragreen, lavender, ZrenBot, ngraham, himcesjf, mvourlakos, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart<br /></div>