<table><tr><td style="">filipf accepted this revision.<br />filipf added inline comments.<br />This revision is now accepted and ready to land.
</td><a style="text-decoration: none; padding: 4px 8px; margin: 0 8px 8px; float: right; color: #464C5C; font-weight: bold; border-radius: 3px; background-color: #F7F7F9; background-image: linear-gradient(to bottom,#fff,#f1f0f1); display: inline-block; border: 1px solid rgba(71,87,120,.2);" href="https://phabricator.kde.org/D29689">View Revision</a></tr></table><br /><div><strong>INLINE COMMENTS</strong><div><div style="margin: 6px 0 12px 0;"><div style="border: 1px solid #C7CCD9; border-radius: 3px;"><div style="padding: 0; background: #F7F7F7; border-color: #e3e4e8; border-style: solid; border-width: 0 0 1px 0; margin: 0;"><div style="color: #74777d; background: #eff2f4; padding: 6px 8px; overflow: hidden;"><a style="float: right; text-decoration: none;" href="https://phabricator.kde.org/D29689#inline-169907">View Inline</a><span style="color: #4b4d51; font-weight: bold;">ApplicationsListPage.qml:152</span></div>
<div style="font: 11px/15px "Menlo", "Consolas", "Monaco", monospace; white-space: pre-wrap; clear: both; padding: 4px 0; margin: 0;"><div style="padding: 0 8px; margin: 0 4px; background: rgba(151, 234, 151, .6);">            <span style="color: #aa4000">visible:</span> <span style="color: #004012">opacity</span> <span style="color: #aa2211">!=</span> <span style="color: #601200">0</span>
</div><div style="padding: 0 8px; margin: 0 4px; background: rgba(151, 234, 151, .6);">            <span style="color: #aa4000">opacity:</span> <span style="color: #004012">apps</span><span class="p">.</span><span style="color: #004012">count</span> <span style="color: #aa2211">==</span> <span style="color: #601200">0</span> <span style="color: #aa2211">&&</span> <span style="color: #aa2211">!</span><span style="color: #004012">appsModel</span><span class="p">.</span><span style="color: #004012">isBusy</span> <span style="color: #aa2211">?</span> <span style="color: #601200">1</span> <span style="color: #aa2211">:</span> <span style="color: #601200">0</span>
</div></div></div>
<div style="margin: 8px 0; padding: 0 12px;"><p style="padding: 0; margin: 8px;">Should work without this, no?</p></div></div><br /><div style="border: 1px solid #C7CCD9; border-radius: 3px;"><div style="padding: 0; background: #F7F7F7; border-color: #e3e4e8; border-style: solid; border-width: 0 0 1px 0; margin: 0;"><div style="color: #74777d; background: #eff2f4; padding: 6px 8px; overflow: hidden;"><a style="float: right; text-decoration: none;" href="https://phabricator.kde.org/D29689#inline-169905">View Inline</a><span style="color: #4b4d51; font-weight: bold;">ApplicationsListPage.qml:154</span></div>
<div style="font: 11px/15px "Menlo", "Consolas", "Monaco", monospace; white-space: pre-wrap; clear: both; padding: 4px 0; margin: 0;"><div style="padding: 0 8px; margin: 0 4px; background: rgba(151, 234, 151, .6);">            <span style="color: #aa4000">opacity:</span> <span style="color: #004012">apps</span><span class="p">.</span><span style="color: #004012">count</span> <span style="color: #aa2211">==</span> <span style="color: #601200">0</span> <span style="color: #aa2211">&&</span> <span style="color: #aa2211">!</span><span style="color: #004012">appsModel</span><span class="p">.</span><span style="color: #004012">isBusy</span> <span style="color: #aa2211">?</span> <span style="color: #601200">1</span> <span style="color: #aa2211">:</span> <span style="color: #601200">0</span>
</div><div style="padding: 0 8px; margin: 0 4px; ">            <span style="color: #004012">Behavior</span> <span style="color: #004012">on</span> <span style="color: #004012">opacity</span> <span class="p">{</span> <span style="color: #004012">PropertyAnimation</span> <span class="p">{</span> <span style="color: #aa4000">duration:</span> <span style="color: #004012">Kirigami</span><span class="p">.</span><span style="color: #004012">Units</span><span class="p">.</span><span style="color: #004012">longDuration</span><span class="p">;</span> <span style="color: #aa4000">easing.type:</span> <span style="color: #004012">Easing</span><span class="p">.</span><span style="color: #004012">InOutQuad</span> <span class="p">}</span> <span class="p">}</span>
</div><div style="padding: 0 8px; margin: 0 4px; background: rgba(251, 175, 175, .7);"><span class="bright">            </span><span style="color: #aa4000"><span class="bright">text:</span></span><span class="bright"> </span><span style="color: #004012"><span class="bright">i18n</span></span><span class="bright"></span><span class="p"><span class="bright">(</span></span><span class="bright"></span><span style="color: #766510"><span class="bright">"Sorry, nothing found..."</span></span><span class="bright"></span><span class="p"><span class="bright">)</span></span>
</div></div></div>
<div style="margin: 8px 0; padding: 0 12px;"><p style="padding: 0; margin: 8px;">Probably worth it to port this to NumberAnimation at a different time since Marco said it's more efficient.</p></div></div></div></div></div><br /><div><strong>REPOSITORY</strong><div><div>R134 Discover Software Store</div></div></div><br /><div><strong>BRANCH</strong><div><div>port-to-placeholdermessage (branched from master)</div></div></div><br /><div><strong>REVISION DETAIL</strong><div><a href="https://phabricator.kde.org/D29689">https://phabricator.kde.org/D29689</a></div></div><br /><div><strong>To: </strong>ngraham, apol, Discover Software Store, VDG, filipf<br /><strong>Cc: </strong>filipf, plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, jraleigh, zachus, fbampaloukas, ragreen, ZrenBot, ngraham, himcesjf, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart<br /></div>