<table><tr><td style="">ngraham added a comment.
</td><a style="text-decoration: none; padding: 4px 8px; margin: 0 8px 8px; float: right; color: #464C5C; font-weight: bold; border-radius: 3px; background-color: #F7F7F9; background-image: linear-gradient(to bottom,#fff,#f1f0f1); display: inline-block; border: 1px solid rgba(71,87,120,.2);" href="https://phabricator.kde.org/D28154">View Revision</a></tr></table><br /><div><div><p>Great. We're getting pretty close to the UI being finished IMO. I'll start on the QML code review soon. In the meantime I found a few more little behavioral issues:</p>
<ol class="remarkup-list">
<li class="remarkup-list-item">The <span><span class="phui-tag-view phui-tag-type-shade phui-tag-grey phui-tag-shade "><span class="phui-tag-core ">Reset</span></span></span> button correctly activates when the KCM is in a dirty state, but doesn't seem to actually reset anything when clicked.</li>
<li class="remarkup-list-item">I haven't figured how to reproduce this 100% of the time, and I'm not sure if it's an issue with the OverlaySheet itself or the implementation here, but when I do a two-finger scroll over the avatar sheet, sometimes it scrolls mostly out of the view in a very weird way: <a href="https://phabricator.kde.org/F8288148" style="background-color: #e7e7e7;
border-color: #e7e7e7;
border-radius: 3px;
padding: 0 4px;
font-weight: bold;
color: black;text-decoration: none;">F8288148: vokoscreenNG-2020-05-05_20-53-05.webm</a> I don't think there's anything weird with my touchpad as I don't see this in other scrollable views.</li>
</ol></div></div><br /><div><strong>INLINE COMMENTS</strong><div><div style="margin: 6px 0 12px 0;"><div style="border: 1px solid #C7CCD9; border-radius: 3px;"><div style="padding: 0; background: #F7F7F7; border-color: #e3e4e8; border-style: solid; border-width: 0 0 1px 0; margin: 0;"><div style="color: #74777d; background: #eff2f4; padding: 6px 8px; overflow: hidden;"><a style="float: right; text-decoration: none;" href="https://phabricator.kde.org/D28154#inline-168687">View Inline</a><span style="color: #4b4d51; font-weight: bold;">main.qml:54</span></div>
<div style="font: 11px/15px "Menlo", "Consolas", "Monaco", monospace; white-space: pre-wrap; clear: both; padding: 4px 0; margin: 0;"><div style="padding: 0 8px; margin: 0 4px; background: rgba(151, 234, 151, .6);"> <span style="color: #aa4000">delegate:</span> <span style="color: #004012">Kirigami</span><span class="p">.</span><span style="color: #004012">AbstractListItem</span> <span class="p">{</span>
</div><div style="padding: 0 8px; margin: 0 4px; background: rgba(151, 234, 151, .6);"> <span style="color: #aa4000">width:</span> <span style="color: #004012">userList</span><span class="p">.</span><span style="color: #004012">width</span>
</div></div></div>
<div style="margin: 8px 0; padding: 0 12px;"><p style="padding: 0; margin: 8px;">Could this be a BasicListItem with a title and subtitle, or is that not possible because you can't render the avatar+circle into an image source to feed it?</p></div></div><br /><div style="border: 1px solid #C7CCD9; border-radius: 3px;"><div style="padding: 0; background: #F7F7F7; border-color: #e3e4e8; border-style: solid; border-width: 0 0 1px 0; margin: 0;"><div style="color: #74777d; background: #eff2f4; padding: 6px 8px; overflow: hidden;"><a style="float: right; text-decoration: none;" href="https://phabricator.kde.org/D28154#inline-168688">View Inline</a><span style="color: #4b4d51; font-weight: bold;">main.qml:96</span></div>
<div style="font: 11px/15px "Menlo", "Consolas", "Monaco", monospace; white-space: pre-wrap; clear: both; padding: 4px 0; margin: 0;"><div style="padding: 0 8px; margin: 0 4px; background: rgba(151, 234, 151, .6);"> <span style="color: #aa4000">color:</span> <span style="color: #766510">"transparent"</span>
</div><div style="padding: 0 8px; margin: 0 4px; background: rgba(151, 234, 151, .6);"> <span style="color: #004012">property</span> <span style="color: #004012">color</span> <span style="color: #aa4000">kule:</span> <span style="color: #004012">Kirigami</span><span class="p">.</span><span style="color: #004012">Theme</span><span class="p">.</span><span style="color: #004012">textColor</span>
</div><div style="padding: 0 8px; margin: 0 4px; background: rgba(151, 234, 151, .6);"> <span style="color: #aa4000">border.color:</span> <span style="color: #004012">Qt</span><span class="p">.</span><span style="color: #004012">rgba</span><span class="p">(</span><span style="color: #004012">kule</span><span class="p">.</span><span style="color: #004012">r</span><span class="p">,</span> <span style="color: #004012">kule</span><span class="p">.</span><span style="color: #004012">g</span><span class="p">,</span> <span style="color: #004012">kule</span><span class="p">.</span><span style="color: #004012">b</span><span class="p">,</span> <span style="color: #601200">0.4</span><span class="p">)</span>
</div></div></div>
<div style="margin: 8px 0; padding: 0 12px;"><p style="padding: 0; margin: 8px;">"kule"?</p></div></div></div></div></div><br /><div><strong>REPOSITORY</strong><div><div>R119 Plasma Desktop</div></div></div><br /><div><strong>REVISION DETAIL</strong><div><a href="https://phabricator.kde.org/D28154">https://phabricator.kde.org/D28154</a></div></div><br /><div><strong>To: </strong>cblack, Plasma, VDG, ngraham<br /><strong>Cc: </strong>yurchor, iasensio, meven, crossi, The-Feren-OS-Dev, davidedmundson, broulik, filipf, ngraham, nicolasfella, zzag, plasma-devel, Orage, LeGast00n, cblack, jraleigh, zachus, fbampaloukas, ragreen, ZrenBot, himcesjf, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart<br /></div>