<table><tr><td style="">ngraham added a comment.
</td><a style="text-decoration: none; padding: 4px 8px; margin: 0 8px 8px; float: right; color: #464C5C; font-weight: bold; border-radius: 3px; background-color: #F7F7F9; background-image: linear-gradient(to bottom,#fff,#f1f0f1); display: inline-block; border: 1px solid rgba(71,87,120,.2);" href="https://phabricator.kde.org/D28487">View Revision</a></tr></table><br /><div><div><p>Looks fantastic!</p>

<p>However I've applied the dependent patches, but this doesn't compile for me:</p>

<div class="remarkup-code-block" style="margin: 12px 0;" data-code-lang="text" data-sigil="remarkup-code-block"><pre class="remarkup-code" style="font: 11px/15px "Menlo", "Consolas", "Monaco", monospace; padding: 12px; margin: 0; background: rgba(71, 87, 120, 0.08);"> In member function ‘virtual void SystemMonitor::init()’:
/home/nate/kde/src/plasma-workspace/applets/systemmonitor/systemmonitor/systemmonitor.cpp:63:78: error: invalid use of incomplete type ‘class SensorFaceController’
   63 |     m_sensorFaceController = new SensorFaceController(cg, qmlObject->engine());
      |                                                                              ^
In file included from /home/nate/kde/src/plasma-workspace/applets/systemmonitor/systemmonitor/systemmonitor.cpp:20:
/home/nate/kde/src/plasma-workspace/applets/systemmonitor/systemmonitor/systemmonitor.h:33:7: note: forward declaration of ‘class SensorFaceController’
   33 | class SensorFaceController;
      |       ^~~~~~~~~~~~~~~~~~~~
/home/nate/kde/src/plasma-workspace/applets/systemmonitor/systemmonitor/systemmonitor.cpp:67:31: error: invalid use of incomplete type ‘class SensorFaceController’
   67 |         m_sensorFaceController->loadPreset(m_pendingStartupPreset);
      |                               ^~
In file included from /home/nate/kde/src/plasma-workspace/applets/systemmonitor/systemmonitor/systemmonitor.cpp:20:
/home/nate/kde/src/plasma-workspace/applets/systemmonitor/systemmonitor/systemmonitor.h:33:7: note: forward declaration of ‘class SensorFaceController’
   33 | class SensorFaceController;
      |       ^~~~~~~~~~~~~~~~~~~~
/home/nate/kde/src/plasma-workspace/applets/systemmonitor/systemmonitor/systemmonitor.cpp:71:31: error: invalid use of incomplete type ‘class SensorFaceController’
   71 |         m_sensorFaceController->loadPreset(preset);
      |                               ^~
In file included from /home/nate/kde/src/plasma-workspace/applets/systemmonitor/systemmonitor/systemmonitor.cpp:20:
/home/nate/kde/src/plasma-workspace/applets/systemmonitor/systemmonitor/systemmonitor.h:33:7: note: forward declaration of ‘class SensorFaceController’
   33 | class SensorFaceController;
      |       ^~~~~~~~~~~~~~~~~~~~
/home/nate/kde/src/plasma-workspace/applets/systemmonitor/systemmonitor/systemmonitor.cpp: In member function ‘virtual void SystemMonitor::configChanged()’:
/home/nate/kde/src/plasma-workspace/applets/systemmonitor/systemmonitor/systemmonitor.cpp:83:31: error: invalid use of incomplete type ‘class SensorFaceController’
   83 |         m_sensorFaceController->reloadConfig();
      |                               ^~
In file included from /home/nate/kde/src/plasma-workspace/applets/systemmonitor/systemmonitor/systemmonitor.cpp:20:
/home/nate/kde/src/plasma-workspace/applets/systemmonitor/systemmonitor/systemmonitor.h:33:7: note: forward declaration of ‘class SensorFaceController’
   33 | class SensorFaceController;
      |       ^~~~~~~~~~~~~~~~~~~~</pre></div>

<p>Also the test plan screenshot shows a string overlap issue: <a href="https://phabricator.kde.org/F8283936" style="background-color: #e7e7e7;
          border-color: #e7e7e7;
          border-radius: 3px;
          padding: 0 4px;
          font-weight: bold;
          color: black;text-decoration: none;">F8283936: Screenshot_20200504_085406.png</a></p></div></div><br /><div><strong>REPOSITORY</strong><div><div>R120 Plasma Workspace</div></div></div><br /><div><strong>REVISION DETAIL</strong><div><a href="https://phabricator.kde.org/D28487">https://phabricator.kde.org/D28487</a></div></div><br /><div><strong>To: </strong>mart, Plasma<br /><strong>Cc: </strong>ngraham, ksmanis, davidedmundson, mmustac, ahiemstra, plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, jraleigh, zachus, fbampaloukas, ragreen, ZrenBot, himcesjf, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart<br /></div>