<table><tr><td style="">bruns requested changes to this revision.<br />bruns added a comment.<br />This revision now requires changes to proceed.
</td><a style="text-decoration: none; padding: 4px 8px; margin: 0 8px 8px; float: right; color: #464C5C; font-weight: bold; border-radius: 3px; background-color: #F7F7F9; background-image: linear-gradient(to bottom,#fff,#f1f0f1); display: inline-block; border: 1px solid rgba(71,87,120,.2);" href="https://phabricator.kde.org/D29326">View Revision</a></tr></table><br /><div><div><p>The summary needs some text which works without any images</p>
<p>The code needs some comment which tells how the selection logic works and why it is as it is.</p></div></div><br /><div><strong>INLINE COMMENTS</strong><div><div style="margin: 6px 0 12px 0;"><div style="border: 1px solid #C7CCD9; border-radius: 3px;"><div style="padding: 0; background: #F7F7F7; border-color: #e3e4e8; border-style: solid; border-width: 0 0 1px 0; margin: 0;"><div style="color: #74777d; background: #eff2f4; padding: 6px 8px; overflow: hidden;"><a style="float: right; text-decoration: none;" href="https://phabricator.kde.org/D29326#inline-167820">View Inline</a><span style="color: #4b4d51; font-weight: bold;">firefox.cpp:184</span></div>
<div style="font: 11px/15px "Menlo", "Consolas", "Monaco", monospace; white-space: pre-wrap; clear: both; padding: 4px 0; margin: 0;"><div style="padding: 0 8px; margin: 0 4px; "> <span class="p">}</span> <span style="color: #aa4000">else</span> <span class="p">{</span>
</div><div style="padding: 0 8px; margin: 0 4px; background: rgba(151, 234, 151, .6);"> <span style="color: #aa4000">const</span> <span class="n">QStringList</span> <span class="n">installConfig</span> <span style="color: #aa2211">=</span> <span class="n">firefoxProfile</span><span class="p">.</span><span class="n">groupList</span><span class="p">().</span><span class="n">filter</span><span class="p">(</span><span class="n">QRegularExpression</span><span class="p">(</span><span style="color: #766510">"Install.*"</span><span class="p">));</span>
</div><div style="padding: 0 8px; margin: 0 4px; background: rgba(151, 234, 151, .6);"> <span style="color: #aa4000">if</span> <span class="p">(</span><span class="n">installConfig</span><span class="p">.</span><span class="n">size</span><span class="p">()</span> <span style="color: #aa2211">==</span> <span style="color: #601200">1</span><span class="p">)</span> <span class="p">{</span>
</div></div></div>
<div style="margin: 8px 0; padding: 0 12px;"><p style="padding: 0; margin: 8px;">Missing start of string anchor (^)</p></div></div><br /><div style="border: 1px solid #C7CCD9; border-radius: 3px;"><div style="padding: 0; background: #F7F7F7; border-color: #e3e4e8; border-style: solid; border-width: 0 0 1px 0; margin: 0;"><div style="color: #74777d; background: #eff2f4; padding: 6px 8px; overflow: hidden;"><a style="float: right; text-decoration: none;" href="https://phabricator.kde.org/D29326#inline-167819">View Inline</a><span style="color: #4b4d51; font-weight: bold;">firefox.cpp:185</span></div>
<div style="font: 11px/15px "Menlo", "Consolas", "Monaco", monospace; white-space: pre-wrap; clear: both; padding: 4px 0; margin: 0;"><div style="padding: 0 8px; margin: 0 4px; background: rgba(151, 234, 151, .6);"> <span style="color: #aa4000">const</span> <span class="n">QStringList</span> <span class="n">installConfig</span> <span style="color: #aa2211">=</span> <span class="n">firefoxProfile</span><span class="p">.</span><span class="n">groupList</span><span class="p">().</span><span class="n">filter</span><span class="p">(</span><span class="n">QRegularExpression</span><span class="p">(</span><span style="color: #766510">"Install.*"</span><span class="p">));</span>
</div><div style="padding: 0 8px; margin: 0 4px; background: rgba(151, 234, 151, .6);"> <span style="color: #aa4000">if</span> <span class="p">(</span><span class="n">installConfig</span><span class="p">.</span><span class="n">size</span><span class="p">()</span> <span style="color: #aa2211">==</span> <span style="color: #601200">1</span><span class="p">)</span> <span class="p">{</span>
</div><div style="padding: 0 8px; margin: 0 4px; background: rgba(151, 234, 151, .6);"> <span class="n">profilePath</span> <span style="color: #aa2211">=</span> <span class="n">firefoxProfile</span><span class="p">.</span><span class="n">group</span><span class="p">(</span><span class="n">installConfig</span><span class="p">.</span><span class="n">first</span><span class="p">()).</span><span class="n">readEntry</span><span class="p">(</span><span style="color: #766510">"Default"</span><span class="p">);</span>
</div></div></div>
<div style="margin: 8px 0; padding: 0 12px;"><p style="padding: 0; margin: 8px;">Can this ever be > 1?</p></div></div></div></div></div><br /><div><strong>REPOSITORY</strong><div><div>R120 Plasma Workspace</div></div></div><br /><div><strong>REVISION DETAIL</strong><div><a href="https://phabricator.kde.org/D29326">https://phabricator.kde.org/D29326</a></div></div><br /><div><strong>To: </strong>alex, Plasma, ngraham, bruns, broulik<br /><strong>Cc: </strong>plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, jraleigh, zachus, fbampaloukas, ragreen, ZrenBot, ngraham, himcesjf, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart<br /></div>