<table><tr><td style="">cblack added inline comments.
</td><a style="text-decoration: none; padding: 4px 8px; margin: 0 8px 8px; float: right; color: #464C5C; font-weight: bold; border-radius: 3px; background-color: #F7F7F9; background-image: linear-gradient(to bottom,#fff,#f1f0f1); display: inline-block; border: 1px solid rgba(71,87,120,.2);" href="https://phabricator.kde.org/D29264">View Revision</a></tr></table><br /><div><strong>INLINE COMMENTS</strong><div><div style="margin: 6px 0 12px 0;"><div style="border: 1px solid #C7CCD9; border-radius: 3px;"><div style="padding: 0; background: #F7F7F7; border-color: #e3e4e8; border-style: solid; border-width: 0 0 1px 0; margin: 0;"><div style="color: #74777d; background: #eff2f4; padding: 6px 8px; overflow: hidden;"><a style="float: right; text-decoration: none;" href="https://phabricator.kde.org/D29264#inline-167230">View Inline</a><span style="color: #4b4d51; font-weight: bold;">breezehelper.cpp:1276</span></div>
<div style="font: 11px/15px "Menlo", "Consolas", "Monaco", monospace; white-space: pre-wrap; clear: both; padding: 4px 0; margin: 0;"><div style="padding: 0 8px; margin: 0 4px; "> <span class="n">QRectF</span> <span style="color: #004012">frameRect</span><span class="p">(</span> <span class="n">rect</span> <span class="p">);</span>
</div><div style="padding: 0 8px; margin: 0 4px; background: rgba(251, 175, 175, .7);"> <span class="n">qreal</span> <span style="color: #004012">radius</span><span class="p">(</span> <span class="n">frameRadius</span><span class="p">(</span> <span class="n">PenWidth</span><span style="color: #aa2211">::</span><span class="n">NoPen</span><span class="p">,</span> <span style="color: #aa2211">-</span><span style="color: #601200">1</span> <span class="p">)</span> <span class="p">);</span>
</div><div style="padding: 0 8px; margin: 0 4px; background: rgba(151, 234, 151, .6);"> <span class="n">qreal</span> <span style="color: #004012">radius</span><span class="p">(</span> <span class="bright"></span><span style="color: #601200"><span class="bright">0</span></span><span class="bright"> </span><span class="p"><span class="bright">);</span></span><span class="bright"> </span><span style="color: #74777d"><span class="bright">//</span>frameRadius( PenWidth::NoPen, -1 ) );</span>
</div></div></div>
<div style="margin: 8px 0; padding: 0 12px;"><p style="padding: 0; margin: 8px;">You should remove code rather than commenting it out</p></div></div><br /><div style="border: 1px solid #C7CCD9; border-radius: 3px;"><div style="padding: 0; background: #F7F7F7; border-color: #e3e4e8; border-style: solid; border-width: 0 0 1px 0; margin: 0;"><div style="color: #74777d; background: #eff2f4; padding: 6px 8px; overflow: hidden;"><a style="float: right; text-decoration: none;" href="https://phabricator.kde.org/D29264#inline-167231">View Inline</a><span style="color: #4b4d51; font-weight: bold;">breezestyle.cpp:5447</span></div>
<div style="font: 11px/15px "Menlo", "Consolas", "Monaco", monospace; white-space: pre-wrap; clear: both; padding: 4px 0; margin: 0;"><div style="padding: 0 8px; margin: 0 4px; "> <span style="color: #74777d">// render focus line</span>
</div><div style="padding: 0 8px; margin: 0 4px; background: rgba(251, 175, 175, .7);"> <span class="n">_helper</span><span style="color: #aa2211">-></span><span class="n">renderFocusLine</span><span class="p">(</span> <span class="n">painter</span><span class="p">,</span> <span class="n">textRect</span><span class="p">,</span> <span class="n">focusColor</span> <span class="p">);</span>
</div><div style="padding: 0 8px; margin: 0 4px; background: rgba(151, 234, 151, .6);"> <span class="bright"></span><span style="color: #74777d"><span class="bright">//</span>_helper->renderFocusLine( painter, textRect, focusColor );</span>
</div></div></div>
<div style="margin: 8px 0; padding: 0 12px;"><p style="padding: 0; margin: 8px;">ditto</p></div></div><br /><div style="border: 1px solid #C7CCD9; border-radius: 3px;"><div style="padding: 0; background: #F7F7F7; border-color: #e3e4e8; border-style: solid; border-width: 0 0 1px 0; margin: 0;"><div style="color: #74777d; background: #eff2f4; padding: 6px 8px; overflow: hidden;"><a style="float: right; text-decoration: none;" href="https://phabricator.kde.org/D29264#inline-167232">View Inline</a><span style="color: #4b4d51; font-weight: bold;">breezestyle.cpp:5546</span></div>
<div style="font: 11px/15px "Menlo", "Consolas", "Monaco", monospace; white-space: pre-wrap; clear: both; padding: 4px 0; margin: 0;"><div style="padding: 0 8px; margin: 0 4px; background: rgba(251, 175, 175, .7);"> <span class="n">rect</span><span class="p">.</span><span class="n">adjust</span><span class="p">(</span> <span style="color: #601200">0</span><span class="p">,</span> <span style="color: #601200">1</span><span class="p">,</span> <span style="color: #601200">0</span><span class="p">,</span> <span style="color: #601200">0</span> <span class="p">);</span>
</div><div style="padding: 0 8px; margin: 0 4px; background: rgba(151, 234, 151, .6);"> <span class="n">rect</span><span class="p">.</span><span class="n">adjust</span><span class="p">(</span> <span style="color: #601200">0</span><span class="p">,</span> <span class="bright"></span><span style="color: #aa2211"><span class="bright">-</span></span><span class="bright"> </span><span style="color: #601200">1</span><span class="p">,</span> <span style="color: #601200">0</span><span class="p">,</span> <span style="color: #601200">0</span> <span class="p">);</span>
</div><div style="padding: 0 8px; margin: 0 4px; "> <span style="color: #aa4000">if</span><span class="p">(</span> <span class="n">isFirst</span> <span class="p">)</span> <span class="n">corners</span> <span style="color: #aa2211">|=</span> <span class="n">CornerBottomLeft</span><span class="p">;</span>
</div></div></div>
<div style="margin: 8px 0; padding: 0 12px;"><p style="padding: 0; margin: 8px;">Excess space, should be <tt style="background: #ebebeb; font-size: 13px;">-1</tt></p></div></div><br /><div style="border: 1px solid #C7CCD9; border-radius: 3px;"><div style="padding: 0; background: #F7F7F7; border-color: #e3e4e8; border-style: solid; border-width: 0 0 1px 0; margin: 0;"><div style="color: #74777d; background: #eff2f4; padding: 6px 8px; overflow: hidden;"><a style="float: right; text-decoration: none;" href="https://phabricator.kde.org/D29264#inline-167233">View Inline</a><span style="color: #4b4d51; font-weight: bold;">breezestyle.cpp:5608</span></div>
<div style="font: 11px/15px "Menlo", "Consolas", "Monaco", monospace; white-space: pre-wrap; clear: both; padding: 4px 0; margin: 0;"><div style="padding: 0 8px; margin: 0 4px; "> <span style="color: #aa4000">const</span> <span style="color: #aa4000">auto</span> <span class="n">tabWidget</span> <span style="color: #aa2211">=</span> <span class="p">(</span> <span class="n">widget</span> <span style="color: #aa2211">&&</span> <span class="n">widget</span><span style="color: #aa2211">-></span><span class="n">parentWidget</span><span class="p">()</span> <span class="p">)</span> <span style="color: #aa2211">?</span> <span class="n">qobject_cast</span><span style="color: #aa2211"><</span><span style="color: #aa4000">const</span> <span class="n">QTabWidget</span> <span style="color: #aa2211">*></span><span class="p">(</span> <span class="n">widget</span><span style="color: #aa2211">-></span><span class="n">parentWidget</span><span class="p">()</span> <span class="p">)</span> <span style="color: #aa2211">:</span> <span style="color: #aa4000">nullptr</span><span class="p">;</span>
</div><div style="padding: 0 8px; margin: 0 4px; background: rgba(251, 175, 175, .7);"> <span class="n">documentMode</span> <span style="color: #aa2211">|=</span> <span class="p">(</span> <span class="n">tabWidget</span> <span style="color: #aa2211">?</span> <span class="n">tabWidget</span><span style="color: #aa2211">-></span><span class="n">documentMode</span><span class="p">()</span> <span style="color: #aa2211">:</span> <span style="color: #304a96">true</span> <span class="p">);</span>
</div><div style="padding: 0 8px; margin: 0 4px; background: rgba(151, 234, 151, .6);"> <span class="n">documentMode</span> <span class="bright"></span><span style="color: #aa2211"><span class="bright">=</span></span><span class="bright"> </span><span style="color: #304a96"><span class="bright">true</span></span><span class="bright"></span><span class="p"><span class="bright">;</span></span><span class="bright"> </span><span style="color: #74777d"><span class="bright">//</span>|= ( tabWidget ? tabWidget->documentMode() : true );</span>
</div></div></div>
<div style="margin: 8px 0; padding: 0 12px;"><p style="padding: 0; margin: 8px;">mmm, not sure how I feel about this</p></div></div><br /><div style="border: 1px solid #C7CCD9; border-radius: 3px;"><div style="padding: 0; background: #F7F7F7; border-color: #e3e4e8; border-style: solid; border-width: 0 0 1px 0; margin: 0;"><div style="color: #74777d; background: #eff2f4; padding: 6px 8px; overflow: hidden;"><a style="float: right; text-decoration: none;" href="https://phabricator.kde.org/D29264#inline-167234">View Inline</a><span style="color: #4b4d51; font-weight: bold;">breezestyle.cpp:5610</span></div>
<div style="font: 11px/15px "Menlo", "Consolas", "Monaco", monospace; white-space: pre-wrap; clear: both; padding: 4px 0; margin: 0;"><div style="padding: 0 8px; margin: 0 4px; background: rgba(251, 175, 175, .7);"> <span class="n">color</span> <span style="color: #aa2211">=</span> <span class="bright"></span><span class="p"><span class="bright">(</span></span><span class="bright"></span><span class="n"><span class="bright">documentMode</span></span><span class="bright"></span><span style="color: #aa2211"><span class="bright">&&!</span></span><span class="bright"></span><span class="n"><span class="bright">isQtQuickControl</span></span><span class="bright"></span><span style="color: #aa2211"><span class="bright">&&!</span></span><span class="bright"></span><span class="n"><span class="bright">hasAlteredBackground</span></span><span class="bright"></span><span class="p"><span class="bright">(</span></span><span class="bright"></span><span class="n"><span class="bright">widget</span></span><span class="bright"></span><span class="p"><span class="bright">))</span></span><span class="bright"> </span><span style="color: #aa2211"><span class="bright">?</span></span><span class="bright"> </span><span class="n"><span class="bright">palette</span></span><span class="bright"></span><span class="p"><span class="bright">.</span></span><span class="bright"></span><span class="n"><span class="bright">color</span></span><span class="bright"></span><span class="p"><span class="bright">(</span></span><span class="bright"> </span><span class="n"><span class="bright">QPalette</span></span><span class="bright"></span><span style="color: #aa2211"><span class="bright">::</span></span><span class="bright"></span><span class="n"><span class="bright">Window</span></span><span class="bright"> </span><span class="p"><span class="bright">)</span></span><span class="bright"> </span><span style="color: #aa2211">:</span> <span class="n">_helper</span><span style="color: #aa2211">-></span><span class="n">frameBackgroundColor</span><span class="p">(</span> <span class="n">palette</span> <span class="p">);</span>
</div><div style="padding: 0 8px; margin: 0 4px; background: rgba(151, 234, 151, .6);"> <span class="n">color</span> <span style="color: #aa2211">=</span> <span class="bright"></span><span style="color: #74777d"><span class="bright">/*(documentMode&&!isQtQuickControl&&!hasAlteredBackground(widget)) ?*/</span></span><span class="bright"> </span><span class="n"><span class="bright">palette</span></span><span class="bright"></span><span class="p"><span class="bright">.</span></span><span class="bright"></span><span class="n"><span class="bright">color</span></span><span class="bright"></span><span class="p"><span class="bright">(</span></span><span class="bright"> </span><span class="n"><span class="bright">QPalette</span></span><span class="bright"></span><span style="color: #aa2211"><span class="bright">::</span></span><span class="bright"></span><span class="n"><span class="bright">Window</span></span><span class="bright"> </span><span class="p"><span class="bright">);</span></span><span class="bright"> </span><span style="color: #74777d"><span class="bright">//</span>: _helper->frameBackgroundColor( palette );</span>
</div></div></div>
<div style="margin: 8px 0; padding: 0 12px;"><p style="padding: 0; margin: 8px;">or this</p></div></div><br /><div style="border: 1px solid #C7CCD9; border-radius: 3px;"><div style="padding: 0; background: #F7F7F7; border-color: #e3e4e8; border-style: solid; border-width: 0 0 1px 0; margin: 0;"><div style="color: #74777d; background: #eff2f4; padding: 6px 8px; overflow: hidden;"><a style="float: right; text-decoration: none;" href="https://phabricator.kde.org/D29264#inline-167235">View Inline</a><span style="color: #4b4d51; font-weight: bold;">breezestyle.cpp:5623</span></div>
<div style="font: 11px/15px "Menlo", "Consolas", "Monaco", monospace; white-space: pre-wrap; clear: both; padding: 4px 0; margin: 0;"><div style="padding: 0 8px; margin: 0 4px; "> <span style="color: #74777d">// outline</span>
</div><div style="padding: 0 8px; margin: 0 4px; background: rgba(251, 175, 175, .7);"> <span style="color: #aa4000">const</span> <span style="color: #aa4000">auto</span> <span class="n">outline</span><span class="p">(</span> <span class="bright"></span><span class="n"><span class="bright">selected</span></span> <span style="color: #aa2211">?</span> <span class="n">_helper</span><span style="color: #aa2211">-></span><span class="n">alphaColor</span><span class="p">(</span> <span class="n">palette</span><span class="p">.</span><span class="n">color</span><span class="p">(</span> <span class="n">QPalette</span><span style="color: #aa2211">::</span><span class="n">WindowText</span> <span class="p">),</span> <span style="color: #601200">0.25</span> <span class="p">)</span> <span style="color: #aa2211">:</span> <span class="n">QColor</span><span class="p">()</span> <span class="p">);</span>
</div><div style="padding: 0 8px; margin: 0 4px; background: rgba(151, 234, 151, .6);"> <span style="color: #aa4000">const</span> <span style="color: #aa4000">auto</span> <span class="n">outline</span><span class="p">(</span> <span class="bright"></span><span style="color: #304a96"><span class="bright">true</span></span> <span style="color: #aa2211">?</span> <span class="n">_helper</span><span style="color: #aa2211">-></span><span class="n">alphaColor</span><span class="p">(</span> <span class="n">palette</span><span class="p">.</span><span class="n">color</span><span class="p">(</span> <span class="n">QPalette</span><span style="color: #aa2211">::</span><span class="n">WindowText</span> <span class="p">),</span> <span style="color: #601200">0.25</span> <span class="p">)</span> <span style="color: #aa2211">:</span> <span class="n">QColor</span><span class="p">()</span> <span class="p">);</span>
</div></div></div>
<div style="margin: 8px 0; padding: 0 12px;"><p style="padding: 0; margin: 8px;">... or this</p></div></div></div></div></div><br /><div><strong>REPOSITORY</strong><div><div>R31 Breeze</div></div></div><br /><div><strong>REVISION DETAIL</strong><div><a href="https://phabricator.kde.org/D29264">https://phabricator.kde.org/D29264</a></div></div><br /><div><strong>To: </strong>abstractdevelop, VDG, Breeze<br /><strong>Cc: </strong>cblack, plasma-devel, dmenig, manueljlin, Orage, LeGast00n, The-Feren-OS-Dev, konkinartem, ian, jguidon, Ghost6, jraleigh, zachus, fbampaloukas, squeakypancakes, alexde, IohannesPetros, GB_2, trickyricky26, ragreen, crozbo, ndavis, ZrenBot, firef, ngraham, skadinna, himcesjf, lesliezhai, ali-mohamed, jensreuterberg, aaronhoneycutt, abetts, sebas, apol, ahiemstra, mbohlender, mart<br /></div>