<table><tr><td style="">ngraham added a comment.
</td><a style="text-decoration: none; padding: 4px 8px; margin: 0 8px 8px; float: right; color: #464C5C; font-weight: bold; border-radius: 3px; background-color: #F7F7F9; background-image: linear-gradient(to bottom,#fff,#f1f0f1); display: inline-block; border: 1px solid rgba(71,87,120,.2);" href="https://phabricator.kde.org/D29080">View Revision</a></tr></table><br /><div><div><blockquote style="border-left: 3px solid #8C98B8;
color: #6B748C;
font-style: italic;
margin: 4px 0 12px 0;
padding: 8px 12px;
background-color: #F8F9FC;">
<div style="font-style: normal;
padding-bottom: 4px;">In <a href="https://phabricator.kde.org/D29080#654508" style="background-color: #e7e7e7;
border-color: #e7e7e7;
border-radius: 3px;
padding: 0 4px;
font-weight: bold;
color: black;text-decoration: none;">D29080#654508</a>, <a href="https://phabricator.kde.org/p/romangg/" style="
border-color: #f1f7ff;
color: #19558d;
background-color: #f1f7ff;
border: 1px solid transparent;
border-radius: 3px;
font-weight: bold;
padding: 0 4px;">@romangg</a> wrote:</div>
<div style="margin: 0;
padding: 0;
border: 0;
color: rgb(107, 116, 140);"><p>I like that. KCMs should be more inter-connected anyway. The message could just be shown all the time instead of making it dependent on the font size selected but no need to change that now.</p></div>
</blockquote>
<p>Thanks! I didn't want to show the message all the time as I thought it might get really irritating to the kind of contrarian user who doesn't like being told what to do.</p>
<blockquote style="border-left: 3px solid #8C98B8;
color: #6B748C;
font-style: italic;
margin: 4px 0 12px 0;
padding: 8px 12px;
background-color: #F8F9FC;">
<div style="font-style: normal;
padding-bottom: 4px;">In <a href="https://phabricator.kde.org/D29080#654442" style="background-color: #e7e7e7;
border-color: #e7e7e7;
border-radius: 3px;
padding: 0 4px;
font-weight: bold;
color: black;text-decoration: none;">D29080#654442</a>, <a href="https://phabricator.kde.org/p/ahmadsamir/" style="
border-color: #f1f7ff;
color: #19558d;
background-color: #f1f7ff;
border: 1px solid transparent;
border-radius: 3px;
font-weight: bold;
padding: 0 4px;">@ahmadsamir</a> wrote:</div>
<div style="margin: 0;
padding: 0;
border: 0;
color: rgb(107, 116, 140);"><p>Does InlineMessage have a "Don't show again" capability? it'll become irritating after seeing it 1-2 times.</p></div>
</blockquote>
<p>I was concerned about that too, which is why I set the visibility imperatively rather than with a binding. So with this patch, once you dismiss it, you won't see it again until and unless you change the settings again in a way that would tripped it once more.</p>
<blockquote style="border-left: 3px solid #a7b5bf; color: #464c5c; font-style: italic; margin: 4px 0 12px 0; padding: 4px 12px; background-color: #f8f9fc;"><p>IIUC, the fontsHaveChanged() signal, nothing is listening to it in KDE code doesn't mean other 3rd party software isn't, and it's a change in behaviour for the KCM; I am not sure if it can be repurposed.</p></blockquote>
<p>Seems a bit unlikely to me that other KDE software or even 3rd-party software would be listening for this signal, and IIRC the signal was added after 5.18 anyway so it hasn't been released yet. But hopefully <a href="https://phabricator.kde.org/p/bport/" style="
border-color: #f1f7ff;
color: #19558d;
background-color: #f1f7ff;
border: 1px solid transparent;
border-radius: 3px;
font-weight: bold;
padding: 0 4px;">@bport</a> or a <a href="https://phabricator.kde.org/tag/plasma/" style="background-color: #e7e7e7;
border-color: #e7e7e7;
border-radius: 3px;
padding: 0 4px;
font-weight: bold;
color: black;text-decoration: none;">#plasma</a> person can shed some light on whether or not this is a bad idea.</p></div></div><br /><div><strong>REPOSITORY</strong><div><div>R119 Plasma Desktop</div></div></div><br /><div><strong>BRANCH</strong><div><div>master</div></div></div><br /><div><strong>REVISION DETAIL</strong><div><a href="https://phabricator.kde.org/D29080">https://phabricator.kde.org/D29080</a></div></div><br /><div><strong>To: </strong>ngraham, VDG, Plasma, cblack, bport<br /><strong>Cc: </strong>romangg, ahmadsamir, plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, jraleigh, zachus, fbampaloukas, ragreen, ZrenBot, ngraham, himcesjf, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart<br /></div>