<table><tr><td style="">ngraham added inline comments.
</td><a style="text-decoration: none; padding: 4px 8px; margin: 0 8px 8px; float: right; color: #464C5C; font-weight: bold; border-radius: 3px; background-color: #F7F7F9; background-image: linear-gradient(to bottom,#fff,#f1f0f1); display: inline-block; border: 1px solid rgba(71,87,120,.2);" href="https://phabricator.kde.org/D28154">View Revision</a></tr></table><br /><div><strong>INLINE COMMENTS</strong><div><div style="margin: 6px 0 12px 0;"><div style="border: 1px solid #C7CCD9; border-radius: 3px;"><div style="padding: 0; background: #F7F7F7; border-color: #e3e4e8; border-style: solid; border-width: 0 0 1px 0; margin: 0;"><div style="color: #74777d; background: #eff2f4; padding: 6px 8px; overflow: hidden;"><a style="float: right; text-decoration: none;" href="https://phabricator.kde.org/D28154#inline-165452">View Inline</a><span style="color: #4b4d51; font-weight: bold;">user_manager.desktop:9</span></div>
<div style="font: 11px/15px "Menlo", "Consolas", "Monaco", monospace; white-space: pre-wrap; clear: both; padding: 4px 0; margin: 0;"><div style="padding: 0 8px; margin: 0 4px; background: rgba(151, 234, 151, .6);">X-KDE-Weight=40
</div><div style="padding: 0 8px; margin: 0 4px; background: rgba(151, 234, 151, .6);">X-KDE-System-Settings-Parent-Category=personalization
</div><div style="padding: 0 8px; margin: 0 4px; background: rgba(151, 234, 151, .6);">Name=Users
</div></div></div>
<div style="margin: 8px 0; padding: 0 12px;"><p style="padding: 0; margin: 8px;">You've moved it out of the <span><span class="phui-tag-view phui-tag-type-shade phui-tag-grey phui-tag-shade "><span class="phui-tag-core ">Account details</span></span></span> group. If this is intentional, then we also need to move the KWallet KCM out of that group, or else <span><span class="phui-tag-view phui-tag-type-shade phui-tag-grey phui-tag-shade "><span class="phui-tag-core ">Account details</span></span></span> has only one item and shows the KWallet KCM when clicked on, which is confusing because the second level of navigation is collapsed and the group name doesn't match the KCM name.</p>
<p style="padding: 0; margin: 8px;"><a href="https://phabricator.kde.org/F8249318" style="background-color: #e7e7e7;
border-color: #e7e7e7;
border-radius: 3px;
padding: 0 4px;
font-weight: bold;
color: black;text-decoration: none;">F8249318: Screenshot_20200420_081303.png</a></p>
<p style="padding: 0; margin: 8px;">So move it back into the <span><span class="phui-tag-view phui-tag-type-shade phui-tag-grey phui-tag-shade "><span class="phui-tag-core ">Account Details</span></span></span> group or submit another patch to move KWallet out of the group too.</p></div></div><br /><div style="border: 1px solid #C7CCD9; border-radius: 3px;"><div style="padding: 0; background: #F7F7F7; border-color: #e3e4e8; border-style: solid; border-width: 0 0 1px 0; margin: 0;"><div style="color: #74777d; background: #eff2f4; padding: 6px 8px; overflow: hidden;"><a style="float: right; text-decoration: none;" href="https://phabricator.kde.org/D28154#inline-165453">View Inline</a><span style="color: #4b4d51; font-weight: bold;">user_manager.desktop:11</span></div>
<div style="font: 11px/15px "Menlo", "Consolas", "Monaco", monospace; white-space: pre-wrap; clear: both; padding: 4px 0; margin: 0;"><div style="padding: 0 8px; margin: 0 4px; background: rgba(151, 234, 151, .6);">Name=Users
</div><div style="padding: 0 8px; margin: 0 4px; background: rgba(151, 234, 151, .6);">Comment=
</div></div></div>
<div style="margin: 8px 0; padding: 0 12px;"><p style="padding: 0; margin: 8px;">Needs a comment or else the sidebar tooltip is nonsensical</p></div></div></div></div></div><br /><div><strong>REPOSITORY</strong><div><div>R119 Plasma Desktop</div></div></div><br /><div><strong>REVISION DETAIL</strong><div><a href="https://phabricator.kde.org/D28154">https://phabricator.kde.org/D28154</a></div></div><br /><div><strong>To: </strong>cblack, Plasma, VDG, ngraham<br /><strong>Cc: </strong>iasensio, meven, crossi, The-Feren-OS-Dev, davidedmundson, broulik, filipf, ngraham, nicolasfella, zzag, plasma-devel, Orage, LeGast00n, cblack, jraleigh, zachus, fbampaloukas, ragreen, ZrenBot, himcesjf, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart<br /></div>