<table><tr><td style="">ngraham created this revision.<br />ngraham added reviewers: VDG, Plasma, broulik.<br />Herald added a project: Plasma.<br />Herald added a subscriber: plasma-devel.<br />ngraham requested review of this revision.
</td><a style="text-decoration: none; padding: 4px 8px; margin: 0 8px 8px; float: right; color: #464C5C; font-weight: bold; border-radius: 3px; background-color: #F7F7F9; background-image: linear-gradient(to bottom,#fff,#f1f0f1); display: inline-block; border: 1px solid rgba(71,87,120,.2);" href="https://phabricator.kde.org/D28989">View Revision</a></tr></table><br /><div><strong>REVISION SUMMARY</strong><div><p>Somehow the notification pop-up's positioning has never felt quite right to me. When it's<br />
in a bottom corner, it blocks the view of the latest messages in chat apps, or the text<br />
I'm searching for in Kate. When it's in a top corner, it blocks part of the open app's<br />
toolbar or tab bar that I often use. The best place I've found for is in the top-middle, which doesn't block very many of the thing I'm active using, and its centered position<br />
feels aesthetically pleasing. I've been using this for a bit and quite like it.</p>
<p>However there is ony deficiency: the pop-up is not very wide, so it becomes quite tall<br />
when displaying multi-line messages from chat apps in particular, which makes the notification stack intrude into the middle of the screen where it definitely blocks things you<br />
want to be looking at. This is annoying.</p>
<p>This patch resolves that issue by making the pop-up's size wider and the spacing between<br />
pop-ups smaller when the pop-ups are positioned in the top or bottom middle.</p>
<p>There is no visual change when the notification pop-up is in one of the corners.</p></div></div><br /><div><strong>TEST PLAN</strong><div><p>Centered pop-ups now look like this:<br />
Single pop-up: <a href="https://phabricator.kde.org/F8247020" style="background-color: #e7e7e7;
border-color: #e7e7e7;
border-radius: 3px;
padding: 0 4px;
font-weight: bold;
color: black;text-decoration: none;">F8247020: Screenshot_20200419_110522.png</a><br />
Stack of pop-ups: <a href="https://phabricator.kde.org/F8247025" style="background-color: #e7e7e7;
border-color: #e7e7e7;
border-radius: 3px;
padding: 0 4px;
font-weight: bold;
color: black;text-decoration: none;">F8247025: Screenshot_20200419_112511.png</a></p></div></div><br /><div><strong>REPOSITORY</strong><div><div>R120 Plasma Workspace</div></div></div><br /><div><strong>BRANCH</strong><div><div>wider-notification-popu-when-on-top-or-bottom (branched from master)</div></div></div><br /><div><strong>REVISION DETAIL</strong><div><a href="https://phabricator.kde.org/D28989">https://phabricator.kde.org/D28989</a></div></div><br /><div><strong>AFFECTED FILES</strong><div><div>applets/notifications/package/contents/ui/global/Globals.qml</div></div></div><br /><div><strong>To: </strong>ngraham, VDG, Plasma, broulik<br /><strong>Cc: </strong>ndavis, cblack, plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, jraleigh, zachus, fbampaloukas, ragreen, ZrenBot, ngraham, himcesjf, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart<br /></div>