<table><tr><td style="">dfaure added a comment.
</td><a style="text-decoration: none; padding: 4px 8px; margin: 0 8px 8px; float: right; color: #464C5C; font-weight: bold; border-radius: 3px; background-color: #F7F7F9; background-image: linear-gradient(to bottom,#fff,#f1f0f1); display: inline-block; border: 1px solid rgba(71,87,120,.2);" href="https://phabricator.kde.org/D28383">View Revision</a></tr></table><br /><div><div><p>The unittest in this commit appears to break in CI.</p>

<p><a href="https://build.kde.org/job/Frameworks/view/Platform%20-%20SUSEQt5.12/job/kirigami/job/kf5-qt5%20SUSEQt5.12/417/testReport/junit/projectroot.home.jenkins.workspace.Frameworks.kirigami.kf5-qt5_SUSEQt512/autotests/tst_pagerouter_qml/" class="remarkup-link" target="_blank" rel="noreferrer">https://build.kde.org/job/Frameworks/view/Platform%20-%20SUSEQt5.12/job/kirigami/job/kf5-qt5%20SUSEQt5.12/417/testReport/junit/projectroot.home.jenkins.workspace.Frameworks.kirigami.kf5-qt5_SUSEQt512/autotests/tst_pagerouter_qml/</a></p>

<div class="remarkup-code-block" style="margin: 12px 0;" data-code-lang="text" data-sigil="remarkup-code-block"><pre class="remarkup-code" style="font: 11px/15px "Menlo", "Consolas", "Monaco", monospace; padding: 12px; margin: 0; background: rgba(71, 87, 120, 0.08);">PASS   : Kirigami::PageRouterGeneralTests::test_50_push()
PASS   : Kirigami::PageRouterGeneralTests::test_60_pop()
QWARN  : Kirigami::PageRouterGeneralTests::test_70_bring_to_view() Route "login" with data QVariant(QString, "red") is not on the current stack of routes.
FAIL!  : Kirigami::PageRouterGeneralTests::test_70_bring_to_view() Compared values are not the same
   Actual   (): 0
   Expected (): 1
   Loc: [/home/jenkins/workspace/Frameworks/kirigami/kf5-qt5 SUSEQt5.12/autotests/tst_pagerouter.qml(38)]
FAIL!  : Kirigami::PageRouterGeneralTests::test_80_routeactive() Compared values are not the same
   Actual   (): false
   Expected (): true
   Loc: [/home/jenkins/workspace/Frameworks/kirigami/kf5-qt5 SUSEQt5.12/autotests/tst_pagerouter.qml(45)]
PASS   : Kirigami::PageRouterGeneralTests::test_90_initial_route()</pre></div>

<p>Please investigate and fix.<br />
Thanks!</p></div></div><br /><div><strong>REPOSITORY</strong><div><div>R169 Kirigami</div></div></div><br /><div><strong>REVISION DETAIL</strong><div><a href="https://phabricator.kde.org/D28383">https://phabricator.kde.org/D28383</a></div></div><br /><div><strong>To: </strong>cblack, Kirigami, mart, davidedmundson<br /><strong>Cc: </strong>dfaure, ahiemstra, davidedmundson, plasma-devel, fbampaloukas, GB_2, domson, dkardarakos, ngraham, apol, mart<br /></div>