<table><tr><td style="">davidre edited subscribers, added: davidedmundson; removed: crossi.<br />davidre added a comment.
</td><a style="text-decoration: none; padding: 4px 8px; margin: 0 8px 8px; float: right; color: #464C5C; font-weight: bold; border-radius: 3px; background-color: #F7F7F9; background-image: linear-gradient(to bottom,#fff,#f1f0f1); display: inline-block; border: 1px solid rgba(71,87,120,.2);" href="https://phabricator.kde.org/D28744">View Revision</a></tr></table><br /><div><div><p>Answering general comments first:</p>
<blockquote style="border-left: 3px solid #8C98B8;
color: #6B748C;
font-style: italic;
margin: 4px 0 12px 0;
padding: 8px 12px;
background-color: #F8F9FC;">
<div style="font-style: normal;
padding-bottom: 4px;">In <a href="https://phabricator.kde.org/D28744#647378" style="background-color: #e7e7e7;
border-color: #e7e7e7;
border-radius: 3px;
padding: 0 4px;
font-weight: bold;
color: black;text-decoration: none;">D28744#647378</a>, <a href="https://phabricator.kde.org/p/ngraham/" style="
border-color: #f1f7ff;
color: #19558d;
background-color: #f1f7ff;
border: 1px solid transparent;
border-radius: 3px;
font-weight: bold;
padding: 0 4px;">@ngraham</a> wrote:</div>
<div style="margin: 0;
padding: 0;
border: 0;
color: rgb(107, 116, 140);"><ul class="remarkup-list">
<li class="remarkup-list-item">When a shortcut is to launch an app, and that shortcut's name would be identical to the app name, maybe we should automatically change it to "Launch [app name]. Otherwise you get this following: <a href="https://phabricator.kde.org/F8234080" style="background-color: #e7e7e7;
border-color: #e7e7e7;
border-radius: 3px;
padding: 0 4px;
font-weight: bold;
color: black;text-decoration: none;">F8234080: Screenshot_20200413_094908.png</a></li>
</ul></div>
</blockquote>
<p>I think that's what the old kcm did. It changed the friendly name to "Launch $app" which then would be saved if you changed the shortcut in the old kcm. That's why there is currently a mixture between "$app" and "Launch $app"...<br />
But we can change displayed name here, too.</p>
<blockquote style="border-left: 3px solid #a7b5bf; color: #464c5c; font-style: italic; margin: 4px 0 12px 0; padding: 4px 12px; background-color: #f8f9fc;"><ul class="remarkup-list">
<li class="remarkup-list-item">I'm seeing some duplicate entries here, and some with missing icons that aren't missing in the current version: <a href="https://phabricator.kde.org/F8234212" style="background-color: #e7e7e7;
border-color: #e7e7e7;
border-radius: 3px;
padding: 0 4px;
font-weight: bold;
color: black;text-decoration: none;">F8234212: Screenshot_20200413_114058.png</a></li>
</ul></blockquote>
<p>The KDE Daemon ones are expected. They are different components with different unique identifiers that set the same display name (Probably to force the old kcm to merge them?). What I would like to happen is that we give them each a fitting name and they seperate. They are different modules after all. kcm_touchpad (the one with the touchpad icon) should call itself "Touchpad" for example. <br />
Hmm I don't know about "Power Managment" wasn't their some fallout when d_ed ported shortcuts for that but I may be remembering wrong. Do you have these modules on dbus too or is it an error in the model? Try <tt style="background: #ebebeb; font-size: 13px;">qdbus --literal org.kde.kglobalaccel /kglobalaccel org.kde.KGlobalAccel.allMainComponents</tt> or take a look in qdbusviewer<br />
Interested to hear which ones lost their icon compared to the old one.</p>
<blockquote style="border-left: 3px solid #8C98B8;
color: #6B748C;
font-style: italic;
margin: 4px 0 12px 0;
padding: 8px 12px;
background-color: #F8F9FC;">
<div style="font-style: normal;
padding-bottom: 4px;">In <a href="https://phabricator.kde.org/D28744#647505" style="background-color: #e7e7e7;
border-color: #e7e7e7;
border-radius: 3px;
padding: 0 4px;
font-weight: bold;
color: black;text-decoration: none;">D28744#647505</a>, <a href="https://phabricator.kde.org/p/nicolasfella/" style="
border-color: #f1f7ff;
color: #19558d;
background-color: #f1f7ff;
border: 1px solid transparent;
border-radius: 3px;
font-weight: bold;
padding: 0 4px;">@nicolasfella</a> wrote:</div>
<div style="margin: 0;
padding: 0;
border: 0;
color: rgb(107, 116, 140);"><p>I always get two horizontal scrollbars, no matter the window size:<br />
<a href="https://phabricator.kde.org/F8234349" style="background-color: #e7e7e7;
border-color: #e7e7e7;
border-radius: 3px;
padding: 0 4px;
font-weight: bold;
color: black;text-decoration: none;">F8234349: Screenshot_20200413_212457.png</a></p></div>
</blockquote>
<p>Not sure what's going on here but I had to <br />
ColumnLayout{ height: root.availableHeight - Kirigami.Units.smallSpacing to not get a vertical scrollbar. Probably <tt style="background: #ebebeb; font-size: 13px;">anchors.fill: parent</tt> works better. I will change to that</p>
<blockquote style="border-left: 3px solid #a7b5bf; color: #464c5c; font-style: italic; margin: 4px 0 12px 0; padding: 4px 12px; background-color: #f8f9fc;"><p>The first Choqok shortcut is missing a name, not sure if that's an issue here or in Choqok<br />
<a href="https://phabricator.kde.org/F8234357" style="background-color: #e7e7e7;
border-color: #e7e7e7;
border-radius: 3px;
padding: 0 4px;
font-weight: bold;
color: black;text-decoration: none;">F8234357: Screenshot_20200413_212731.png</a></p></blockquote>
<p>The action doesn't have a name <a href="https://lxr.kde.org/source/extragear/network/choqok/choqok/mainwindow.cpp#0215" class="remarkup-link" target="_blank" rel="noreferrer">https://lxr.kde.org/source/extragear/network/choqok/choqok/mainwindow.cpp#0215</a> . But thanks for the reminder to have a fallback here</p>
<blockquote style="border-left: 3px solid #8C98B8;
color: #6B748C;
font-style: italic;
margin: 4px 0 12px 0;
padding: 8px 12px;
background-color: #F8F9FC;">
<div style="font-style: normal;
padding-bottom: 4px;">In <a href="https://phabricator.kde.org/D28744#647507" style="background-color: #e7e7e7;
border-color: #e7e7e7;
border-radius: 3px;
padding: 0 4px;
font-weight: bold;
color: black;text-decoration: none;">D28744#647507</a>, <a href="https://phabricator.kde.org/p/nicolasfella/" style="
border-color: #f1f7ff;
color: #19558d;
background-color: #f1f7ff;
border: 1px solid transparent;
border-radius: 3px;
font-weight: bold;
padding: 0 4px;">@nicolasfella</a> wrote:</div>
<div style="margin: 0;
padding: 0;
border: 0;
color: rgb(107, 116, 140);"><p>When I open the KCM and type 'Krun' + Enter I find KRunner as expected, but I still need to click on the KRunner item to actually see the shortcuts. When I then type 'Yaku' + Enter Yakuake is shown correctly in the results, but clicking on the entry does not show its shortcuts</p></div>
</blockquote>
<p>And the comment to always have something in the main view from <a href="https://phabricator.kde.org/p/ngraham/" style="
border-color: #f1f7ff;
color: #19558d;
background-color: #f1f7ff;
border: 1px solid transparent;
border-radius: 3px;
font-weight: bold;
padding: 0 4px;">@ngraham</a>. I had some problems with loading and when I update the rootIndex of the DelegateModel that causes the issue you are seeing above and prevented me from having for example the first element selected when the kcm is openend. I will look into how I can make it better.</p></div></div><br /><div><strong>INLINE COMMENTS</strong><div><div style="margin: 6px 0 12px 0;"><div style="border: 1px solid #C7CCD9; border-radius: 3px;"><div style="padding: 0; background: #F7F7F7; border-color: #e3e4e8; border-style: solid; border-width: 0 0 1px 0; margin: 0;"><div style="color: #74777d; background: #eff2f4; padding: 6px 8px; overflow: hidden;"><a style="float: right; text-decoration: none;" href="https://phabricator.kde.org/D28744#inline-164209">View Inline</a><span style="color: #4b4d51; font-weight: bold;">kcm_keys.desktop:2</span></div>
<div style="font: 11px/15px "Menlo", "Consolas", "Monaco", monospace; white-space: pre-wrap; clear: both; padding: 4px 0; margin: 0;"><div style="padding: 0 8px; margin: 0 4px; ">[Desktop Entry]
</div><div style="padding: 0 8px; margin: 0 4px; background: rgba(251, 175, 175, .7);">Exec=kcmshell5 keys
</div><div style="padding: 0 8px; margin: 0 4px; background: rgba(151, 234, 151, .6);">Exec=kcmshell5 k<span class="bright">cm_k</span>eys
</div><div style="padding: 0 8px; margin: 0 4px; ">Icon=preferences-desktop-keyboard-shortcut
</div></div></div>
<div style="margin: 8px 0; padding: 0 12px;"><p style="padding: 0; margin: 8px;">From reading <a href="https://api.kde.org/frameworks/kdeclarative/html/classKQuickAddons_1_1ConfigModule.html" class="remarkup-link" target="_blank" rel="noreferrer">https://api.kde.org/frameworks/kdeclarative/html/classKQuickAddons_1_1ConfigModule.html</a> I thought it had to be kcm_$(something) but I'm not sure now.</p></div></div></div></div></div><br /><div><strong>REPOSITORY</strong><div><div>R119 Plasma Desktop</div></div></div><br /><div><strong>REVISION DETAIL</strong><div><a href="https://phabricator.kde.org/D28744">https://phabricator.kde.org/D28744</a></div></div><br /><div><strong>To: </strong>davidre, VDG, Plasma<br /><strong>Cc: </strong>davidedmundson, nicolasfella, ngraham, iasensio, plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, jraleigh, zachus, fbampaloukas, ragreen, ZrenBot, himcesjf, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart, crossi<br /></div>