<table><tr><td style="">sitter added inline comments.
</td><a style="text-decoration: none; padding: 4px 8px; margin: 0 8px 8px; float: right; color: #464C5C; font-weight: bold; border-radius: 3px; background-color: #F7F7F9; background-image: linear-gradient(to bottom,#fff,#f1f0f1); display: inline-block; border: 1px solid rgba(71,87,120,.2);" href="https://phabricator.kde.org/D28192">View Revision</a></tr></table><br /><div><strong>INLINE COMMENTS</strong><div><div style="margin: 6px 0 12px 0;"><div style="border: 1px solid #C7CCD9; border-radius: 3px;"><div style="padding: 0; background: #F7F7F7; border-color: #e3e4e8; border-style: solid; border-width: 0 0 1px 0; margin: 0;"><div style="color: #74777d; background: #eff2f4; padding: 6px 8px; overflow: hidden;"><a style="float: right; text-decoration: none;" href="https://phabricator.kde.org/D28192#inline-161078">View Inline</a><span style="color: #4b4d51; font-weight: bold;">alex</span> wrote in <span style="color: #4b4d51; font-weight: bold;">dictionaryrunner.cpp:90</span></div>
<div style="margin: 8px 0; padding: 0 12px; color: #74777D;"><p style="padding: 0; margin: 8px;">The current behavior is that KRunner closes when a match is selected.<br />
But if you set the data, for instance:<br />
<tt style="background: #ebebeb; font-size: 13px;">match.setData(QStringLiteral("Hello There!"));</tt><br />
The text <tt style="background: #ebebeb; font-size: 13px;">Hello There!</tt> will show up in KRunner (like in the converter runner).<br />
The run method won't be called, because the match type is set to InformationalMatch.</p>
<p style="padding: 0; margin: 8px;">So the runner would benefit from setData, or am I missing something?</p></div></div>
<div style="margin: 8px 0; padding: 0 12px;"><p style="padding: 0; margin: 8px;">Entirely possible, <a href="https://phabricator.kde.org/p/broulik/" style="
border-color: #f1f7ff;
color: #19558d;
background-color: #f1f7ff;
border: 1px solid transparent;
border-radius: 3px;
font-weight: bold;
padding: 0 4px;">@broulik</a> knows way more about the UI code. If data is used in the UI then that would run counter to its purpose though.</p>
<p style="padding: 0; margin: 8px;"><a href="https://api.kde.org/frameworks/krunner/html/classPlasma_1_1QueryMatch.html#aad806b18a5fbec942f1258f6b4436cd8" class="remarkup-link" target="_blank" rel="noreferrer">https://api.kde.org/frameworks/krunner/html/classPlasma_1_1QueryMatch.html#aad806b18a5fbec942f1258f6b4436cd8</a></p>
<div class="remarkup-code-block" style="margin: 12px 0;" data-code-lang="text" data-sigil="remarkup-code-block"><pre class="remarkup-code" style="font: 11px/15px "Menlo", "Consolas", "Monaco", monospace; padding: 12px; margin: 0; background: rgba(71, 87, 120, 0.08);">Sets data to be used internally by the associated AbstractRunner.</pre></div>
<p style="padding: 0; margin: 8px;">putting a string into the UI is not internal anymore ^^</p></div></div><br /><div style="border: 1px solid #C7CCD9; border-radius: 3px;"><div style="padding: 0; background: #F7F7F7; border-color: #e3e4e8; border-style: solid; border-width: 0 0 1px 0; margin: 0;"><div style="color: #74777d; background: #eff2f4; padding: 6px 8px; overflow: hidden;"><a style="float: right; text-decoration: none;" href="https://phabricator.kde.org/D28192#inline-161417">View Inline</a><span style="color: #4b4d51; font-weight: bold;">alex</span> wrote in <span style="color: #4b4d51; font-weight: bold;">dictionaryrunner_config.cpp:29</span></div>
<div style="margin: 8px 0; padding: 0 12px; color: #74777D;"><p style="padding: 0; margin: 8px;">The baseclass implementations for these methods handle the KConfigDialogManager widgets and the corresponding changed signals.<br />
I removed them, because the KConfigDialogManager class is not used in this kcm and the signals are manually handled.</p></div></div>
<div style="margin: 8px 0; padding: 0 12px;"><p style="padding: 0; margin: 8px;">That's an implementation detail though, is it not? From the outside we shouldn't make assumption about what the implementation does unless the documentation says what we can assume.<br />
Today the baseclass may be useless, in 10 years it may not be.</p>
<p style="padding: 0; margin: 8px;">Long-winded way of saying that I would leave the base class calls in. If nothing else it's at least better form in terms of API contracts.</p></div></div></div></div></div><br /><div><strong>REPOSITORY</strong><div><div>R114 Plasma Addons</div></div></div><br /><div><strong>REVISION DETAIL</strong><div><a href="https://phabricator.kde.org/D28192">https://phabricator.kde.org/D28192</a></div></div><br /><div><strong>To: </strong>alex, broulik, ngraham, sitter, mlaurent<br /><strong>Cc: </strong>plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, jraleigh, zachus, fbampaloukas, GB_2, ragreen, ZrenBot, ngraham, himcesjf, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart<br /></div>