<table><tr><td style="">broulik added inline comments.
</td><a style="text-decoration: none; padding: 4px 8px; margin: 0 8px 8px; float: right; color: #464C5C; font-weight: bold; border-radius: 3px; background-color: #F7F7F9; background-image: linear-gradient(to bottom,#fff,#f1f0f1); display: inline-block; border: 1px solid rgba(71,87,120,.2);" href="https://phabricator.kde.org/D28517">View Revision</a></tr></table><br /><div><strong>INLINE COMMENTS</strong><div><div style="margin: 6px 0 12px 0;"><div style="border: 1px solid #C7CCD9; border-radius: 3px;"><div style="padding: 0; background: #F7F7F7; border-color: #e3e4e8; border-style: solid; border-width: 0 0 1px 0; margin: 0;"><div style="color: #74777d; background: #eff2f4; padding: 6px 8px; overflow: hidden;"><a style="float: right; text-decoration: none;" href="https://phabricator.kde.org/D28517#inline-162354">View Inline</a><span style="color: #4b4d51; font-weight: bold;">screencaststream.cpp:372</span></div>
<div style="font: 11px/15px "Menlo", "Consolas", "Monaco", monospace; white-space: pre-wrap; clear: both; padding: 4px 0; margin: 0;"><div style="padding: 0 8px; margin: 0 4px; background: rgba(151, 234, 151, .6);">    <span style="color: #aa4000">const</span> <span style="color: #aa4000">auto</span> <span class="n">emitFailureNotification</span> <span style="color: #aa2211">=</span> <span class="p">[](</span><span style="color: #aa4000">const</span> <span class="n">QString</span> <span style="color: #aa2211">&</span><span class="n">body</span><span class="p">)</span> <span class="p">{</span>
</div><div style="padding: 0 8px; margin: 0 4px; background: rgba(151, 234, 151, .6);">        <span class="n">KNotification</span> <span style="color: #aa2211">*</span><span class="n">notification</span> <span style="color: #aa2211">=</span> <span style="color: #aa4000">new</span> <span class="n">KNotification</span><span class="p">(</span><span class="n">QStringLiteral</span><span class="p">(</span><span style="color: #766510">"notification"</span><span class="p">),</span> <span class="n">KNotification</span><span style="color: #aa2211">::</span><span class="n">CloseOnTimeout</span> <span style="color: #aa2211">|</span> <span class="n">KNotification</span><span style="color: #aa2211">::</span><span class="n">DefaultEvent</span><span class="p">);</span>
</div><div style="padding: 0 8px; margin: 0 4px; background: rgba(151, 234, 151, .6);">        <span class="n">notification</span><span style="color: #aa2211">-></span><span class="n">setTitle</span><span class="p">(</span><span class="n">i18n</span><span class="p">(</span><span style="color: #766510">"Failed to start screencasting"</span><span class="p">));</span>
</div></div></div>
<div style="margin: 8px 0; padding: 0 12px;"><p style="padding: 0; margin: 8px;">This should be its own event, not abusing the "notification" one</p></div></div><br /><div style="border: 1px solid #C7CCD9; border-radius: 3px;"><div style="padding: 0; background: #F7F7F7; border-color: #e3e4e8; border-style: solid; border-width: 0 0 1px 0; margin: 0;"><div style="color: #74777d; background: #eff2f4; padding: 6px 8px; overflow: hidden;"><a style="float: right; text-decoration: none;" href="https://phabricator.kde.org/D28517#inline-162356">View Inline</a><span style="color: #4b4d51; font-weight: bold;">screencaststream.cpp:375</span></div>
<div style="font: 11px/15px "Menlo", "Consolas", "Monaco", monospace; white-space: pre-wrap; clear: both; padding: 4px 0; margin: 0;"><div style="padding: 0 8px; margin: 0 4px; background: rgba(151, 234, 151, .6);">        <span class="n">notification</span><span style="color: #aa2211">-></span><span class="n">setText</span><span class="p">(</span><span class="n">i18nc</span><span class="p">(</span><span style="color: #766510">"Introduces an error message"</span><span class="p">,</span> <span style="color: #766510">"Error: %1"</span><span class="p">,</span> <span class="n">body</span><span class="p">));</span>
</div><div style="padding: 0 8px; margin: 0 4px; background: rgba(151, 234, 151, .6);">        <span class="n">notification</span><span style="color: #aa2211">-></span><span class="n">setIconName</span><span class="p">(</span><span class="n">QStringLiteral</span><span class="p">(</span><span style="color: #766510">"data-error"</span><span class="p">));</span>
</div><div style="padding: 0 8px; margin: 0 4px; background: rgba(151, 234, 151, .6);">        <span class="n">notification</span><span style="color: #aa2211">-></span><span class="n">setUrgency</span><span class="p">(</span><span class="n">KNotification</span><span style="color: #aa2211">::</span><span class="n">HighUrgency</span><span class="p">);</span>
</div></div></div>
<div style="margin: 8px 0; padding: 0 12px;"><p style="padding: 0; margin: 8px;">You probably want <tt style="background: #ebebeb; font-size: 13px;">dialog-error</tt></p></div></div><br /><div style="border: 1px solid #C7CCD9; border-radius: 3px;"><div style="padding: 0; background: #F7F7F7; border-color: #e3e4e8; border-style: solid; border-width: 0 0 1px 0; margin: 0;"><div style="color: #74777d; background: #eff2f4; padding: 6px 8px; overflow: hidden;"><a style="float: right; text-decoration: none;" href="https://phabricator.kde.org/D28517#inline-162357">View Inline</a><span style="color: #4b4d51; font-weight: bold;">screencaststream.cpp:376</span></div>
<div style="font: 11px/15px "Menlo", "Consolas", "Monaco", monospace; white-space: pre-wrap; clear: both; padding: 4px 0; margin: 0;"><div style="padding: 0 8px; margin: 0 4px; background: rgba(151, 234, 151, .6);">        <span class="n">notification</span><span style="color: #aa2211">-></span><span class="n">setIconName</span><span class="p">(</span><span class="n">QStringLiteral</span><span class="p">(</span><span style="color: #766510">"data-error"</span><span class="p">));</span>
</div><div style="padding: 0 8px; margin: 0 4px; background: rgba(151, 234, 151, .6);">        <span class="n">notification</span><span style="color: #aa2211">-></span><span class="n">setUrgency</span><span class="p">(</span><span class="n">KNotification</span><span style="color: #aa2211">::</span><span class="n">HighUrgency</span><span class="p">);</span>
</div><div style="padding: 0 8px; margin: 0 4px; background: rgba(151, 234, 151, .6);">        <span class="n">notification</span><span style="color: #aa2211">-></span><span class="n">sendEvent</span><span class="p">();</span>
</div></div></div>
<div style="margin: 8px 0; padding: 0 12px;"><p style="padding: 0; margin: 8px;">You sure this is needed to be high?</p></div></div><br /><div style="border: 1px solid #C7CCD9; border-radius: 3px;"><div style="padding: 0; background: #F7F7F7; border-color: #e3e4e8; border-style: solid; border-width: 0 0 1px 0; margin: 0;"><div style="color: #74777d; background: #eff2f4; padding: 6px 8px; overflow: hidden;"><a style="float: right; text-decoration: none;" href="https://phabricator.kde.org/D28517#inline-162329">View Inline</a><span style="color: #4b4d51; font-weight: bold;">ngraham</span> wrote in <span style="color: #4b4d51; font-weight: bold;">screencaststream.cpp:374</span></div>
<div style="margin: 8px 0; padding: 0 12px; color: #74777D;"><p style="padding: 0; margin: 8px;"><tt style="background: #ebebeb; font-size: 13px;">.arg</tt> is unnecessary and in various cases can cause i18n() errors; just do it inline: <tt style="background: #ebebeb; font-size: 13px;">notification->setText(i18n("Error: %1", body));</tt></p>

<p style="padding: 0; margin: 8px;">Also for short strings like this, it's nice to add some context for translators.</p></div></div>
<div style="margin: 8px 0; padding: 0 12px;"><p style="padding: 0; margin: 8px;">Is the "Error" even needed?</p></div></div></div></div></div><br /><div><strong>REPOSITORY</strong><div><div>R838 Flatpak Support: KDE Portal for XDG Desktop</div></div></div><br /><div><strong>REVISION DETAIL</strong><div><a href="https://phabricator.kde.org/D28517">https://phabricator.kde.org/D28517</a></div></div><br /><div><strong>To: </strong>cblack, Plasma, VDG, ngraham, apol<br /><strong>Cc: </strong>broulik, apol, ngraham, plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, jraleigh, zachus, fbampaloukas, GB_2, ragreen, ZrenBot, himcesjf, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, ahiemstra, mart<br /></div>