<table><tr><td style="">ngraham added a comment.
</td><a style="text-decoration: none; padding: 4px 8px; margin: 0 8px 8px; float: right; color: #464C5C; font-weight: bold; border-radius: 3px; background-color: #F7F7F9; background-image: linear-gradient(to bottom,#fff,#f1f0f1); display: inline-block; border: 1px solid rgba(71,87,120,.2);" href="https://phabricator.kde.org/D28154">View Revision</a></tr></table><br /><div><div><p>Regarding groups, obviously if it isn't a part of this patch, then it isn't a part of this patch. I don't think it makes sense to WONTFIX the idea of it though. I not-infrequenrly wish for a GUI method of changing my user's group membership. Yes, I know how to do it using the CLI, but I find it easier and faster to use a GUI most of the time.</p>
<p>Regarding removing the auto-login checkbox, I understand that this isn't the most technically appropriate place for it and it's already available somewhere else. I won't block the patch on this, but I do think it's nice to have it here too. This is IMO a pretty logical place for people to look for the setting.</p>
<hr class="remarkup-hr" />
<p>anywaybacktothepatchitself...</p>
<p>Thanks for using a more conventional list style. I'm still not super happy about the list item for the current user being bigger though. It just feels kinda weird IMO: <a href="https://phabricator.kde.org/F8196116" style="background-color: #e7e7e7;
border-color: #e7e7e7;
border-radius: 3px;
padding: 0 4px;
font-weight: bold;
color: black;text-decoration: none;">F8196116: Screenshot_20200323_214428.png</a></p>
<p>The emergingstandard we're moving towards is making the text bold fur the current/default item in a list, and I think this qualifies.</p>
<p>Also as you can see, the list item for my account doesn't display the user picture that's visible on the account page for some reason.</p>
<p>I also noticed that the width threshold for switching to two-column view is so close to the minimum size of System Settings' window that some weird effects are produced: <a href="https://phabricator.kde.org/F8196118" style="background-color: #e7e7e7;
border-color: #e7e7e7;
border-radius: 3px;
padding: 0 4px;
font-weight: bold;
color: black;text-decoration: none;">F8196118: vokoscreenNG-2020-03-23_21-39-08.webm</a></p>
<p>The threshold should probably be reduced a bit so that you always see the two-column view in the System Settings app itself when the app is using its default/minimum window size. Same for when opened in KCMShell, or else it opens really small and my name gets cut off: <a href="https://phabricator.kde.org/F8196114" style="background-color: #e7e7e7;
border-color: #e7e7e7;
border-radius: 3px;
padding: 0 4px;
font-weight: bold;
color: black;text-decoration: none;">F8196114: Screenshot_20200323_214240.png</a></p>
<p>Various other KCMs set a more appropriate default size in KCMShell by setting their own <tt style="background: #ebebeb; font-size: 13px;">implicitWidth</tt> and <tt style="background: #ebebeb; font-size: 13px;">implicitHeight</tt> values on the root item.</p>
<p>Oh and check this out: <a href="https://phabricator.kde.org/F8196119" style="background-color: #e7e7e7;
border-color: #e7e7e7;
border-radius: 3px;
padding: 0 4px;
font-weight: bold;
color: black;text-decoration: none;">F8196119: vokoscreenNG-2020-03-23_21-48-55.webm</a></p>
<p>One last UI regression I noticed: you can no longer set the account type during account creation; you now need to create the account, then select it, and change the type there. You should still be able to choose the type during account creation</p></div></div><br /><div><strong>INLINE COMMENTS</strong><div><div style="margin: 6px 0 12px 0;"><div style="border: 1px solid #C7CCD9; border-radius: 3px;"><div style="padding: 0; background: #F7F7F7; border-color: #e3e4e8; border-style: solid; border-width: 0 0 1px 0; margin: 0;"><div style="color: #74777d; background: #eff2f4; padding: 6px 8px; overflow: hidden;"><a style="float: right; text-decoration: none;" href="https://phabricator.kde.org/D28154#inline-160509">View Inline</a><span style="color: #4b4d51; font-weight: bold;">metadata.desktop:4</span></div>
<div style="font: 11px/15px "Menlo", "Consolas", "Monaco", monospace; white-space: pre-wrap; clear: both; padding: 4px 0; margin: 0;"><div style="padding: 0 8px; margin: 0 4px; background: rgba(151, 234, 151, .6);">Comment=Manage users
</div><div style="padding: 0 8px; margin: 0 4px; background: rgba(151, 234, 151, .6);">Icon=system-users
</div><div style="padding: 0 8px; margin: 0 4px; background: rgba(151, 234, 151, .6);">Keywords=
</div></div></div>
<div style="margin: 8px 0; padding: 0 12px;"><p style="padding: 0; margin: 8px;">Don't change the icon. The old was appropriately using <tt style="background: #ebebeb; font-size: 13px;">preferences-system-users</tt></p></div></div><br /><div style="border: 1px solid #C7CCD9; border-radius: 3px;"><div style="padding: 0; background: #F7F7F7; border-color: #e3e4e8; border-style: solid; border-width: 0 0 1px 0; margin: 0;"><div style="color: #74777d; background: #eff2f4; padding: 6px 8px; overflow: hidden;"><a style="float: right; text-decoration: none;" href="https://phabricator.kde.org/D28154#inline-160510">View Inline</a><span style="color: #4b4d51; font-weight: bold;">user_manager.desktop:3</span></div>
<div style="font: 11px/15px "Menlo", "Consolas", "Monaco", monospace; white-space: pre-wrap; clear: both; padding: 4px 0; margin: 0;"><div style="padding: 0 8px; margin: 0 4px; background: rgba(151, 234, 151, .6);">Exec=kcmshell5 user_manager
</div><div style="padding: 0 8px; margin: 0 4px; background: rgba(151, 234, 151, .6);">Icon=system-users
</div><div style="padding: 0 8px; margin: 0 4px; background: rgba(151, 234, 151, .6);">Type=Service
</div></div></div>
<div style="margin: 8px 0; padding: 0 12px;"><p style="padding: 0; margin: 8px;">ditto</p></div></div></div></div></div><br /><div><strong>REPOSITORY</strong><div><div>R119 Plasma Desktop</div></div></div><br /><div><strong>REVISION DETAIL</strong><div><a href="https://phabricator.kde.org/D28154">https://phabricator.kde.org/D28154</a></div></div><br /><div><strong>To: </strong>cblack, Plasma, VDG, ngraham<br /><strong>Cc: </strong>crossi, The-Feren-OS-Dev, davidedmundson, broulik, filipf, ngraham, nicolasfella, zzag, plasma-devel, Orage, LeGast00n, cblack, jraleigh, zachus, fbampaloukas, GB_2, ragreen, ZrenBot, himcesjf, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart<br /></div>