<table><tr><td style="">mart added inline comments.
</td><a style="text-decoration: none; padding: 4px 8px; margin: 0 8px 8px; float: right; color: #464C5C; font-weight: bold; border-radius: 3px; background-color: #F7F7F9; background-image: linear-gradient(to bottom,#fff,#f1f0f1); display: inline-block; border: 1px solid rgba(71,87,120,.2);" href="https://phabricator.kde.org/D28194">View Revision</a></tr></table><br /><div><strong>INLINE COMMENTS</strong><div><div style="margin: 6px 0 12px 0;"><div style="border: 1px solid #C7CCD9; border-radius: 3px;"><div style="padding: 0; background: #F7F7F7; border-color: #e3e4e8; border-style: solid; border-width: 0 0 1px 0; margin: 0;"><div style="color: #74777d; background: #eff2f4; padding: 6px 8px; overflow: hidden;"><a style="float: right; text-decoration: none;" href="https://phabricator.kde.org/D28194#inline-160360">View Inline</a><span style="color: #4b4d51; font-weight: bold;">kquickstyleitem.cpp:218</span></div>
<div style="font: 11px/15px "Menlo", "Consolas", "Monaco", monospace; white-space: pre-wrap; clear: both; padding: 4px 0; margin: 0;"><div style="padding: 0 8px; margin: 0 4px; ">            <span class="n">opt</span><span style="color: #aa2211">-></span><span class="n">icon</span> <span style="color: #aa2211">=</span> <span class="n">QIcon</span><span class="p">(</span><span class="n">icon</span><span class="p">.</span><span class="n">value</span><span style="color: #aa2211"><</span><span class="n">QUrl</span><span style="color: #aa2211">></span><span class="p">().</span><span class="n">toLocalFile</span><span class="p">());</span>
</div><div style="padding: 0 8px; margin: 0 4px; background: rgba(151, 234, 151, .6);">        <span class="p">}</span> <span style="color: #aa4000">else</span> <span style="color: #aa4000">if</span> <span class="p">(</span><span class="n">icon</span><span class="p">.</span><span class="n">canConvert</span><span style="color: #aa2211"><</span><span class="n">QUrl</span><span style="color: #aa2211">></span><span class="p">()</span> <span style="color: #aa2211">&&</span> <span class="n">icon</span><span class="p">.</span><span class="n">value</span><span style="color: #aa2211"><</span><span class="n">QUrl</span><span style="color: #aa2211">></span><span class="p">().</span><span class="n">scheme</span><span class="p">()</span> <span style="color: #aa2211">==</span> <span class="n">QLatin1String</span><span class="p">(</span><span style="color: #766510">"qrc"</span><span class="p">))</span> <span class="p">{</span>
</div><div style="padding: 0 8px; margin: 0 4px; background: rgba(151, 234, 151, .6);">            <span style="color: #aa4000">const</span> <span class="n">QString</span> <span class="n">iconUrl</span> <span style="color: #aa2211">=</span> <span class="n">icon</span><span class="p">.</span><span class="n">value</span><span style="color: #aa2211"><</span><span class="n">QString</span><span style="color: #aa2211">></span><span class="p">().</span><span class="n">mid</span><span class="p">(</span><span style="color: #601200">3</span><span class="p">);</span>
</div></div></div>
<div style="margin: 8px 0; padding: 0 12px;"><p style="padding: 0; margin: 8px;">should it also catch the ":/foo" case?</p></div></div></div></div></div><br /><div><strong>REPOSITORY</strong><div><div>R858 Qt Quick Controls 2: Desktop Style</div></div></div><br /><div><strong>REVISION DETAIL</strong><div><a href="https://phabricator.kde.org/D28194">https://phabricator.kde.org/D28194</a></div></div><br /><div><strong>To: </strong>nicolasfella, Plasma, mart<br /><strong>Cc: </strong>apol, plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, jraleigh, zachus, fbampaloukas, GB_2, ragreen, ZrenBot, ngraham, himcesjf, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, ahiemstra, mart<br /></div>