<table><tr><td style="">hpereiradacosta added a comment.
</td><a style="text-decoration: none; padding: 4px 8px; margin: 0 8px 8px; float: right; color: #464C5C; font-weight: bold; border-radius: 3px; background-color: #F7F7F9; background-image: linear-gradient(to bottom,#fff,#f1f0f1); display: inline-block; border: 1px solid rgba(71,87,120,.2);" href="https://phabricator.kde.org/D27669">View Revision</a></tr></table><br /><div><div><p>Hi Carlston, <br />
Thanks for the updated patch and screenshot. <br />
First I agree that the new (latest) checks on whether the toolbar palette was changed or not are much more elegant and just as efficient as the previous implementation.<br />
Second, some more comments below.</p></div></div><br /><div><strong>INLINE COMMENTS</strong><div><div style="margin: 6px 0 12px 0;"><div style="border: 1px solid #C7CCD9; border-radius: 3px;"><div style="padding: 0; background: #F7F7F7; border-color: #e3e4e8; border-style: solid; border-width: 0 0 1px 0; margin: 0;"><div style="color: #74777d; background: #eff2f4; padding: 6px 8px; overflow: hidden;"><a style="float: right; text-decoration: none;" href="https://phabricator.kde.org/D27669#inline-159769">View Inline</a><span style="color: #4b4d51; font-weight: bold;">cblack</span> wrote in <span style="color: #4b4d51; font-weight: bold;">breeze.h:104</span></div>
<div style="margin: 8px 0; padding: 0 12px; color: #74777D;"><p style="padding: 0; margin: 8px;">With: <a href="https://phabricator.kde.org/F8185479" style="background-color: #e7e7e7;
border-color: #e7e7e7;
border-radius: 3px;
padding: 0 4px;
font-weight: bold;
color: black;text-decoration: none;">F8185479: image.png</a><br />
Without: <a href="https://phabricator.kde.org/F8185480" style="background-color: #e7e7e7;
border-color: #e7e7e7;
border-radius: 3px;
padding: 0 4px;
font-weight: bold;
color: black;text-decoration: none;">F8185480: image.png</a></p></div></div>
<div style="margin: 8px 0; padding: 0 12px;"><p style="padding: 0; margin: 8px;">Hi,<br />
thanks for posting the screenshots. If I understand right this is really an issue with the bottom margin only, and in particular with respect to the separator. In that case I agree this is part of this patch. <br />
I don't think the solution is the right one though. First, changing the metric will also affect widget rendering when</p>
<ul class="remarkup-list">
<li class="remarkup-list-item">the effect is disabled (and I don't think it should in that case)</li>
<li class="remarkup-list-item">when there is no separator line (and IMO I don't think the extra margin is needed in that case either).</li>
<li class="remarkup-list-item">when toolbars are located elsewhere (on the sides of the main window for instance).</li>
</ul>
<p style="padding: 0; margin: 8px;">Second, it affects all sides, whereas only the bottom one needs changed. <br />
i would rather change the "contentsmargin" of the toolbars when necessary, while leaving the metrics unchanged. This could be done whenever you check that a given toolbar is in the toolarea.</p>
<p style="padding: 0; margin: 8px;">If you insist on changing the margins on all toolbars, all sides, disregarding their location and disregarding whether the effect is enabled or not, then this is a change orthogonal (and of much broader scope) to this patch and must go to a different commit.</p></div></div><br /><div style="border: 1px solid #C7CCD9; border-radius: 3px;"><div style="padding: 0; background: #F7F7F7; border-color: #e3e4e8; border-style: solid; border-width: 0 0 1px 0; margin: 0;"><div style="color: #74777d; background: #eff2f4; padding: 6px 8px; overflow: hidden;"><a style="float: right; text-decoration: none;" href="https://phabricator.kde.org/D27669#inline-160174">View Inline</a><span style="color: #4b4d51; font-weight: bold;">breezetoolsareamanager.cpp:133</span></div>
<div style="font: 11px/15px "Menlo", "Consolas", "Monaco", monospace; white-space: pre-wrap; clear: both; padding: 4px 0; margin: 0;"><div style="padding: 0 8px; margin: 0 4px; background: rgba(151, 234, 151, .6);"> <span class="n">window</span><span style="color: #aa2211">-></span><span class="n">setContentsMargins</span><span class="p">(</span><span style="color: #601200">0</span><span class="p">,</span><span style="color: #601200">1</span><span class="p">,</span><span style="color: #601200">0</span><span class="p">,</span><span style="color: #601200">0</span><span class="p">);</span>
</div><div style="padding: 0 8px; margin: 0 4px; background: rgba(151, 234, 151, .6);"> <span class="p">}</span>
</div><div style="padding: 0 8px; margin: 0 4px; background: rgba(151, 234, 151, .6);"> <span class="p">});</span>
</div></div></div>
<div style="margin: 8px 0; padding: 0 12px;"><p style="padding: 0; margin: 8px;">Did you check that this chunk of code (changing the contents margins of the QMainWindow) has any effect ? I had my doubt so I changed the margin to 100 instead of 1, added a printout to make sure that this line of code is called, then ran dolphin and <br />
1/ the code is indeed called<br />
2/ it changes nothing, on dolphin, okular, ...<br />
if you can confirm, then just drop it.</p>
<p style="padding: 0; margin: 8px;">(in fact, I don't understand the login in the first place: why would you need to add one pixel on top of everything in the QMainWindow ?)</p></div></div></div></div></div><br /><div><strong>REPOSITORY</strong><div><div>R31 Breeze</div></div></div><br /><div><strong>REVISION DETAIL</strong><div><a href="https://phabricator.kde.org/D27669">https://phabricator.kde.org/D27669</a></div></div><br /><div><strong>To: </strong>cblack, Plasma, Breeze, VDG<br /><strong>Cc: </strong>IlyaBizyaev, davidre, davidedmundson, hpereiradacosta, ngraham, manueljlin, niccolove, ndavis, plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, jraleigh, zachus, fbampaloukas, GB_2, ragreen, ZrenBot, himcesjf, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart<br /></div>