<table><tr><td style="">ngraham added subscribers: nicolasfella, ngraham.<br />ngraham requested changes to this revision.<br />ngraham added a comment.<br />This revision now requires changes to proceed.
</td><a style="text-decoration: none; padding: 4px 8px; margin: 0 8px 8px; float: right; color: #464C5C; font-weight: bold; border-radius: 3px; background-color: #F7F7F9; background-image: linear-gradient(to bottom,#fff,#f1f0f1); display: inline-block; border: 1px solid rgba(71,87,120,.2);" href="https://phabricator.kde.org/D28154">View Revision</a></tr></table><br /><div><div><p>Nice, this KCM was in desperate need of a rewrite. I've got some concerns though:</p>
<p>Since the new KCM's name (<tt style="background: #ebebeb; font-size: 13px;">kcm_user</tt>) does natch the name of the old one (<tt style="background: #ebebeb; font-size: 13px;">user_manager</tt>) this will require a change in System Settings to actually make it appear. Also for some reason it does not show up to <tt style="background: #ebebeb; font-size: 13px;">kcmshell</tt> list:</p>
<div class="remarkup-code-block" style="margin: 12px 0;" data-code-lang="text" data-sigil="remarkup-code-block"><pre class="remarkup-code" style="font: 11px/15px "Menlo", "Consolas", "Monaco", monospace; padding: 12px; margin: 0; background: rgba(71, 87, 120, 0.08);">kcmshell5 --list | grep -i user
kcm_feedback - Configure user feedback settings
kcm_fonts - Configure user interface fonts
solid-actions - Manage actions available to the user when connecting new devices
user_manager - Add, remove or edit system users
useragent - Configure the User Agent exposed by the HTTP kioslave</pre></div>
<p>However running <tt style="background: #ebebeb; font-size: 13px;">kcmshell5 kcm_user</tt> works.</p>
<p>As for the UI, I'm not a fan of the floating cards list that doesn't look like a list or have correct shadows on the sides and uses gigantic cards with mostly whitespace. I just don't think this looks good at all: <a href="https://phabricator.kde.org/F8186571" style="background-color: #e7e7e7;
border-color: #e7e7e7;
border-radius: 3px;
padding: 0 4px;
font-weight: bold;
color: black;text-decoration: none;">F8186571: Screenshot_20200320_110035.png</a></p>
<p>This should use a more conventional UI with a framed list view that has defined borders and a background. If that list has cards in it, they need proper margins so that their shadows don't get cut off. But I don't really think cards make sense here. These are not rich delegates; they're fairly conventional list items with an icon and some labels, that's it. I don't think there's any problem with the list in the current KCM.</p>
<p>Also there are various feature regressions:</p>
<ul class="remarkup-list">
<li class="remarkup-list-item">You can no longer select images from the gallery for your user avatar</li>
<li class="remarkup-list-item">You can no longer set up auto-login here</li>
</ul>
<p>And some other UI issues:</p>
<ul class="remarkup-list">
<li class="remarkup-list-item">The text field for specifying the full name is no longer labeled so it's no longer clear what that text field is used for if it's empty or set to a weird value</li>
<li class="remarkup-list-item">The avatar no longer has a buttonlike appearance so it's no longer visually obvious that you can click on it to do things with it</li>
<li class="remarkup-list-item">When you click on the avatar to show a menu, you can't dismiss that menu by clicking in empty areas of the page or on the avatar again</li>
<li class="remarkup-list-item">That menu appears right under your cursor instead of anchored to the bottom of the button that spawned it, like other menus behave</li>
<li class="remarkup-list-item">When the window is large enough to show both the users list and the user details view, the multi-page KCM navigation bar doesn't disappear, even though it's useless and clicking on the various parts of it has no effect</li>
<li class="remarkup-list-item">The list item corresponding to the currently viewed user is not always highlighted</li>
</ul>
<p>Also, were we going to add a UI to modify a user's group membership here? I seem to recall seeing that on a rough early version of <a href="https://phabricator.kde.org/p/nicolasfella/" style="
border-color: #f1f7ff;
color: #19558d;
background-color: #f1f7ff;
border: 1px solid transparent;
border-radius: 3px;
font-weight: bold;
padding: 0 4px;">@nicolasfella</a>'s version. That's the most urgently needed feature.</p></div></div><br /><div><strong>REPOSITORY</strong><div><div>R119 Plasma Desktop</div></div></div><br /><div><strong>REVISION DETAIL</strong><div><a href="https://phabricator.kde.org/D28154">https://phabricator.kde.org/D28154</a></div></div><br /><div><strong>To: </strong>cblack, Plasma, VDG, ngraham<br /><strong>Cc: </strong>ngraham, nicolasfella, zzag, plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, jraleigh, zachus, fbampaloukas, GB_2, ragreen, ZrenBot, himcesjf, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart<br /></div>