<table><tr><td style="">ahmadsamir added inline comments.
</td><a style="text-decoration: none; padding: 4px 8px; margin: 0 8px 8px; float: right; color: #464C5C; font-weight: bold; border-radius: 3px; background-color: #F7F7F9; background-image: linear-gradient(to bottom,#fff,#f1f0f1); display: inline-block; border: 1px solid rgba(71,87,120,.2);" href="https://phabricator.kde.org/D28026">View Revision</a></tr></table><br /><div><strong>INLINE COMMENTS</strong><div><div style="margin: 6px 0 12px 0;"><div style="border: 1px solid #C7CCD9; border-radius: 3px;"><div style="padding: 0; background: #F7F7F7; border-color: #e3e4e8; border-style: solid; border-width: 0 0 1px 0; margin: 0;"><div style="color: #74777d; background: #eff2f4; padding: 6px 8px; overflow: hidden;"><a style="float: right; text-decoration: none;" href="https://phabricator.kde.org/D28026#inline-159791">View Inline</a><span style="color: #4b4d51; font-weight: bold;">backtraceparsergdb.cpp:75</span></div>
<div style="font: 11px/15px "Menlo", "Consolas", "Monaco", monospace; white-space: pre-wrap; clear: both; padding: 4px 0; margin: 0;"><div style="padding: 0 8px; margin: 0 4px; ">        <span style="color: #aa4000">if</span> <span class="p">(</span><span style="color: #aa2211">!</span><span class="n">regExp</span><span class="p">.</span><span class="n">cap</span><span class="p">(</span><span style="color: #601200">7</span><span class="p">).</span><span class="n">isEmpty</span><span class="p">())</span> <span class="p">{</span> <span style="color: #74777d">//we have file information (stuff after from|at)</span>
</div><div style="padding: 0 8px; margin: 0 4px; ">            <span style="color: #aa4000">bool</span> <span class="n">file</span> <span style="color: #aa2211">=</span> <span class="n">regExp</span><span class="p">.</span><span class="n">cap</span><span class="p">(</span><span style="color: #601200">8</span><span class="p">)</span> <span style="color: #aa2211">==</span> <span class="n">QLatin1String</span><span class="p">(</span><span style="color: #766510">"at"</span><span class="p">);</span> <span style="color: #74777d">//'at' means we have a source file (likely)</span>
</div><div style="padding: 0 8px; margin: 0 4px; ">            <span style="color: #74777d">// Gdb isn't entirely consistent here, when it uses 'from' it always refers to a library, but</span>
</div></div></div>
<div style="margin: 8px 0; padding: 0 12px;"><p style="padding: 0; margin: 8px;">(Needs rebasing on master).<br />
I'd move this and define "const bool file" in one place.</p></div></div><br /><div style="border: 1px solid #C7CCD9; border-radius: 3px;"><div style="padding: 0; background: #F7F7F7; border-color: #e3e4e8; border-style: solid; border-width: 0 0 1px 0; margin: 0;"><div style="color: #74777d; background: #eff2f4; padding: 6px 8px; overflow: hidden;"><a style="float: right; text-decoration: none;" href="https://phabricator.kde.org/D28026#inline-159793">View Inline</a><span style="color: #4b4d51; font-weight: bold;">backtraceparsergdb.cpp:82</span></div>
<div style="font: 11px/15px "Menlo", "Consolas", "Monaco", monospace; white-space: pre-wrap; clear: both; padding: 4px 0; margin: 0;"><div style="padding: 0 8px; margin: 0 4px; background: rgba(151, 234, 151, .6);">            <span class="n">file</span> <span style="color: #aa2211">=</span> <span class="n">file</span>
</div><div style="padding: 0 8px; margin: 0 4px; background: rgba(151, 234, 151, .6);">                    <span style="color: #aa2211">&&</span> <span class="n">completeSuffix</span> <span style="color: #aa2211">!=</span> <span class="n">QStringLiteral</span><span class="p">(</span><span style="color: #766510">"so"</span><span class="p">)</span> <span style="color: #74777d">/* libf.so (so) */</span>
</div><div style="padding: 0 8px; margin: 0 4px; background: rgba(151, 234, 151, .6);">                    <span style="color: #aa2211">&&</span> <span style="color: #aa2211">!</span><span class="n">completeSuffix</span><span class="p">.</span><span class="n">startsWith</span><span class="p">(</span><span class="n">QStringLiteral</span><span class="p">(</span><span style="color: #766510">"so."</span><span class="p">))</span> <span style="color: #74777d">/* libf.so.1 (so.1) */</span>
</div></div></div>
<div style="margin: 8px 0; padding: 0 12px;"><p style="padding: 0; margin: 8px;">IIUC, QLatin1String is better for string comparisons.</p></div></div><br /><div style="border: 1px solid #C7CCD9; border-radius: 3px;"><div style="padding: 0; background: #F7F7F7; border-color: #e3e4e8; border-style: solid; border-width: 0 0 1px 0; margin: 0;"><div style="color: #74777d; background: #eff2f4; padding: 6px 8px; overflow: hidden;"><a style="float: right; text-decoration: none;" href="https://phabricator.kde.org/D28026#inline-159831">View Inline</a><span style="color: #4b4d51; font-weight: bold;">backtraceparsergdb.cpp:84</span></div>
<div style="font: 11px/15px "Menlo", "Consolas", "Monaco", monospace; white-space: pre-wrap; clear: both; padding: 4px 0; margin: 0;"><div style="padding: 0 8px; margin: 0 4px; background: rgba(151, 234, 151, .6);">                    <span style="color: #aa2211">&&</span> <span style="color: #aa2211">!</span><span class="n">completeSuffix</span><span class="p">.</span><span class="n">startsWith</span><span class="p">(</span><span class="n">QStringLiteral</span><span class="p">(</span><span style="color: #766510">"so."</span><span class="p">))</span> <span style="color: #74777d">/* libf.so.1 (so.1) */</span>
</div><div style="padding: 0 8px; margin: 0 4px; background: rgba(151, 234, 151, .6);">                    <span style="color: #aa2211">&&</span> <span style="color: #aa2211">!</span><span class="n">completeSuffix</span><span class="p">.</span><span class="n">contains</span><span class="p">(</span><span class="n">QStringLiteral</span><span class="p">(</span><span style="color: #766510">".so"</span><span class="p">)</span> <span style="color: #74777d">/* libf-1.0.so.1 (0.so.1)*/</span><span class="p">);</span>
</div><div style="padding: 0 8px; margin: 0 4px; ">            <span style="color: #aa4000">if</span> <span class="p">(</span><span class="n">file</span><span class="p">)</span> <span class="p">{</span>
</div></div></div>
<div style="margin: 8px 0; padding: 0 12px;"><p style="padding: 0; margin: 8px;">startsWith() and contains() have QLatin1String overloads.</p></div></div></div></div></div><br /><div><strong>REPOSITORY</strong><div><div>R871 DrKonqi</div></div></div><br /><div><strong>REVISION DETAIL</strong><div><a href="https://phabricator.kde.org/D28026">https://phabricator.kde.org/D28026</a></div></div><br /><div><strong>To: </strong>sitter, cfeck, ngraham<br /><strong>Cc: </strong>ahmadsamir, plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, jraleigh, zachus, fbampaloukas, GB_2, ragreen, ZrenBot, ngraham, himcesjf, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart<br /></div>