<table><tr><td style="">apol added a comment.
</td><a style="text-decoration: none; padding: 4px 8px; margin: 0 8px 8px; float: right; color: #464C5C; font-weight: bold; border-radius: 3px; background-color: #F7F7F9; background-image: linear-gradient(to bottom,#fff,#f1f0f1); display: inline-block; border: 1px solid rgba(71,87,120,.2);" href="https://phabricator.kde.org/D27857">View Revision</a></tr></table><br /><div><div><p>+1 overall</p></div></div><br /><div><strong>INLINE COMMENTS</strong><div><div style="margin: 6px 0 12px 0;"><div style="border: 1px solid #C7CCD9; border-radius: 3px;"><div style="padding: 0; background: #F7F7F7; border-color: #e3e4e8; border-style: solid; border-width: 0 0 1px 0; margin: 0;"><div style="color: #74777d; background: #eff2f4; padding: 6px 8px; overflow: hidden;"><a style="float: right; text-decoration: none;" href="https://phabricator.kde.org/D27857#inline-159419">View Inline</a><span style="color: #4b4d51; font-weight: bold;">ksolidnotify.cpp:131</span></div>
<div style="font: 11px/15px "Menlo", "Consolas", "Monaco", monospace; white-space: pre-wrap; clear: both; padding: 4px 0; margin: 0;"><div style="padding: 0 8px; margin: 0 4px; ">                <span class="n">QString</span> <span style="color: #004012">out</span><span class="p">(</span><span class="n">p</span><span style="color: #aa2211">-></span><span class="n">readAll</span><span class="p">());</span>
</div><div style="padding: 0 8px; margin: 0 4px; background: rgba(251, 175, 175, .7);">                <span style="color: #aa4000">const</span> <span class="n">QStringList</span> <span style="color: #aa2211">&</span><span class="n">pidList</span> <span style="color: #aa2211">=</span> <span class="n">out</span><span class="p">.</span><span class="n">split</span><span class="p">(</span><span class="n">QReg<span class="bright">Exp</span></span><span class="p">(</span><span class="n">QStringLiteral</span><span class="p">(</span><span style="color: #766510">"</span><span style="color: #bb6622">\\</span><span style="color: #766510">s+"</span><span class="p">)),</span> <span class="n">QString</span><span style="color: #aa2211">::</span><span class="n">SkipEmptyParts</span><span class="p">);</span>
</div><div style="padding: 0 8px; margin: 0 4px; background: rgba(151, 234, 151, .6);">                <span style="color: #aa4000">const</span> <span class="n">QStringList</span> <span style="color: #aa2211">&</span><span class="n">pidList</span> <span style="color: #aa2211">=</span> <span class="n">out</span><span class="p">.</span><span class="n">split</span><span class="p">(</span><span class="n">QReg<span class="bright">ularExpression</span></span><span class="p">(</span><span class="n">QStringLiteral</span><span class="p">(</span><span style="color: #766510">"</span><span style="color: #bb6622">\\</span><span style="color: #766510">s+"</span><span class="p">)),</span> <span class="n">QString</span><span style="color: #aa2211">::</span><span class="n">SkipEmptyParts</span><span class="p">);</span>
</div><div style="padding: 0 8px; margin: 0 4px; ">                <span class="n">KSysGuard</span><span style="color: #aa2211">::</span><span class="n">Processes</span> <span class="n">procs</span><span class="p">;</span>
</div></div></div>
<div style="margin: 8px 0; padding: 0 12px;"><p style="padding: 0; margin: 8px;">it could make sense to use splitRef here, unsure where this is used.</p></div></div><br /><div style="border: 1px solid #C7CCD9; border-radius: 3px;"><div style="padding: 0; background: #F7F7F7; border-color: #e3e4e8; border-style: solid; border-width: 0 0 1px 0; margin: 0;"><div style="color: #74777d; background: #eff2f4; padding: 6px 8px; overflow: hidden;"><a style="float: right; text-decoration: none;" href="https://phabricator.kde.org/D27857#inline-159420">View Inline</a><span style="color: #4b4d51; font-weight: bold;">server.cpp:671</span></div>
<div style="font: 11px/15px "Menlo", "Consolas", "Monaco", monospace; white-space: pre-wrap; clear: both; padding: 4px 0; margin: 0;"><div style="padding: 0 8px; margin: 0 4px; ">        <span style="color: #74777d">// strip the screen number from the display</span>
</div><div style="padding: 0 8px; margin: 0 4px; background: rgba(251, 175, 175, .7);">        <span class="n">display</span><span class="p">.</span><span class="n">remove</span><span class="p">(</span><span class="n">QReg<span class="bright">Exp</span></span><span class="p">(</span><span class="n">QStringLiteral</span><span class="p">(</span><span style="color: #766510">"</span><span style="color: #bb6622">\\</span><span style="color: #766510">.<span class="bright">[0-9]</span>+$"</span><span class="p">)));</span>
</div><div style="padding: 0 8px; margin: 0 4px; background: rgba(151, 234, 151, .6);">        <span class="n">display</span><span class="p">.</span><span class="n">remove</span><span class="p">(</span><span class="n">QReg<span class="bright">ularExpression</span></span><span class="p">(</span><span class="n">QStringLiteral</span><span class="p">(</span><span style="color: #766510">"</span><span style="color: #bb6622">\\</span><span style="color: #766510">.<span class="bright"></span></span><span class="bright"></span><span style="color: #bb6622"><span class="bright">\\</span></span><span class="bright"></span><span style="color: #766510"><span class="bright">d</span>+$"</span><span class="p">)));</span>
</div><div style="padding: 0 8px; margin: 0 4px; ">        <span style="color: #aa4000">int</span> <span class="n">i</span><span class="p">;</span>
</div></div></div>
<div style="margin: 8px 0; padding: 0 12px;"><p style="padding: 0; margin: 8px;">Why the changes from [0-9] to \d?</p></div></div></div></div></div><br /><div><strong>REPOSITORY</strong><div><div>R120 Plasma Workspace</div></div></div><br /><div><strong>REVISION DETAIL</strong><div><a href="https://phabricator.kde.org/D27857">https://phabricator.kde.org/D27857</a></div></div><br /><div><strong>To: </strong>ahmadsamir, Plasma, davidedmundson, apol, broulik<br /><strong>Cc: </strong>plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, jraleigh, zachus, fbampaloukas, GB_2, ragreen, ZrenBot, ngraham, himcesjf, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart<br /></div>