<table><tr><td style="">sitter created this revision.<br />sitter added a reviewer: apol.<br />Herald added a project: Plasma.<br />Herald added a subscriber: plasma-devel.<br />sitter requested review of this revision.
</td><a style="text-decoration: none; padding: 4px 8px; margin: 0 8px 8px; float: right; color: #464C5C; font-weight: bold; border-radius: 3px; background-color: #F7F7F9; background-image: linear-gradient(to bottom,#fff,#f1f0f1); display: inline-block; border: 1px solid rgba(71,87,120,.2);" href="https://phabricator.kde.org/D28098">View Revision</a></tr></table><br /><div><strong>REVISION SUMMARY</strong><div><p>... and update a related test case</p>
<p>the original motivation here was garbage _start traces shouldn't be<br />
considered valuable. of course we have way more advanced measurements for<br />
whether a trace is valuable or not. notably the actual rating. so as<br />
long as we have any frame for evaluation that frame's rating <strong>is</strong><br />
relevant.<br />
drkonqi is smart enough to ignore lines that do not matter already.<br />
e.g. everything above the crash handler is ignored, equally originator<br />
functions main/start_thread/start/... are ignored. they do not impact<br />
the rating at all, regardless of the amount of frames under review.<br />
as such it is entirely possible to have fewer than 4 frames under review<br />
and that those 4 frames are all we need (e.g. the crash is in main()<br />
directly)</p>
<p>in fact, the very trace sample testing this was proving how the 4 line<br />
limit made no sense. the frame about KCmdLineArgs is the only relevant<br />
and only valuable frame in the sample and it is 100% useful making the<br />
entire trace useful. it is simply a nullptr dereference in the main.</p>
<p>the frame limit is now 1 and the test sample has been replaced with<br />
a real-life sample from <a href="https://bugs.kde.org/show_bug.cgi?id=193032" class="remarkup-link" target="_blank" rel="noreferrer">https://bugs.kde.org/show_bug.cgi?id=193032</a></p></div></div><br /><div><strong>TEST PLAN</strong><div><p>test passes again (was broken because _starts is now actively skipped)</p></div></div><br /><div><strong>REPOSITORY</strong><div><div>R871 DrKonqi</div></div></div><br /><div><strong>BRANCH</strong><div><div>master</div></div></div><br /><div><strong>REVISION DETAIL</strong><div><a href="https://phabricator.kde.org/D28098">https://phabricator.kde.org/D28098</a></div></div><br /><div><strong>AFFECTED FILES</strong><div><div>src/parser/backtraceparser.cpp<br />
src/tests/backtraceparsertest/backtraceparsertest_data/test_bug192412_b</div></div></div><br /><div><strong>To: </strong>sitter, apol<br /><strong>Cc: </strong>plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, jraleigh, zachus, fbampaloukas, GB_2, ragreen, ZrenBot, ngraham, himcesjf, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart<br /></div>