<table><tr><td style="">ahiemstra created this revision.<br />ahiemstra added a reviewer: Kirigami.<br />Herald added a project: Kirigami.<br />Herald added a subscriber: plasma-devel.<br />ahiemstra requested review of this revision.
</td><a style="text-decoration: none; padding: 4px 8px; margin: 0 8px 8px; float: right; color: #464C5C; font-weight: bold; border-radius: 3px; background-color: #F7F7F9; background-image: linear-gradient(to bottom,#fff,#f1f0f1); display: inline-block; border: 1px solid rgba(71,87,120,.2);" href="https://phabricator.kde.org/D28038">View Revision</a></tr></table><br /><div><strong>REVISION SUMMARY</strong><div><p>When enabling the border during object creation, the first time updatePaintNode<br />
would be called we'd call setBorderWidth() which switches the node to the bordered<br />
rectangle material, then tries to set the border width, which fails because we have<br />
no geometry rect yet. This splits up setBorderWidth into setBorderEnabled and<br />
setBorderWidth so we can call setBorderEnabled as first thing and setBorderWidth<br />
once a proper rect has been set.</p>
<p>In addition, this also changes the behaviour of border to be completely contained<br />
within the item, to match QtQuick Rectangle behaviour.</p></div></div><br /><div><strong>TEST PLAN</strong><div><p><a href="https://phabricator.kde.org/D28029" style="background-color: #e7e7e7;
border-color: #e7e7e7;
border-radius: 3px;
padding: 0 4px;
font-weight: bold;
color: black;text-decoration: none;">D28029</a> now works properly.</p></div></div><br /><div><strong>REPOSITORY</strong><div><div>R169 Kirigami</div></div></div><br /><div><strong>BRANCH</strong><div><div>shadowedrectangle_border</div></div></div><br /><div><strong>REVISION DETAIL</strong><div><a href="https://phabricator.kde.org/D28038">https://phabricator.kde.org/D28038</a></div></div><br /><div><strong>AFFECTED FILES</strong><div><div>src/scenegraph/shadowedborderrectangle.frag<br />
src/scenegraph/shadowedborderrectangle_core.frag<br />
src/scenegraph/shadowedrectanglenode.cpp<br />
src/scenegraph/shadowedrectanglenode.h<br />
src/shadowedrectangle.cpp</div></div></div><br /><div><strong>To: </strong>ahiemstra, Kirigami<br /><strong>Cc: </strong>plasma-devel, fbampaloukas, GB_2, domson, dkardarakos, ngraham, apol, ahiemstra, davidedmundson, mart<br /></div>