<table><tr><td style="">hpereiradacosta added a comment.
</td><a style="text-decoration: none; padding: 4px 8px; margin: 0 8px 8px; float: right; color: #464C5C; font-weight: bold; border-radius: 3px; background-color: #F7F7F9; background-image: linear-gradient(to bottom,#fff,#f1f0f1); display: inline-block; border: 1px solid rgba(71,87,120,.2);" href="https://phabricator.kde.org/D27938">View Revision</a></tr></table><br /><div><div><p>In my opinion this should really go into a different decoration. Starting to have "styles inside styles" inside a single decoration is a UI mess. <br />
If you want to turn breeze into a theme engine and not a theme, then so be it, but one must go the full way. Not just essentially duplicating the code to render a different set of visually orthogonal buttons into the engine. The new buttons must have a different entry in the kcm. Not be selectable by an internal option. See how decoration engines like aurorae implements different entries in decoration page as the way it should be.<br />
How is a new user supposed to discover that what she/he sees in the KCM is not the only set of icons she/he can chose ?<br />
Also on the code side, the current patch makes the code maintainability much more complicated.</p>
<p>Now I am not the maintainer any more. So feel free to ignore my opinion here. <br />
But I cannot +1 this, sorry. (although the idea is nice, design is nice, etc.)</p>
<p>Hugo</p></div></div><br /><div><strong>REPOSITORY</strong><div><div>R31 Breeze</div></div></div><br /><div><strong>REVISION DETAIL</strong><div><a href="https://phabricator.kde.org/D27938">https://phabricator.kde.org/D27938</a></div></div><br /><div><strong>To: </strong>paulm, hpereiradacosta, Breeze, ndavis<br /><strong>Cc: </strong>ngraham, plasma-devel, manueljlin, Orage, LeGast00n, The-Feren-OS-Dev, cblack, konkinartem, ian, jguidon, Ghost6, jraleigh, zachus, MrPepe, fbampaloukas, squeakypancakes, alexde, IohannesPetros, GB_2, trickyricky26, ragreen, crozbo, ndavis, ZrenBot, firef, skadinna, himcesjf, lesliezhai, ali-mohamed, jensreuterberg, aaronhoneycutt, abetts, sebas, apol, ahiemstra, mbohlender, mart<br /></div>