<table><tr><td style="">ahmadsamir marked 3 inline comments as done.<br />ahmadsamir added inline comments.
</td><a style="text-decoration: none; padding: 4px 8px; margin: 0 8px 8px; float: right; color: #464C5C; font-weight: bold; border-radius: 3px; background-color: #F7F7F9; background-image: linear-gradient(to bottom,#fff,#f1f0f1); display: inline-block; border: 1px solid rgba(71,87,120,.2);" href="https://phabricator.kde.org/D27785">View Revision</a></tr></table><br /><div><strong>INLINE COMMENTS</strong><div><div style="margin: 6px 0 12px 0;"><div style="border: 1px solid #C7CCD9; border-radius: 3px;"><div style="padding: 0; background: #F7F7F7; border-color: #e3e4e8; border-style: solid; border-width: 0 0 1px 0; margin: 0;"><div style="color: #74777d; background: #eff2f4; padding: 6px 8px; overflow: hidden;"><a style="float: right; text-decoration: none;" href="https://phabricator.kde.org/D27785#inline-157867">View Inline</a><span style="color: #4b4d51; font-weight: bold;">bport</span> wrote in <span style="color: #4b4d51; font-weight: bold;">fonts.cpp:115</span></div>
<div style="margin: 8px 0; padding: 0 12px; color: #74777D;"><p style="padding: 0; margin: 8px;">You can use && to have only one if there</p></div></div>
<div style="margin: 8px 0; padding: 0 12px;"><p style="padding: 0; margin: 8px;">OK.</p></div></div><br /><div style="border: 1px solid #C7CCD9; border-radius: 3px;"><div style="padding: 0; background: #F7F7F7; border-color: #e3e4e8; border-style: solid; border-width: 0 0 1px 0; margin: 0;"><div style="color: #74777d; background: #eff2f4; padding: 6px 8px; overflow: hidden;"><a style="float: right; text-decoration: none;" href="https://phabricator.kde.org/D27785#inline-157866">View Inline</a><span style="color: #4b4d51; font-weight: bold;">bport</span> wrote in <span style="color: #4b4d51; font-weight: bold;">fonts.cpp:552</span></div>
<div style="margin: 8px 0; padding: 0 12px; color: #74777D;"><p style="padding: 0; margin: 8px;">Those change will compare font twice, here and on setters so I will keep old code there</p></div></div>
<div style="margin: 8px 0; padding: 0 12px;"><p style="padding: 0; margin: 8px;">Indeed; looking at the code generated by kconfig compiler in <builddir>/kcms/fonts/fontsettings.h:</p>
<div class="remarkup-code-block" style="margin: 12px 0;" data-code-lang="text" data-sigil="remarkup-code-block"><pre class="remarkup-code" style="font: 11px/15px "Menlo", "Consolas", "Monaco", monospace; padding: 12px; margin: 0; background: rgba(71, 87, 120, 0.08);">/**
Set General font
*/
void setFont( const QFont & v )
{
if (v != mFont && !isFontImmutable()) {
mFont = v;
Q_EMIT fontChanged();
}
}</pre></div>
<p style="padding: 0; margin: 8px;">I will revert. And another point is that the code in fonts.cpp doesn't need to check for immutability since it's checked by the setters.</p></div></div><br /><div style="border: 1px solid #C7CCD9; border-radius: 3px;"><div style="padding: 0; background: #F7F7F7; border-color: #e3e4e8; border-style: solid; border-width: 0 0 1px 0; margin: 0;"><div style="color: #74777d; background: #eff2f4; padding: 6px 8px; overflow: hidden;"><a style="float: right; text-decoration: none;" href="https://phabricator.kde.org/D27785#inline-157864">View Inline</a><span style="color: #4b4d51; font-weight: bold;">bport</span> wrote in <span style="color: #4b4d51; font-weight: bold;">fonts.cpp:576</span></div>
<div style="margin: 8px 0; padding: 0 12px; color: #74777D;"><p style="padding: 0; margin: 8px;">I will keep that until we have a proper tested fix for <a href="https://phabricator.kde.org/D27452" class="remarkup-link" target="_blank" rel="noreferrer">https://phabricator.kde.org/D27452</a><br />
can prevent bug and ensure apply button is on the good state on all case</p></div></div>
<div style="margin: 8px 0; padding: 0 12px;"><p style="padding: 0; margin: 8px;">OK, fair point, I will revert that bit.</p></div></div></div></div></div><br /><div><strong>REPOSITORY</strong><div><div>R119 Plasma Desktop</div></div></div><br /><div><strong>REVISION DETAIL</strong><div><a href="https://phabricator.kde.org/D27785">https://phabricator.kde.org/D27785</a></div></div><br /><div><strong>To: </strong>ahmadsamir, Plasma, davidedmundson, broulik, ervin, meven<br /><strong>Cc: </strong>plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, jraleigh, zachus, fbampaloukas, GB_2, ragreen, ZrenBot, ngraham, himcesjf, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart<br /></div>