<table><tr><td style="">ngraham created this revision.<br />ngraham added reviewers: VDG, Kirigami, mart, apol.<br />Herald added a project: Kirigami.<br />Herald added a subscriber: plasma-devel.<br />ngraham requested review of this revision.
</td><a style="text-decoration: none; padding: 4px 8px; margin: 0 8px 8px; float: right; color: #464C5C; font-weight: bold; border-radius: 3px; background-color: #F7F7F9; background-image: linear-gradient(to bottom,#fff,#f1f0f1); display: inline-block; border: 1px solid rgba(71,87,120,.2);" href="https://phabricator.kde.org/D27663">View Revision</a></tr></table><br /><div><strong>REVISION SUMMARY</strong><div><p>Normally the <tt style="background: #ebebeb; font-size: 13px;">URLButton</tt> shows the full URL in its text. However if this text is overridden<br />
to anything else, then the user can't know where the URL points, which may be worrisome,<br />
and could be abused by malicious applications to obscure a hostile URL.</p>
<p>This patch implements a tooltip shat shows the full URL when the <tt style="background: #ebebeb; font-size: 13px;">text</tt> property has been<br />
overridden and no longer shows the real URL.</p></div></div><br /><div><strong>TEST PLAN</strong><div><p><a href="https://phabricator.kde.org/F8131965" style="background-color: #e7e7e7;
border-color: #e7e7e7;
border-radius: 3px;
padding: 0 4px;
font-weight: bold;
color: black;text-decoration: none;">F8131965: vokoscreenNG-2020-02-25_14-35-45.mp4</a></p></div></div><br /><div><strong>REPOSITORY</strong><div><div>R169 Kirigami</div></div></div><br /><div><strong>BRANCH</strong><div><div>conditionally-show-tooltip-on-url-button (branched from master)</div></div></div><br /><div><strong>REVISION DETAIL</strong><div><a href="https://phabricator.kde.org/D27663">https://phabricator.kde.org/D27663</a></div></div><br /><div><strong>AFFECTED FILES</strong><div><div>src/controls/LinkButton.qml<br />
src/controls/UrlButton.qml</div></div></div><br /><div><strong>To: </strong>ngraham, VDG, Kirigami, mart, apol<br /><strong>Cc: </strong>plasma-devel, fbampaloukas, GB_2, domson, dkardarakos, ngraham, apol, ahiemstra, davidedmundson, mart, hein<br /></div>