<table><tr><td style="">ngraham accepted this revision.<br />ngraham added a comment.<br />This revision is now accepted and ready to land.
</td><a style="text-decoration: none; padding: 4px 8px; margin: 0 8px 8px; float: right; color: #464C5C; font-weight: bold; border-radius: 3px; background-color: #F7F7F9; background-image: linear-gradient(to bottom,#fff,#f1f0f1); display: inline-block; border: 1px solid rgba(71,87,120,.2);" href="https://phabricator.kde.org/D27422">View Revision</a></tr></table><br /><div><div><p>LGTM. <a href="https://phabricator.kde.org/tag/plasma/" style="background-color: #e7e7e7;
border-color: #e7e7e7;
border-radius: 3px;
padding: 0 4px;
font-weight: bold;
color: black;text-decoration: none;">#plasma</a> folks?</p>
<blockquote style="border-left: 3px solid #8C98B8;
color: #6B748C;
font-style: italic;
margin: 4px 0 12px 0;
padding: 8px 12px;
background-color: #F8F9FC;">
<div style="font-style: normal;
padding-bottom: 4px;">In <a href="https://phabricator.kde.org/D27422#612797" style="background-color: #e7e7e7;
border-color: #e7e7e7;
border-radius: 3px;
padding: 0 4px;
font-weight: bold;
color: black;text-decoration: none;">D27422#612797</a>, <a href="https://phabricator.kde.org/p/gvgeo/" style="
border-color: #f1f7ff;
color: #19558d;
background-color: #f1f7ff;
border: 1px solid transparent;
border-radius: 3px;
font-weight: bold;
padding: 0 4px;">@gvgeo</a> wrote:</div>
<div style="margin: 0;
padding: 0;
border: 0;
color: rgb(107, 116, 140);"><p>Remove PlasmaComponents.</p>
<p>So.. why all these different distinctions exist?</p></div>
</blockquote>
<p>History.</p>
<p>The original PlasmaComponents was created first, after QML was invented, but before QtQuick. Then QtQuick was invented, and PlasmaComponents was re-done to be based on it and called "PlasmaComponents2". Then QtQuick2 was invented, and "PlasmaComponents3" was created with the expectation to porting to that.</p>
<p>In the meantime, people started to want to use QML for non-Plasma user interfaces. So a QQC2 desktop style bridge was created, hence the qqc2-desktop-style framework. However people were not satisfied with the primitive state of QQC2 components so we started to make higher-level versions (e.g. drawers, pages with toolbars and navigation) and called it Kirigami.</p>
<p>I expect in the future that PlasmaComponents (all versions) will go away, and if we want to retain some plasma-specific styling, that will be done in a different way that does not require a separate component library. See <a href="https://phabricator.kde.org/T11558" style="background-color: #e7e7e7;
border-color: #e7e7e7;
border-radius: 3px;
padding: 0 4px;
font-weight: bold;
color: black;text-decoration: none;">T11558</a>.</p></div></div><br /><div><strong>REPOSITORY</strong><div><div>R115 Plasma Audio Volume Applet</div></div></div><br /><div><strong>BRANCH</strong><div><div>kcmports2</div></div></div><br /><div><strong>REVISION DETAIL</strong><div><a href="https://phabricator.kde.org/D27422">https://phabricator.kde.org/D27422</a></div></div><br /><div><strong>To: </strong>gvgeo, Plasma, drosca, ngraham, VDG<br /><strong>Cc: </strong>plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, jraleigh, zachus, fbampaloukas, GB_2, ragreen, ZrenBot, ngraham, alexeymin, himcesjf, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart<br /></div>