<table><tr><td style="">ngraham resigned from this revision.<br />ngraham added a comment.
</td><a style="text-decoration: none; padding: 4px 8px; margin: 0 8px 8px; float: right; color: #464C5C; font-weight: bold; border-radius: 3px; background-color: #F7F7F9; background-image: linear-gradient(to bottom,#fff,#f1f0f1); display: inline-block; border: 1px solid rgba(71,87,120,.2);" href="https://phabricator.kde.org/D27438">View Revision</a></tr></table><br /><div><div><p>I have a vertical panel and use large tray icons but intentionally minimize their number, and the result looks fine to me IMO: <a href="https://phabricator.kde.org/F8107338" style="background-color: #e7e7e7;
border-color: #e7e7e7;
border-radius: 3px;
padding: 0 4px;
font-weight: bold;
color: black;text-decoration: none;">F8107338: Screenshot_20200216_115030.png</a></p>
<p>However I'll admit that I thought the status quo was fine too. So I have no particular opinion on the aesthetics of this patch, but I think we should be careful to avoid adding too much spacing because the people who have and like lots of tray icons have a legitimate concern here. To me, <tt style="background: #ebebeb; font-size: 13px;">units.smallSpacing</tt> (i.e. 2) is the absolute max we should do.</p>
<p>To make this patch easier to review without applying it, please add all the various sets of before-and-after images to the <span><span class="phui-tag-view phui-tag-type-shade phui-tag-grey phui-tag-shade "><span class="phui-tag-core ">Test Plan</span></span></span> section, not in comments.</p></div></div><br /><div><strong>REPOSITORY</strong><div><div>R120 Plasma Workspace</div></div></div><br /><div><strong>REVISION DETAIL</strong><div><a href="https://phabricator.kde.org/D27438">https://phabricator.kde.org/D27438</a></div></div><br /><div><strong>To: </strong>The-Feren-OS-Dev, VDG<br /><strong>Cc: </strong>ndavis, anthonyfieroni, davidre, ngraham, plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, jraleigh, zachus, fbampaloukas, GB_2, ragreen, ZrenBot, alexeymin, himcesjf, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart<br /></div>