<table><tr><td style="">ervin accepted this revision.<br />ervin added a comment.<br />This revision is now accepted and ready to land.
</td><a style="text-decoration: none; padding: 4px 8px; margin: 0 8px 8px; float: right; color: #464C5C; font-weight: bold; border-radius: 3px; background-color: #F7F7F9; background-image: linear-gradient(to bottom,#fff,#f1f0f1); display: inline-block; border: 1px solid rgba(71,87,120,.2);" href="https://phabricator.kde.org/D27052">View Revision</a></tr></table><br /><div><div><p>Just a nitpick, your call if you want to tackle it or not.</p></div></div><br /><div><strong>INLINE COMMENTS</strong><div><div style="margin: 6px 0 12px 0;"><div style="border: 1px solid #C7CCD9; border-radius: 3px;"><div style="padding: 0; background: #F7F7F7; border-color: #e3e4e8; border-style: solid; border-width: 0 0 1px 0; margin: 0;"><div style="color: #74777d; background: #eff2f4; padding: 6px 8px; overflow: hidden;"><a style="float: right; text-decoration: none;" href="https://phabricator.kde.org/D27052#inline-154402">View Inline</a><span style="color: #4b4d51; font-weight: bold;">DeviceAutomounter.cpp:73</span></div>
<div style="font: 11px/15px "Menlo", "Consolas", "Monaco", monospace; white-space: pre-wrap; clear: both; padding: 4px 0; margin: 0;"><div style="padding: 0 8px; margin: 0 4px; background: rgba(251, 175, 175, .7);">    <span class="n">QList</span><span style="color: #aa2211"><</span><span class="n">Solid</span><span style="color: #aa2211">::</span><span class="n">Device</span><span style="color: #aa2211">></span> <span class="n">volumes</span> <span style="color: #aa2211">=</span> <span class="n">Solid</span><span style="color: #aa2211">::</span><span class="n">Device</span><span style="color: #aa2211">::</span><span class="n">listFromType</span><span class="p">(</span><span class="n">Solid</span><span style="color: #aa2211">::</span><span class="n">DeviceInterface</span><span style="color: #aa2211">::</span><span class="n">StorageVolume</span><span class="p">);</span>
</div><div style="padding: 0 8px; margin: 0 4px; background: rgba(251, 175, 175, .7);">    <span class="n">for<span class="bright">each</span></span><span class="p">(</span><span class="n">Solid</span><span style="color: #aa2211">::</span><span class="n">Device</span> <span class="n">volume<span class="bright"></span></span><span class="bright"></span><span class="p"><span class="bright">,</span></span> <span class="n">volumes</span><span class="p">)</span> <span class="p">{</span>
</div><div style="padding: 0 8px; margin: 0 4px; background: rgba(151, 234, 151, .6);">    <span class="bright"></span><span style="color: #aa4000"><span class="bright">const</span></span><span class="bright"> </span><span class="n">QList</span><span style="color: #aa2211"><</span><span class="n">Solid</span><span style="color: #aa2211">::</span><span class="n">Device</span><span style="color: #aa2211">></span> <span class="n">volumes</span> <span style="color: #aa2211">=</span> <span class="n">Solid</span><span style="color: #aa2211">::</span><span class="n">Device</span><span style="color: #aa2211">::</span><span class="n">listFromType</span><span class="p">(</span><span class="n">Solid</span><span style="color: #aa2211">::</span><span class="n">DeviceInterface</span><span style="color: #aa2211">::</span><span class="n">StorageVolume</span><span class="p">);</span>
</div><div style="padding: 0 8px; margin: 0 4px; background: rgba(151, 234, 151, .6);">    <span style="color: #aa4000">for</span><span class="p">(</span><span class="n">Solid</span><span style="color: #aa2211">::</span><span class="n">Device</span> <span style="color: #a0a000">volume<span class="bright"></span></span><span class="bright"> </span><span class="p"><span class="bright">:</span></span> <span class="n">volumes</span><span class="p">)</span> <span class="p">{</span>
</div><div style="padding: 0 8px; margin: 0 4px; ">        <span style="color: #74777d">// sa can be 0 (e.g. for the swap partition)</span>
</div></div></div>
<div style="margin: 8px 0; padding: 0 12px;"><p style="padding: 0; margin: 8px;">nitpick, feel free to ignore: would make sense to switch to a const ref here since we're touching the line anyway. in the same vein, "const auto" on the line before wouldn't be a bad idea either (if we ever switch to QVector for instance it'd be one less place where compilation would break).</p></div></div></div></div></div><br /><div><strong>REPOSITORY</strong><div><div>R119 Plasma Desktop</div></div></div><br /><div><strong>BRANCH</strong><div><div>arcpatch-D27052</div></div></div><br /><div><strong>REVISION DETAIL</strong><div><a href="https://phabricator.kde.org/D27052">https://phabricator.kde.org/D27052</a></div></div><br /><div><strong>To: </strong>meven, broulik, ervin, Plasma<br /><strong>Cc: </strong>alex, plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, jraleigh, zachus, fbampaloukas, GB_2, ragreen, ZrenBot, ngraham, alexeymin, himcesjf, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart<br /></div>