<table><tr><td style="">cgiboudeaux accepted this revision.<br />cgiboudeaux added a comment.<br />This revision is now accepted and ready to land.
</td><a style="text-decoration: none; padding: 4px 8px; margin: 0 8px 8px; float: right; color: #464C5C; font-weight: bold; border-radius: 3px; background-color: #F7F7F9; background-image: linear-gradient(to bottom,#fff,#f1f0f1); display: inline-block; border: 1px solid rgba(71,87,120,.2);" href="https://phabricator.kde.org/D27277">View Revision</a></tr></table><br /><div><div><p>Just one thing left to fix before pushing</p></div></div><br /><div><strong>INLINE COMMENTS</strong><div><div style="margin: 6px 0 12px 0;"><div style="border: 1px solid #C7CCD9; border-radius: 3px;"><div style="padding: 0; background: #F7F7F7; border-color: #e3e4e8; border-style: solid; border-width: 0 0 1px 0; margin: 0;"><div style="color: #74777d; background: #eff2f4; padding: 6px 8px; overflow: hidden;"><a style="float: right; text-decoration: none;" href="https://phabricator.kde.org/D27277#inline-154173">View Inline</a><span style="color: #4b4d51; font-weight: bold;">FindPipeWire.cmake:112</span></div>
<div style="font: 11px/15px "Menlo", "Consolas", "Monaco", monospace; white-space: pre-wrap; clear: both; padding: 4px 0; margin: 0;"><div style="padding: 0 8px; margin: 0 4px; ">        <span style="color: #766510">INTERFACE_COMPILE_OPTIONS</span> <span style="color: #766510">"${PipeWire_DEFINITIONS}"</span>
</div><div style="padding: 0 8px; margin: 0 4px; background: rgba(251, 175, 175, .7);">        <span style="color: #766510">INTERFACE_INCLUDE_DIRECTORIES</span> <span style="color: #766510">"${PipeWire_INCLUDE_DIRS}"</span>
</div><div style="padding: 0 8px; margin: 0 4px; background: rgba(151, 234, 151, .6);">        <span style="color: #766510">INTERFACE_INCLUDE_DIRECTORIES</span> <span style="color: #766510">"${PipeWire_INCLUDE_DIRS}"<span class="bright"></span></span><span class="bright"> </span><span style="color: #766510"><span class="bright">"${Spa_INCLUDE_DIRS}"</span></span>
</div><div style="padding: 0 8px; margin: 0 4px; ">    <span class="p">)</span>
</div></div></div>
<div style="margin: 8px 0; padding: 0 12px;"><p style="padding: 0; margin: 8px;">INTERFACE_INCLUDE_DIRECTORIES "${PipeWire_INCLUDE_DIRS};${Spa_INCLUDE_DIRS}"</p></div></div></div></div></div><br /><div><strong>REPOSITORY</strong><div><div>R838 Flatpak Support: KDE Portal for XDG Desktop</div></div></div><br /><div><strong>BRANCH</strong><div><div>Plasma/5.18</div></div></div><br /><div><strong>REVISION DETAIL</strong><div><a href="https://phabricator.kde.org/D27277">https://phabricator.kde.org/D27277</a></div></div><br /><div><strong>To: </strong>jgrulich, Plasma, cgiboudeaux<br /><strong>Cc: </strong>cgiboudeaux, plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, jraleigh, zachus, fbampaloukas, GB_2, ragreen, ZrenBot, ngraham, alexeymin, himcesjf, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart<br /></div>