<table><tr><td style="">ngraham created this revision.<br />ngraham added a reviewer: Plasma.<br />Herald added a project: Plasma.<br />Herald added a subscriber: plasma-devel.<br />ngraham requested review of this revision.
</td><a style="text-decoration: none; padding: 4px 8px; margin: 0 8px 8px; float: right; color: #464C5C; font-weight: bold; border-radius: 3px; background-color: #F7F7F9; background-image: linear-gradient(to bottom,#fff,#f1f0f1); display: inline-block; border: 1px solid rgba(71,87,120,.2);" href="https://phabricator.kde.org/D27261">View Revision</a></tr></table><br /><div><strong>REVISION SUMMARY</strong><div><p>This fixes the binding loop and replaces a complicated bit of code with something much<br />
simpler.</p></div></div><br /><div><strong>TEST PLAN</strong><div><p>No more binding loop warning when running <tt style="background: #ebebeb; font-size: 13px;">plasmashell</tt> on the CLI</p>
<p>No meaningful difference in appearance for every combination of icon size and label<br />
width in icon view</p></div></div><br /><div><strong>REPOSITORY</strong><div><div>R119 Plasma Desktop</div></div></div><br /><div><strong>BRANCH</strong><div><div>fix-folderview-binding-loop (branched from master)</div></div></div><br /><div><strong>REVISION DETAIL</strong><div><a href="https://phabricator.kde.org/D27261">https://phabricator.kde.org/D27261</a></div></div><br /><div><strong>AFFECTED FILES</strong><div><div>containments/desktop/package/contents/ui/FolderItemDelegate.qml</div></div></div><br /><div><strong>To: </strong>ngraham, Plasma<br /><strong>Cc: </strong>plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, jraleigh, zachus, fbampaloukas, GB_2, ragreen, ZrenBot, ngraham, alexeymin, himcesjf, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart<br /></div>