<table><tr><td style="">ngraham created this revision.<br />ngraham added reviewers: Plasma, VDG.<br />Herald added a project: Plasma.<br />Herald added a subscriber: plasma-devel.<br />ngraham requested review of this revision.
</td><a style="text-decoration: none; padding: 4px 8px; margin: 0 8px 8px; float: right; color: #464C5C; font-weight: bold; border-radius: 3px; background-color: #F7F7F9; background-image: linear-gradient(to bottom,#fff,#f1f0f1); display: inline-block; border: 1px solid rgba(71,87,120,.2);" href="https://phabricator.kde.org/D27182">View Revision</a></tr></table><br /><div><strong>REVISION SUMMARY</strong><div><p>The ToolTip code was kind of messy. This patch adjusts it to use modern Layouts,<br />
fixes some binding loops, reduces redundancy, adds comments, and ports almost<br />
everything to PlasmaComponents3. We still need PC2 for <tt style="background: #ebebeb; font-size: 13px;">Highlight</tt> so it can't<br />
be removed entirely.</p>
<p>There is only one unavoidable visual change, which was made in this patch<br />
because it is consistent with the latest VDG mockup (<a href="https://phabricator.kde.org/T12640" style="background-color: #e7e7e7;
border-color: #e7e7e7;
border-radius: 3px;
padding: 0 4px;
font-weight: bold;
color: black;text-decoration: none;">T12640</a>): the blurred<br />
album art background no longer goes under the player controls bar. This<br />
simplifies the code substantially, and as the mockup shows, it just looks better<br />
anyway (IMO).</p>
<p>This is not intended to fully implement the mockup in <a href="https://phabricator.kde.org/T12640" style="background-color: #e7e7e7;
border-color: #e7e7e7;
border-radius: 3px;
padding: 0 4px;
font-weight: bold;
color: black;text-decoration: none;">T12640</a>.</p></div></div><br /><div><strong>TEST PLAN</strong><div><p>Everything looks the same, except for this:</p>
<p><a href="https://phabricator.kde.org/F8087660" style="background-color: #e7e7e7;
border-color: #e7e7e7;
border-radius: 3px;
padding: 0 4px;
font-weight: bold;
color: black;text-decoration: none;">F8087660: Peek 2020-02-05 21-49.webm</a></p></div></div><br /><div><strong>REPOSITORY</strong><div><div>R119 Plasma Desktop</div></div></div><br /><div><strong>BRANCH</strong><div><div>clean-up-tooltip-code (branched from master)</div></div></div><br /><div><strong>REVISION DETAIL</strong><div><a href="https://phabricator.kde.org/D27182">https://phabricator.kde.org/D27182</a></div></div><br /><div><strong>AFFECTED FILES</strong><div><div>applets/taskmanager/package/contents/ui/ToolTipInstance.qml</div></div></div><br /><div><strong>To: </strong>ngraham, Plasma, VDG<br /><strong>Cc: </strong>plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, jraleigh, zachus, fbampaloukas, GB_2, ragreen, ZrenBot, ngraham, alexeymin, himcesjf, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart<br /></div>