<table><tr><td style="">broulik added a comment.
</td><a style="text-decoration: none; padding: 4px 8px; margin: 0 8px 8px; float: right; color: #464C5C; font-weight: bold; border-radius: 3px; background-color: #F7F7F9; background-image: linear-gradient(to bottom,#fff,#f1f0f1); display: inline-block; border: 1px solid rgba(71,87,120,.2);" href="https://phabricator.kde.org/D27160">View Revision</a></tr></table><br /><div><div><p>When there is no player it completely falls apart. It also doesn't work when there is no album art. The fallback player icon is gone.<br />
<a href="https://phabricator.kde.org/F8086262" style="background-color: #e7e7e7;
border-color: #e7e7e7;
border-radius: 3px;
padding: 0 4px;
font-weight: bold;
color: black;text-decoration: none;">F8086262: Screenshot_20200205_093259.PNG</a></p>
<p>The line spacing also seems a little excessive. Since there's a massive right padding to match the one on the left, you often end up with awkward line breaks:<br />
<a href="https://phabricator.kde.org/F8086264" style="background-color: #e7e7e7;
border-color: #e7e7e7;
border-radius: 3px;
padding: 0 4px;
font-weight: bold;
color: black;text-decoration: none;">F8086264: Screenshot_20200205_093515.PNG</a><br />
Note how the "seh" could have easily fitted in the same line. It now also looks a bit awkward when you can't seek where there's no slider handle.</p>
<p>It looks really lovely with short texts<br />
<a href="https://phabricator.kde.org/F8086272" style="background-color: #e7e7e7;
border-color: #e7e7e7;
border-radius: 3px;
padding: 0 4px;
font-weight: bold;
color: black;text-decoration: none;">F8086272: Screenshot_20200205_093836.PNG</a><br />
but you know...<br />
<a href="https://phabricator.kde.org/F8086274" style="background-color: #e7e7e7;
border-color: #e7e7e7;
border-radius: 3px;
padding: 0 4px;
font-weight: bold;
color: black;text-decoration: none;">F8086274: Screenshot_20200205_094303.PNG</a><br />
And obviously I would prefer a better look for the player selection combo :)</p></div></div><br /><div><strong>INLINE COMMENTS</strong><div><div style="margin: 6px 0 12px 0;"><div style="border: 1px solid #C7CCD9; border-radius: 3px;"><div style="padding: 0; background: #F7F7F7; border-color: #e3e4e8; border-style: solid; border-width: 0 0 1px 0; margin: 0;"><div style="color: #74777d; background: #eff2f4; padding: 6px 8px; overflow: hidden;"><a style="float: right; text-decoration: none;" href="https://phabricator.kde.org/D27160#inline-153545">View Inline</a><span style="color: #4b4d51; font-weight: bold;">ExpandedRepresentation.qml:137</span></div>
<div style="font: 11px/15px "Menlo", "Consolas", "Monaco", monospace; white-space: pre-wrap; clear: both; padding: 4px 0; margin: 0;"><div style="padding: 0 8px; margin: 0 4px; background: rgba(251, 175, 175, .7);"> <span class="bright"></span><span style="color: #aa4000"><span class="bright">textRole:</span></span><span class="bright"> </span><span style="color: #766510"><span class="bright">"text"</span></span>
</div><div style="padding: 0 8px; margin: 0 4px; background: rgba(251, 175, 175, .7);"> <span class="bright"></span><span style="color: #aa4000"><span class="bright">visible:</span></span><span class="bright"> </span><span style="color: #004012"><span class="bright">model</span></span><span class="bright"></span><span class="p"><span class="bright">.</span></span><span class="bright"></span><span style="color: #004012"><span class="bright">length</span></span><span class="bright"> </span><span style="color: #aa2211"><span class="bright">></span></span><span class="bright"> </span><span style="color: #601200"><span class="bright">2</span></span><span class="bright"> </span><span style="color: #74777d"><span class="bright">// more than one player, @multiplex is always there</span></span>
</div><div style="padding: 0 8px; margin: 0 4px; background: rgba(251, 175, 175, .7);"> <span class="bright"></span><span style="color: #aa4000"><span class="bright">model:</span></span><span class="bright"> </span><span class="p"><span class="bright">{</span></span>
</div><div style="padding: 0 8px; margin: 0 4px; background: rgba(151, 234, 151, .6);"> <span class="bright"> </span><span style="color: #aa4000"><span class="bright">Layout.margins:</span></span><span class="bright"> </span><span style="color: #004012"><span class="bright">units</span></span><span class="bright"></span><span class="p"><span class="bright">.</span></span><span class="bright"></span><span style="color: #004012"><span class="bright">smallSpacing</span></span>
</div><div style="padding: 0 8px; margin: 0 4px; background: rgba(151, 234, 151, .6);"> <span class="bright"> </span><span style="color: #aa4000"><span class="bright">Layout.alignment:</span></span><span class="bright"> </span><span style="color: #004012"><span class="bright">Qt</span></span><span class="bright"></span><span class="p"><span class="bright">.</span></span><span class="bright"></span><span style="color: #004012"><span class="bright">AlignHCenter</span></span>
</div><div style="padding: 0 8px; margin: 0 4px; background: rgba(151, 234, 151, .6);"> <span class="bright"> </span><span style="color: #aa4000"><span class="bright">Layout.fillWidth:</span></span><span class="bright"> </span><span style="color: #000a65"><span class="bright">true</span></span>
</div></div></div>
<div style="margin: 8px 0; padding: 0 12px;"><p style="padding: 0; margin: 8px;">Superfluous since you fill both width and height?</p></div></div><br /><div style="border: 1px solid #C7CCD9; border-radius: 3px;"><div style="padding: 0; background: #F7F7F7; border-color: #e3e4e8; border-style: solid; border-width: 0 0 1px 0; margin: 0;"><div style="color: #74777d; background: #eff2f4; padding: 6px 8px; overflow: hidden;"><a style="float: right; text-decoration: none;" href="https://phabricator.kde.org/D27160#inline-153546">View Inline</a><span style="color: #4b4d51; font-weight: bold;">ExpandedRepresentation.qml:145-148</span></div>
<div style="font: 11px/15px "Menlo", "Consolas", "Monaco", monospace; white-space: pre-wrap; clear: both; padding: 4px 0; margin: 0;"><div style="padding: 0 8px; margin: 0 4px; background: rgba(251, 175, 175, .7);"> <span class="bright"></span><span style="color: #74777d"><span class="bright">// would have to connect all</span> source<span class="bright">s just for this</span></span>
</div><div style="padding: 0 8px; margin: 0 4px; background: rgba(251, 175, 175, .7);"> <span class="bright"></span><span style="color: #004012"><span class="bright">model</span></span><span class="bright"></span><span class="p"><span class="bright">.</span></span><span class="bright"></span><span style="color: #004012"><span class="bright">push</span></span><span class="bright"></span><span class="p"><span class="bright">({</span></span><span class="bright"></span><span style="color: #aa4000"><span class="bright">text:</span></span><span class="bright"> </span><span style="color: #004012"><span class="bright">source</span></span><span class="bright"></span><span class="p"><span class="bright">,</span></span><span class="bright"> </span><span style="color: #aa4000"><span class="bright">source:</span></span><span class="bright"> </span><span style="color: #004012"><span class="bright">source</span></span><span class="bright"></span><span class="p"><span class="bright">})</span></span>
</div><div style="padding: 0 8px; margin: 0 4px; background: rgba(251, 175, 175, .7);"> <span class="bright"></span><span class="p"><span class="bright">}</span></span>
</div><div style="padding: 0 8px; margin: 0 4px; background: rgba(151, 234, 151, .6);"> <span class="bright"></span><span style="color: #aa4000"><span class="bright">sourceSize.width:</span></span><span class="bright"> </span><span style="color: #601200"><span class="bright">512</span></span><span class="bright"> </span><span style="color: #74777d"><span class="bright">/* Setting a</span> source<span class="bright"> size means the item doesn't need</span></span>
</div><div style="padding: 0 8px; margin: 0 4px; background: rgba(151, 234, 151, .6);"><span style="color: #74777d"> <span class="bright"> to recompute blur as the user resizes the plasmoid</span></span>
</div><div style="padding: 0 8px; margin: 0 4px; background: rgba(151, 234, 151, .6);"><span style="color: #74777d"> <span class="bright"> Additionally, it puts a bit of a cap on how large the</span></span>
</div><div style="padding: 0 8px; margin: 0 4px; background: rgba(151, 234, 151, .6);"><span style="color: #74777d"> buffer getting blurred can be, saving resources.</span>
</div></div></div>
<div style="margin: 8px 0; padding: 0 12px;"><p style="padding: 0; margin: 8px;">Do you have a source for this claim? From what I know blur merely blurs the actual item texture which is rendered, no the raw image source?</p></div></div><br /><div style="border: 1px solid #C7CCD9; border-radius: 3px;"><div style="padding: 0; background: #F7F7F7; border-color: #e3e4e8; border-style: solid; border-width: 0 0 1px 0; margin: 0;"><div style="color: #74777d; background: #eff2f4; padding: 6px 8px; overflow: hidden;"><a style="float: right; text-decoration: none;" href="https://phabricator.kde.org/D27160#inline-153547">View Inline</a><span style="color: #4b4d51; font-weight: bold;">ExpandedRepresentation.qml:205</span></div>
<div style="font: 11px/15px "Menlo", "Consolas", "Monaco", monospace; white-space: pre-wrap; clear: both; padding: 4px 0; margin: 0;"><div style="padding: 0 8px; margin: 0 4px; background: rgba(151, 234, 151, .6);"> <span style="color: #aa4000">color:</span> <span style="color: #004012">softwareRendering</span> <span style="color: #aa2211">?</span> <span style="color: #aa4000">undefined :</span> <span style="color: #766510">"white"</span>
</div></div></div>
<div style="margin: 8px 0; padding: 0 12px;"><p style="padding: 0; margin: 8px;">Does assigning <tt style="background: #ebebeb; font-size: 13px;">undefined</tt> work? I don't see a <tt style="background: #ebebeb; font-size: 13px;">RESET</tt> property for it. Probably want to assign color scope text color instead?</p></div></div><br /><div style="border: 1px solid #C7CCD9; border-radius: 3px;"><div style="padding: 0; background: #F7F7F7; border-color: #e3e4e8; border-style: solid; border-width: 0 0 1px 0; margin: 0;"><div style="color: #74777d; background: #eff2f4; padding: 6px 8px; overflow: hidden;"><a style="float: right; text-decoration: none;" href="https://phabricator.kde.org/D27160#inline-153548">View Inline</a><span style="color: #4b4d51; font-weight: bold;">ExpandedRepresentation.qml:212</span></div>
<div style="font: 11px/15px "Menlo", "Consolas", "Monaco", monospace; white-space: pre-wrap; clear: both; padding: 4px 0; margin: 0;"><div style="padding: 0 8px; margin: 0 4px; background: rgba(151, 234, 151, .6);"> <span style="color: #aa4000">Layout.maximumWidth:</span> <span style="color: #004012">expandedRepresentation</span><span class="p">.</span><span style="color: #004012">width</span> <span style="color: #aa2211">*</span> <span class="p">(</span><span style="color: #601200">2</span><span style="color: #aa2211">/</span><span style="color: #601200">5</span><span class="p">)</span>
</div><div style="padding: 0 8px; margin: 0 4px; "> <span class="p">}</span>
</div></div></div>
<div style="margin: 8px 0; padding: 0 12px;"><p style="padding: 0; margin: 8px;">Make sure to <tt style="background: #ebebeb; font-size: 13px;">Math.round</tt> random factors of a size</p></div></div><br /><div style="border: 1px solid #C7CCD9; border-radius: 3px;"><div style="padding: 0; background: #F7F7F7; border-color: #e3e4e8; border-style: solid; border-width: 0 0 1px 0; margin: 0;"><div style="color: #74777d; background: #eff2f4; padding: 6px 8px; overflow: hidden;"><a style="float: right; text-decoration: none;" href="https://phabricator.kde.org/D27160#inline-153549">View Inline</a><span style="color: #4b4d51; font-weight: bold;">ExpandedRepresentation.qml:289</span></div>
<div style="font: 11px/15px "Menlo", "Consolas", "Monaco", monospace; white-space: pre-wrap; clear: both; padding: 4px 0; margin: 0;"><div style="padding: 0 8px; margin: 0 4px; background: rgba(151, 234, 151, .6);"> <span style="color: #aa4000">Layout.fillWidth:</span> <span style="color: #000a65">true</span>
</div><div style="padding: 0 8px; margin: 0 4px; background: rgba(151, 234, 151, .6);"> <span style="color: #aa4000">Layout.maximumWidth:</span> <span style="color: #304a96">Math</span><span class="p">.</span><span style="color: #004012">min</span><span class="p">(</span><span style="color: #601200">800</span><span class="p">,</span> <span style="color: #004012">expandedRepresentation</span><span class="p">.</span><span style="color: #004012">width</span><span style="color: #aa2211">*</span><span class="p">(</span><span style="color: #601200">7</span><span style="color: #aa2211">/</span><span style="color: #601200">10</span><span class="p">))</span>
</div></div></div>
<div style="margin: 8px 0; padding: 0 12px;"><p style="padding: 0; margin: 8px;">No magic numbers, please</p></div></div><br /><div style="border: 1px solid #C7CCD9; border-radius: 3px;"><div style="padding: 0; background: #F7F7F7; border-color: #e3e4e8; border-style: solid; border-width: 0 0 1px 0; margin: 0;"><div style="color: #74777d; background: #eff2f4; padding: 6px 8px; overflow: hidden;"><a style="float: right; text-decoration: none;" href="https://phabricator.kde.org/D27160#inline-153551">View Inline</a><span style="color: #4b4d51; font-weight: bold;">ExpandedRepresentation.qml:306</span></div>
<div style="font: 11px/15px "Menlo", "Consolas", "Monaco", monospace; white-space: pre-wrap; clear: both; padding: 4px 0; margin: 0;"><div style="padding: 0 8px; margin: 0 4px; "> <span style="color: #aa4000">font:</span> <span style="color: #004012">theme</span><span class="p">.</span><span style="color: #004012">smallestFont</span>
</div><div style="padding: 0 8px; margin: 0 4px; background: rgba(151, 234, 151, .6);"> <span style="color: #aa4000">color:</span> <span style="color: #004012">softwareRendering</span> <span style="color: #aa2211">?</span> <span style="color: #aa4000">undefined :</span> <span style="color: #766510">"white"</span>
</div><div style="padding: 0 8px; margin: 0 4px; "> <span class="p">}</span>
</div></div></div>
<div style="margin: 8px 0; padding: 0 12px;"><p style="padding: 0; margin: 8px;">The labels are shown outside the album art, so they are unreadable now</p></div></div></div></div></div><br /><div><strong>REPOSITORY</strong><div><div>R120 Plasma Workspace</div></div></div><br /><div><strong>REVISION DETAIL</strong><div><a href="https://phabricator.kde.org/D27160">https://phabricator.kde.org/D27160</a></div></div><br /><div><strong>To: </strong>cblack, VDG, Plasma, manueljlin<br /><strong>Cc: </strong>broulik, gvgeo, davidedmundson, ngraham, manueljlin, plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, jraleigh, zachus, fbampaloukas, GB_2, ragreen, ZrenBot, alexeymin, himcesjf, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart<br /></div>