<table><tr><td style="">ngraham added a comment.
</td><a style="text-decoration: none; padding: 4px 8px; margin: 0 8px 8px; float: right; color: #464C5C; font-weight: bold; border-radius: 3px; background-color: #F7F7F9; background-image: linear-gradient(to bottom,#fff,#f1f0f1); display: inline-block; border: 1px solid rgba(71,87,120,.2);" href="https://phabricator.kde.org/D26665">View Revision</a></tr></table><br /><div><div><blockquote style="border-left: 3px solid #8C98B8;
color: #6B748C;
font-style: italic;
margin: 4px 0 12px 0;
padding: 8px 12px;
background-color: #F8F9FC;">
<div style="font-style: normal;
padding-bottom: 4px;">In <a href="https://phabricator.kde.org/D26665#601715" style="background-color: #e7e7e7;
border-color: #e7e7e7;
border-radius: 3px;
padding: 0 4px;
font-weight: bold;
color: black;text-decoration: line-through;">D26665#601715</a>, <a href="https://phabricator.kde.org/p/leinir/" style="
border-color: #f1f7ff;
color: #19558d;
background-color: #f1f7ff;
border: 1px solid transparent;
border-radius: 3px;
font-weight: bold;
padding: 0 4px;">@leinir</a> wrote:</div>
<div style="margin: 0;
padding: 0;
border: 0;
color: rgb(107, 116, 140);"><blockquote style="border-left: 3px solid #8C98B8;
color: #6B748C;
font-style: italic;
margin: 4px 0 12px 0;
padding: 8px 12px;
background-color: #F8F9FC;">
<div style="font-style: normal;
padding-bottom: 4px;">In <a href="https://phabricator.kde.org/D26665#601713" style="background-color: #e7e7e7;
border-color: #e7e7e7;
border-radius: 3px;
padding: 0 4px;
font-weight: bold;
color: black;text-decoration: line-through;">D26665#601713</a>, <a href="https://phabricator.kde.org/p/IlyaBizyaev/" style="
border-color: #f1f7ff;
color: #19558d;
background-color: #f1f7ff;
border: 1px solid transparent;
border-radius: 3px;
font-weight: bold;
padding: 0 4px;">@IlyaBizyaev</a> wrote:</div>
<div style="margin: 0;
padding: 0;
border: 0;
color: rgb(107, 116, 140);"><p>What about the "Get New Plugins" button in the same dialog? It still uses the old style.</p></div>
</blockquote>
<p>The reason that wasn't changed in this step is simple - because it isn't simple ;) You'll notice that the change here was very much a trivial swap. Changing the other KNS integration points out for the new one will be considerably more effort, hence it isn't happening just yet.</p></div>
</blockquote>
<p>But now we have three different user interfaces for getting KNS content: 1. Discover 2. old dialog 3. new dialog. This is really kind of non-ideal. I was hoping we could swap out all the old dialogs for the new ones throughout System Settings and Plasma for 5.18. In the long term, I'd like to have <em>one</em> interface for all GHNS stuff, whether it be the new dialog or Discover, or something else. But three is now a regression in our quest for <a href="https://phabricator.kde.org/tag/goal_consistency/" style="background-color: #e7e7e7;
border-color: #e7e7e7;
border-radius: 3px;
padding: 0 4px;
font-weight: bold;
color: black;text-decoration: none;">#goal_consistency</a>. :/</p>
<blockquote style="border-left: 3px solid #8C98B8;
color: #6B748C;
font-style: italic;
margin: 4px 0 12px 0;
padding: 8px 12px;
background-color: #F8F9FC;">
<div style="font-style: normal;
padding-bottom: 4px;">In <a href="https://phabricator.kde.org/D26665#601715" style="background-color: #e7e7e7;
border-color: #e7e7e7;
border-radius: 3px;
padding: 0 4px;
font-weight: bold;
color: black;text-decoration: line-through;">D26665#601715</a>, <a href="https://phabricator.kde.org/p/leinir/" style="
border-color: #f1f7ff;
color: #19558d;
background-color: #f1f7ff;
border: 1px solid transparent;
border-radius: 3px;
font-weight: bold;
padding: 0 4px;">@leinir</a> wrote:</div>
<div style="margin: 0;
padding: 0;
border: 0;
color: rgb(107, 116, 140);"><blockquote style="border-left: 3px solid #8C98B8;
color: #6B748C;
font-style: italic;
margin: 4px 0 12px 0;
padding: 8px 12px;
background-color: #F8F9FC;">
<div style="font-style: normal;
padding-bottom: 4px;">In <a href="https://phabricator.kde.org/D26665#601713" style="background-color: #e7e7e7;
border-color: #e7e7e7;
border-radius: 3px;
padding: 0 4px;
font-weight: bold;
color: black;text-decoration: line-through;">D26665#601713</a>, <a href="https://phabricator.kde.org/p/IlyaBizyaev/" style="
border-color: #f1f7ff;
color: #19558d;
background-color: #f1f7ff;
border: 1px solid transparent;
border-radius: 3px;
font-weight: bold;
padding: 0 4px;">@IlyaBizyaev</a> wrote:</div>
<div style="margin: 0;
padding: 0;
border: 0;
color: rgb(107, 116, 140);"><p>And also, looking at <a href="https://phabricator.kde.org/p/victorr/" style="
border-color: #f1f7ff;
color: #19558d;
background-color: #f1f7ff;
border: 1px solid transparent;
border-radius: 3px;
font-weight: bold;
padding: 0 4px;">@victorr</a>'s screenshot, I see that the "Close" button has no label on it. I got same problem here as well.</p></div>
</blockquote>
<p>That really is a very strange error. Not sure why such a thing would fail. The code in question can be seen here: <a href="https://phabricator.kde.org/source/knewstuff/browse/master/src/qtquick/qml/Dialog.qml$98" class="remarkup-link" target="_blank" rel="noreferrer">https://phabricator.kde.org/source/knewstuff/browse/master/src/qtquick/qml/Dialog.qml$98</a> - However, the whole thing is also being discussed elsewhere, making this the wrong place. Would be good to get more eyes on the situation :) <a href="https://bugs.kde.org/show_bug.cgi?id=413434" class="remarkup-link" target="_blank" rel="noreferrer">https://bugs.kde.org/show_bug.cgi?id=413434</a></p></div>
</blockquote>
<p>Just delete it :)</p></div></div><br /><div><strong>REPOSITORY</strong><div><div>R120 Plasma Workspace</div></div></div><br /><div><strong>REVISION DETAIL</strong><div><a href="https://phabricator.kde.org/D26665">https://phabricator.kde.org/D26665</a></div></div><br /><div><strong>To: </strong>leinir, mart, Plasma, ngraham<br /><strong>Cc: </strong>IlyaBizyaev, victorr, plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, jraleigh, zachus, fbampaloukas, GB_2, ragreen, ZrenBot, ngraham, alexeymin, himcesjf, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart<br /></div>