<table><tr><td style="">apol added inline comments.
</td><a style="text-decoration: none; padding: 4px 8px; margin: 0 8px 8px; float: right; color: #464C5C; font-weight: bold; border-radius: 3px; background-color: #F7F7F9; background-image: linear-gradient(to bottom,#fff,#f1f0f1); display: inline-block; border: 1px solid rgba(71,87,120,.2);" href="https://phabricator.kde.org/D26966">View Revision</a></tr></table><br /><div><strong>INLINE COMMENTS</strong><div><div style="margin: 6px 0 12px 0;"><div style="border: 1px solid #C7CCD9; border-radius: 3px;"><div style="padding: 0; background: #F7F7F7; border-color: #e3e4e8; border-style: solid; border-width: 0 0 1px 0; margin: 0;"><div style="color: #74777d; background: #eff2f4; padding: 6px 8px; overflow: hidden;"><a style="float: right; text-decoration: none;" href="https://phabricator.kde.org/D26966#inline-152534">View Inline</a><span style="color: #4b4d51; font-weight: bold;">breezeshadowhelper.h:157</span></div>
<div style="font: 11px/15px "Menlo", "Consolas", "Monaco", monospace; white-space: pre-wrap; clear: both; padding: 4px 0; margin: 0;"><div style="padding: 0 8px; margin: 0 4px; ">        <span style="color: #74777d">//* managed shadows</span>
</div><div style="padding: 0 8px; margin: 0 4px; background: rgba(251, 175, 175, .7);">        <span class="n">QMap</span><span style="color: #aa2211"><</span><span class="n">QWidget</span><span style="color: #aa2211">*</span><span class="p">,</span> <span class="n">KWindowShadow<span class="bright"></span></span><span class="bright"></span><span style="color: #aa2211"><span class="bright">*</span>></span> <span class="n">_shadows</span><span class="p">;</span>
</div><div style="padding: 0 8px; margin: 0 4px; background: rgba(151, 234, 151, .6);">        <span class="n">QMap</span><span style="color: #aa2211"><</span><span class="n">QWidget</span><span style="color: #aa2211">*</span><span class="p">,</span> <span class="bright"></span><span class="n"><span class="bright">QPointer</span></span><span class="bright"></span><span style="color: #aa2211"><span class="bright"><</span></span><span class="n">KWindowShadow<span class="bright"></span></span><span class="bright"></span><span style="color: #aa2211"><span class="bright">></span>></span> <span class="n">_shadows</span><span class="p">;</span>
</div></div></div>
<div style="margin: 8px 0; padding: 0 12px;"><p style="padding: 0; margin: 8px;">if this is a thing, maybe it would make sense to actually try and remove the KWindowShadows upon destruction?<br />
Something like <tt style="background: #ebebeb; font-size: 13px;">connect(newshadow, &QObject::destroyed,  this, [this, widget] { _shadows.remove(widget); });</tt></p></div></div></div></div></div><br /><div><strong>REPOSITORY</strong><div><div>R31 Breeze</div></div></div><br /><div><strong>REVISION DETAIL</strong><div><a href="https://phabricator.kde.org/D26966">https://phabricator.kde.org/D26966</a></div></div><br /><div><strong>To: </strong>zzag, Plasma, broulik<br /><strong>Cc: </strong>apol, plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, jraleigh, zachus, fbampaloukas, GB_2, ragreen, ZrenBot, ngraham, alexeymin, himcesjf, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, ahiemstra, mart<br /></div>