<table><tr><td style="">mlaurent requested changes to this revision.<br />mlaurent added inline comments.<br />This revision now requires changes to proceed.
</td><a style="text-decoration: none; padding: 4px 8px; margin: 0 8px 8px; float: right; color: #464C5C; font-weight: bold; border-radius: 3px; background-color: #F7F7F9; background-image: linear-gradient(to bottom,#fff,#f1f0f1); display: inline-block; border: 1px solid rgba(71,87,120,.2);" href="https://phabricator.kde.org/D26912">View Revision</a></tr></table><br /><div><strong>INLINE COMMENTS</strong><div><div style="margin: 6px 0 12px 0;"><div style="border: 1px solid #C7CCD9; border-radius: 3px;"><div style="padding: 0; background: #F7F7F7; border-color: #e3e4e8; border-style: solid; border-width: 0 0 1px 0; margin: 0;"><div style="color: #74777d; background: #eff2f4; padding: 6px 8px; overflow: hidden;"><a style="float: right; text-decoration: none;" href="https://phabricator.kde.org/D26912#inline-152209">View Inline</a><span style="color: #4b4d51; font-weight: bold;">addscriptdialog.cpp:39</span></div>
<div style="font: 11px/15px "Menlo", "Consolas", "Monaco", monospace; white-space: pre-wrap; clear: both; padding: 4px 0; margin: 0;"><div style="padding: 0 8px; margin: 0 4px; background: rgba(251, 175, 175, .7);"> <span class="n">QVBoxLayout</span> <span style="color: #aa2211">*</span><span class="n">lay</span><span style="color: #aa2211">=</span> <span style="color: #aa4000">new</span> <span class="n">QVBoxLayout</span><span class="p">;</span>
</div><div style="padding: 0 8px; margin: 0 4px; background: rgba(251, 175, 175, .7);"> <span class="n">setLayout</span><span class="p">(<span class="bright"></span></span><span class="bright"> </span><span class="n"><span class="bright">lay</span></span><span class="bright"> </span><span class="p">);</span>
</div><div style="padding: 0 8px; margin: 0 4px; background: rgba(251, 175, 175, .7);"> <span class="n">QLabel</span> <span style="color: #aa2211">*</span><span class="n">lab</span> <span style="color: #aa2211">=</span> <span style="color: #aa4000">new</span> <span class="n">QLabel</span><span class="p">(<span class="bright"></span></span><span class="bright"> </span><span class="n">i18n</span><span class="p">(<span class="bright"></span></span><span class="bright"> </span><span style="color: #766510">"Shell script path:"<span class="bright"></span></span><span class="bright"> </span><span class="p">),</span> <span style="color: #aa4000">this<span class="bright"></span></span><span class="bright"> </span><span class="p">);</span>
</div><div style="padding: 0 8px; margin: 0 4px; background: rgba(151, 234, 151, .6);"> <span class="n">QVBoxLayout</span> <span style="color: #aa2211">*</span><span class="n">lay<span class="bright"></span></span><span class="bright"> </span><span style="color: #aa2211">=</span> <span style="color: #aa4000">new</span> <span class="n">QVBoxLayout</span><span class="p">;</span>
</div><div style="padding: 0 8px; margin: 0 4px; background: rgba(151, 234, 151, .6);"> <span class="n">setLayout</span><span class="p">(<span class="bright"></span></span><span class="bright"></span><span class="n"><span class="bright">lay</span></span><span class="p">);</span>
</div><div style="padding: 0 8px; margin: 0 4px; background: rgba(151, 234, 151, .6);"> <span class="n">QLabel</span> <span style="color: #aa2211">*</span><span class="n">lab</span> <span style="color: #aa2211">=</span> <span style="color: #aa4000">new</span> <span class="n">QLabel</span><span class="p">(</span><span class="n">i18n</span><span class="p">(</span><span style="color: #766510">"Shell script path:"</span><span class="p">),</span> <span style="color: #aa4000">this</span><span class="p">);</span>
</div></div></div>
<div style="margin: 8px 0; padding: 0 12px;"><p style="padding: 0; margin: 8px;">you can remove this line and adding (this) to new QVBoxLayout<br />
... lay = new QVBoxLayout(this);</p></div></div><br /><div style="border: 1px solid #C7CCD9; border-radius: 3px;"><div style="padding: 0; background: #F7F7F7; border-color: #e3e4e8; border-style: solid; border-width: 0 0 1px 0; margin: 0;"><div style="color: #74777d; background: #eff2f4; padding: 6px 8px; overflow: hidden;"><a style="float: right; text-decoration: none;" href="https://phabricator.kde.org/D26912#inline-152210">View Inline</a><span style="color: #4b4d51; font-weight: bold;">advanceddialog.cpp:39</span></div>
<div style="font: 11px/15px "Menlo", "Consolas", "Monaco", monospace; white-space: pre-wrap; clear: both; padding: 4px 0; margin: 0;"><div style="padding: 0 8px; margin: 0 4px; "> <span class="n">lay</span><span style="color: #aa2211">-></span><span class="n">addWidget</span><span class="p">(</span><span class="n">buttons</span><span class="p">);</span>
</div><div style="padding: 0 8px; margin: 0 4px; background: rgba(251, 175, 175, .7);"> <span class="n">setLayout</span><span class="p">(<span class="bright"></span></span><span class="bright"> </span><span class="n"><span class="bright">lay</span></span><span class="bright"> </span><span class="p">);</span>
</div><div style="padding: 0 8px; margin: 0 4px; background: rgba(151, 234, 151, .6);"> <span class="n">setLayout</span><span class="p">(<span class="bright"></span></span><span class="bright"></span><span class="n"><span class="bright">lay</span></span><span class="p">);</span>
</div></div></div>
<div style="margin: 8px 0; padding: 0 12px;"><p style="padding: 0; margin: 8px;">you can remove this line as we have = new QVBoxLayout(this);</p></div></div><br /><div style="border: 1px solid #C7CCD9; border-radius: 3px;"><div style="padding: 0; background: #F7F7F7; border-color: #e3e4e8; border-style: solid; border-width: 0 0 1px 0; margin: 0;"><div style="color: #74777d; background: #eff2f4; padding: 6px 8px; overflow: hidden;"><a style="float: right; text-decoration: none;" href="https://phabricator.kde.org/D26912#inline-152211">View Inline</a><span style="color: #4b4d51; font-weight: bold;">autostart.cpp:198</span></div>
<div style="font: 11px/15px "Menlo", "Consolas", "Monaco", monospace; white-space: pre-wrap; clear: both; padding: 4px 0; margin: 0;"><div style="padding: 0 8px; margin: 0 4px; background: rgba(251, 175, 175, .7);"> <span style="color: #aa4000">for</span> <span class="p">(<span class="bright"></span></span><span class="bright"></span><span style="color: #aa4000"><span class="bright">int</span></span><span class="bright"> </span><span class="n"><span class="bright">i</span></span><span class="bright"> </span><span style="color: #aa2211"><span class="bright">=</span></span><span class="bright"> </span><span style="color: #601200"><span class="bright">0</span></span><span class="bright"></span><span class="p"><span class="bright">;</span></span><span class="bright"> </span><span class="n"><span class="bright">i</span></span><span class="bright"> </span><span style="color: #aa2211"><span class="bright"><</span></span><span class="bright"> </span><span class="n"><span class="bright">list</span></span><span class="bright"></span><span class="p"><span class="bright">.</span></span><span class="bright"></span><span class="n"><span class="bright">size</span></span><span class="bright"></span><span class="p"><span class="bright">();</span></span><span class="bright"> </span><span style="color: #aa2211"><span class="bright">++</span></span><span class="bright"></span><span class="n"><span class="bright">i</span></span><span class="p">)</span> <span class="p">{</span>
</div><div style="padding: 0 8px; margin: 0 4px; background: rgba(251, 175, 175, .7);"> <span class="bright"></span><span class="n"><span class="bright">QFileInfo</span></span><span class="bright"> </span><span class="n"><span class="bright">fi</span></span><span class="bright"> </span><span style="color: #aa2211"><span class="bright">=</span></span><span class="bright"> </span><span class="n"><span class="bright">list</span></span><span class="bright"></span><span class="p"><span class="bright">.</span></span><span class="bright"></span><span class="n"><span class="bright">at</span></span><span class="bright"></span><span class="p"><span class="bright">(</span></span><span class="bright"></span><span class="n"><span class="bright">i</span></span><span class="p">);</span>
</div><div style="padding: 0 8px; margin: 0 4px; background: rgba(151, 234, 151, .6);"> <span style="color: #aa4000">for</span> <span class="p">(<span class="bright"></span></span><span class="bright"></span><span style="color: #aa4000"><span class="bright">const</span></span><span class="bright"> </span><span class="n"><span class="bright">QFileInfo</span></span><span class="bright"> </span><span style="color: #aa2211"><span class="bright">&</span></span><span class="bright"></span><span style="color: #a0a000"><span class="bright">fi</span></span><span class="bright"> </span><span class="p"><span class="bright">:</span></span><span class="bright"> </span><span class="n"><span class="bright">autostartdir</span></span><span class="bright"></span><span class="p"><span class="bright">.</span></span><span class="bright"></span><span class="n"><span class="bright">entryInfoList</span></span><span class="bright"></span><span class="p"><span class="bright">()</span>)</span> <span class="p">{</span>
</div><div style="padding: 0 8px; margin: 0 4px; background: rgba(151, 234, 151, .6);"> <span class="bright"></span><span style="color: #aa4000"><span class="bright">const</span></span><span class="bright"> </span><span class="n"><span class="bright">QString</span></span><span class="bright"> </span><span class="n"><span class="bright">filename</span></span><span class="bright"> </span><span style="color: #aa2211"><span class="bright">=</span></span><span class="bright"> </span><span class="n"><span class="bright">fi</span></span><span class="bright"></span><span class="p"><span class="bright">.</span></span><span class="bright"></span><span class="n"><span class="bright">fileName</span></span><span class="bright"></span><span class="p"><span class="bright">(</span>);</span>
</div></div></div>
<div style="margin: 8px 0; padding: 0 12px;"><p style="padding: 0; margin: 8px;">you must use qAsConst(...)</p>
<h2 class="remarkup-header">> const auto var = autostartdir.entryInfoList();</h2>
<p style="padding: 0; margin: 8px;">for (const ... : var) {<br />
}</p></div></div><br /><div style="border: 1px solid #C7CCD9; border-radius: 3px;"><div style="padding: 0; background: #F7F7F7; border-color: #e3e4e8; border-style: solid; border-width: 0 0 1px 0; margin: 0;"><div style="color: #74777d; background: #eff2f4; padding: 6px 8px; overflow: hidden;"><a style="float: right; text-decoration: none;" href="https://phabricator.kde.org/D26912#inline-152212">View Inline</a><span style="color: #4b4d51; font-weight: bold;">autostart.cpp:244</span></div>
<div style="font: 11px/15px "Menlo", "Consolas", "Monaco", monospace; white-space: pre-wrap; clear: both; padding: 4px 0; margin: 0;"><div style="padding: 0 8px; margin: 0 4px; background: rgba(251, 175, 175, .7);"> <span class="n">ScriptStartItem</span> <span style="color: #aa2211">*</span><span class="n">item</span> <span style="color: #aa2211">=</span> <span style="color: #aa4000">new</span> <span class="n">ScriptStartItem</span><span class="p">(<span class="bright"></span></span><span class="bright"> </span><span class="n">fi</span><span class="p">.</span><span class="n">absoluteFilePath</span><span class="p">(),</span> <span class="n">m_scriptItem</span><span class="p">,</span><span style="color: #aa4000">this<span class="bright"></span></span><span class="bright"> </span><span class="p">);</span>
</div><div style="padding: 0 8px; margin: 0 4px; background: rgba(151, 234, 151, .6);"> <span style="color: #aa4000">for</span> <span class="p">(</span><span style="color: #aa4000">const</span> <span class="n">QFileInfo</span> <span style="color: #aa2211">&</span><span style="color: #a0a000">fi</span> <span class="p">:</span> <span class="n">autostartdir</span><span class="p">.</span><span class="n">entryInfoList</span><span class="p">())</span> <span class="p">{</span>
</div><div style="padding: 0 8px; margin: 0 4px; background: rgba(151, 234, 151, .6);"> <span class="n">ScriptStartItem</span> <span style="color: #aa2211">*</span><span class="n">item</span> <span style="color: #aa2211">=</span> <span style="color: #aa4000">new</span> <span class="n">ScriptStartItem</span><span class="p">(</span><span class="n">fi</span><span class="p">.</span><span class="n">absoluteFilePath</span><span class="p">(),</span> <span class="n">m_scriptItem</span><span class="p">,<span class="bright"></span></span><span class="bright"> </span><span style="color: #aa4000">this</span><span class="p">);</span>
</div></div></div>
<div style="margin: 8px 0; padding: 0 12px;"><p style="padding: 0; margin: 8px;">same here</p></div></div><br /><div style="border: 1px solid #C7CCD9; border-radius: 3px;"><div style="padding: 0; background: #F7F7F7; border-color: #e3e4e8; border-style: solid; border-width: 0 0 1px 0; margin: 0;"><div style="color: #74777d; background: #eff2f4; padding: 6px 8px; overflow: hidden;"><a style="float: right; text-decoration: none;" href="https://phabricator.kde.org/D26912#inline-152213">View Inline</a><span style="color: #4b4d51; font-weight: bold;">autostart.cpp:408</span></div>
<div style="font: 11px/15px "Menlo", "Consolas", "Monaco", monospace; white-space: pre-wrap; clear: both; padding: 4px 0; margin: 0;"><div style="padding: 0 8px; margin: 0 4px; "><span class="p">{</span>
</div><div style="padding: 0 8px; margin: 0 4px; background: rgba(251, 175, 175, .7);"> <span style="color: #aa4000">if</span> <span class="p">(<span class="bright"></span></span><span class="bright"> </span><span class="n">widget</span><span style="color: #aa2211">-></span><span class="n">listCMD</span><span style="color: #aa2211">-></span><span class="n">currentItem</span><span class="p">()</span> <span style="color: #aa2211">==</span> <span style="color: #aa4000">nullptr<span class="bright"></span></span><span class="bright"> </span><span class="p"><span class="bright">)</span></span>
</div><div style="padding: 0 8px; margin: 0 4px; background: rgba(151, 234, 151, .6);"> <span style="color: #aa4000">if</span> <span class="p">(</span><span class="n">widget</span><span style="color: #aa2211">-></span><span class="n">listCMD</span><span style="color: #aa2211">-></span><span class="n">currentItem</span><span class="p">()</span> <span style="color: #aa2211">==</span> <span style="color: #aa4000">nullptr<span class="bright"></span></span><span class="bright"></span><span class="p"><span class="bright">)</span></span><span class="bright"> </span><span class="p"><span class="bright">{</span></span>
</div><div style="padding: 0 8px; margin: 0 4px; "> <span style="color: #aa4000">return</span><span class="p">;</span>
</div></div></div>
<div style="margin: 8px 0; padding: 0 12px;"><p style="padding: 0; margin: 8px;">if (!widget...) {<br />
}</p></div></div></div></div></div><br /><div><strong>REPOSITORY</strong><div><div>R119 Plasma Desktop</div></div></div><br /><div><strong>REVISION DETAIL</strong><div><a href="https://phabricator.kde.org/D26912">https://phabricator.kde.org/D26912</a></div></div><br /><div><strong>To: </strong>alex, mlaurent, davidedmundson<br /><strong>Cc: </strong>plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, jraleigh, zachus, fbampaloukas, GB_2, ragreen, ZrenBot, ngraham, alexeymin, himcesjf, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart<br /></div>