<table><tr><td style="">ngraham requested changes to this revision.<br />ngraham added a comment.<br />This revision now requires changes to proceed.
</td><a style="text-decoration: none; padding: 4px 8px; margin: 0 8px 8px; float: right; color: #464C5C; font-weight: bold; border-radius: 3px; background-color: #F7F7F9; background-image: linear-gradient(to bottom,#fff,#f1f0f1); display: inline-block; border: 1px solid rgba(71,87,120,.2);" href="https://phabricator.kde.org/D25273">View Revision</a></tr></table><br /><div><div><p>Bad combobox width strikes again (<a href="https://bugs.kde.org/show_bug.cgi?id=403153" class="remarkup-link" target="_blank" rel="noreferrer">https://bugs.kde.org/show_bug.cgi?id=403153</a>), worsened by adding an icon:</p>

<p><a href="https://phabricator.kde.org/F7939162" style="background-color: #e7e7e7;
          border-color: #e7e7e7;
          border-radius: 3px;
          padding: 0 4px;
          font-weight: bold;
          color: black;text-decoration: none;">F7939162: Screenshot_20200124_204922.PNG</a></p>

<p>Also, gross, there are duplicates</p></div></div><br /><div><strong>INLINE COMMENTS</strong><div><div style="margin: 6px 0 12px 0;"><div style="border: 1px solid #C7CCD9; border-radius: 3px;"><div style="padding: 0; background: #F7F7F7; border-color: #e3e4e8; border-style: solid; border-width: 0 0 1px 0; margin: 0;"><div style="color: #74777d; background: #eff2f4; padding: 6px 8px; overflow: hidden;"><a style="float: right; text-decoration: none;" href="https://phabricator.kde.org/D25273#inline-152196">View Inline</a><span style="color: #4b4d51; font-weight: bold;">main.cpp:139</span></div>
<div style="font: 11px/15px "Menlo", "Consolas", "Monaco", monospace; white-space: pre-wrap; clear: both; padding: 4px 0; margin: 0;"><div style="padding: 0 8px; margin: 0 4px; ">    <span class="n">qmlRegisterAnonymousType</span><span style="color: #aa2211"><</span><span class="n">CuttleFish</span><span style="color: #aa2211">::</span><span class="n">IconModel</span><span style="color: #aa2211">></span><span class="p">(</span><span style="color: #766510">"org.kde.plasma.sdk"</span><span class="p">,</span> <span style="color: #601200">1</span><span class="p">);</span>
</div><div style="padding: 0 8px; margin: 0 4px; background: rgba(151, 234, 151, .6);">    <span class="n">qmlRegisterAonymousType</span><span style="color: #aa2211"><</span><span class="n">CuttleFish</span><span style="color: #aa2211">::</span><span class="n">ColorSchemes</span><span style="color: #aa2211">></span><span class="p">(</span><span style="color: #766510">"org.kde.plasma.sdk"</span><span class="p">,</span> <span style="color: #601200">1</span><span class="p">);</span>
</div><div style="padding: 0 8px; margin: 0 4px; "><span style="color: #304a96">#endif</span>
</div></div></div>
<div style="margin: 8px 0; padding: 0 12px;"><p style="padding: 0; margin: 8px;">typo causes a build failure</p></div></div></div></div></div><br /><div><strong>REPOSITORY</strong><div><div>R118 Plasma SDK</div></div></div><br /><div><strong>REVISION DETAIL</strong><div><a href="https://phabricator.kde.org/D25273">https://phabricator.kde.org/D25273</a></div></div><br /><div><strong>To: </strong>davidre, Plasma, ngraham<br /><strong>Cc: </strong>ngraham, plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, jraleigh, zachus, fbampaloukas, GB_2, ragreen, ZrenBot, alexeymin, himcesjf, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart<br /></div>