<table><tr><td style="">Zren added inline comments.
</td><a style="text-decoration: none; padding: 4px 8px; margin: 0 8px 8px; float: right; color: #464C5C; font-weight: bold; border-radius: 3px; background-color: #F7F7F9; background-image: linear-gradient(to bottom,#fff,#f1f0f1); display: inline-block; border: 1px solid rgba(71,87,120,.2);" href="https://phabricator.kde.org/D26681">View Revision</a></tr></table><br /><div><strong>INLINE COMMENTS</strong><div><div style="margin: 6px 0 12px 0;"><div style="border: 1px solid #C7CCD9; border-radius: 3px;"><div style="padding: 0; background: #F7F7F7; border-color: #e3e4e8; border-style: solid; border-width: 0 0 1px 0; margin: 0;"><div style="color: #74777d; background: #eff2f4; padding: 6px 8px; overflow: hidden;"><a style="float: right; text-decoration: none;" href="https://phabricator.kde.org/D26681#inline-150694">View Inline</a><span style="color: #4b4d51; font-weight: bold;">davidedmundson</span> wrote in <span style="color: #4b4d51; font-weight: bold;">main.qml:183</span></div>
<div style="margin: 8px 0; padding: 0 12px; color: #74777D;"><p style="padding: 0; margin: 8px;">you can use Layout.preferredWidth</p>
<p style="padding: 0; margin: 8px;">One shouldn't specifiy a width/height from an item inside a layout</p></div></div>
<div style="margin: 8px 0; padding: 0 12px;"><p style="padding: 0; margin: 8px;">Uhg, I was using <tt style="background: #ebebeb; font-size: 13px;">width: parent.height</tt> and <tt style="background: #ebebeb; font-size: 13px;">height: parent.height</tt> but changed it when cleaning it up. I must've not staged all the changes before diffing. This has made me notice another bug though.</p>
<p style="padding: 0; margin: 8px;">By using <tt style="background: #ebebeb; font-size: 13px;">height: parent.height</tt>, I was basically setting it at <tt style="background: #ebebeb; font-size: 13px;">height: 22</tt>, which is smaller than the "close button" which is 30x30.</p>
<div class="remarkup-code-block" style="margin: 12px 0;" data-code-lang="text" data-sigil="remarkup-code-block"><pre class="remarkup-code" style="font: 11px/15px "Menlo", "Consolas", "Monaco", monospace; padding: 12px; margin: 0; background: rgba(71, 87, 120, 0.08);">width: parent.height
height: parent.height</pre></div>
<p style="padding: 0; margin: 8px;"><a href="https://phabricator.kde.org/F7884740" style="background-color: #e7e7e7;
border-color: #e7e7e7;
border-radius: 3px;
padding: 0 4px;
font-weight: bold;
color: black;text-decoration: none;">F7884740: 2020-01-15___12-05-59.png</a></p>
<div class="remarkup-code-block" style="margin: 12px 0;" data-code-lang="text" data-sigil="remarkup-code-block"><pre class="remarkup-code" style="font: 11px/15px "Menlo", "Consolas", "Monaco", monospace; padding: 12px; margin: 0; background: rgba(71, 87, 120, 0.08);">Layout.fillHeight: true
Layout.minimumWidth: height
Layout.maximumWidth: Layout.minimumWidth</pre></div>
<p style="padding: 0; margin: 8px;">This makes the icon slightly larger than I'm used to.<br />
<a href="https://phabricator.kde.org/F7884741" style="background-color: #e7e7e7;
border-color: #e7e7e7;
border-radius: 3px;
padding: 0 4px;
font-weight: bold;
color: black;text-decoration: none;">F7884741: 2020-01-15___12-04-32.png</a></p>
<p style="padding: 0; margin: 8px;">I've also noticed why I added <tt style="background: #ebebeb; font-size: 13px;">clip: true</tt> to the <tt style="background: #ebebeb; font-size: 13px;">KWin.ThumbnailItem</tt>, apparently the close button is 30x30, which is taller than the <tt style="background: #ebebeb; font-size: 13px;">captionRow.height: 22</tt>. Here's a look at the overflow after removing <tt style="background: #ebebeb; font-size: 13px;">clip: true</tt> and <tt style="background: #ebebeb; font-size: 13px;">clipTo: parent</tt>:<br />
Outlines with: <tt style="background: #ebebeb; font-size: 13px;">Rectangle { anchors.fill: parent; border.color: "#f00"; border.width: 1; color: "transparent" }</tt><br />
<a href="https://phabricator.kde.org/F7884784" style="background-color: #e7e7e7;
border-color: #e7e7e7;
border-radius: 3px;
padding: 0 4px;
font-weight: bold;
color: black;text-decoration: none;">F7884784: 2020-01-15___12-31-12.png</a></p>
<p style="padding: 0; margin: 8px;">I've fixed it all in the latest diff:<br />
<a href="https://phabricator.kde.org/F7884833" style="background-color: #e7e7e7;
border-color: #e7e7e7;
border-radius: 3px;
padding: 0 4px;
font-weight: bold;
color: black;text-decoration: none;">F7884833: 2020-01-15___12-38-31.png</a><br />
<a href="https://phabricator.kde.org/F7884834" style="background-color: #e7e7e7;
border-color: #e7e7e7;
border-radius: 3px;
padding: 0 4px;
font-weight: bold;
color: black;text-decoration: none;">F7884834: 2020-01-15___12-55-01.png</a></p></div></div><br /><div style="border: 1px solid #C7CCD9; border-radius: 3px;"><div style="padding: 0; background: #F7F7F7; border-color: #e3e4e8; border-style: solid; border-width: 0 0 1px 0; margin: 0;"><div style="color: #74777d; background: #eff2f4; padding: 6px 8px; overflow: hidden;"><a style="float: right; text-decoration: none;" href="https://phabricator.kde.org/D26681#inline-150696">View Inline</a><span style="color: #4b4d51; font-weight: bold;">davidedmundson</span> wrote in <span style="color: #4b4d51; font-weight: bold;">main.qml:231</span></div>
<div style="margin: 8px 0; padding: 0 12px; color: #74777D;"><p style="padding: 0; margin: 8px;">GridView has it's own input handling you shouldn't need this anyway.</p>
<p style="padding: 0; margin: 8px;">If keyboard doesn't work, chances are your activeFocus is incorrect.</p>
<p style="padding: 0; margin: 8px;">I can only see focus: true on</p>
<div class="remarkup-code-block" style="margin: 12px 0;" data-code-lang="text" data-sigil="remarkup-code-block"><pre class="remarkup-code" style="font: 11px/15px "Menlo", "Consolas", "Monaco", monospace; padding: 12px; margin: 0; background: rgba(71, 87, 120, 0.08);">id: dialogMainItem</pre></div>
<p style="padding: 0; margin: 8px;">it should be on the gridview instead</p></div></div>
<div style="margin: 8px 0; padding: 0 12px;"><p style="padding: 0; margin: 8px;">Arrow keys work. Sorry, forgot to this comment.</p></div></div></div></div></div><br /><div><strong>REPOSITORY</strong><div><div>R114 Plasma Addons</div></div></div><br /><div><strong>REVISION DETAIL</strong><div><a href="https://phabricator.kde.org/D26681">https://phabricator.kde.org/D26681</a></div></div><br /><div><strong>To: </strong>Zren, romangg, Plasma<br /><strong>Cc: </strong>zzag, davidedmundson, romangg, plasma-devel, LeGast00n, The-Feren-OS-Dev, jraleigh, zachus, fbampaloukas, GB_2, ragreen, ZrenBot, ngraham, alexeymin, himcesjf, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart<br /></div>