<table><tr><td style="">ngraham added inline comments.
</td><a style="text-decoration: none; padding: 4px 8px; margin: 0 8px 8px; float: right; color: #464C5C; font-weight: bold; border-radius: 3px; background-color: #F7F7F9; background-image: linear-gradient(to bottom,#fff,#f1f0f1); display: inline-block; border: 1px solid rgba(71,87,120,.2);" href="https://phabricator.kde.org/D22176">View Revision</a></tr></table><br /><div><strong>INLINE COMMENTS</strong><div><div style="margin: 6px 0 12px 0;"><div style="border: 1px solid #C7CCD9; border-radius: 3px;"><div style="padding: 0; background: #F7F7F7; border-color: #e3e4e8; border-style: solid; border-width: 0 0 1px 0; margin: 0;"><div style="color: #74777d; background: #eff2f4; padding: 6px 8px; overflow: hidden;"><a style="float: right; text-decoration: none;" href="https://phabricator.kde.org/D22176#inline-150390">View Inline</a><span style="color: #4b4d51; font-weight: bold;">ConfigGeneral.qml:23</span></div>
<div style="font: 11px/15px "Menlo", "Consolas", "Monaco", monospace; white-space: pre-wrap; clear: both; padding: 4px 0; margin: 0;"><div style="padding: 0 8px; margin: 0 4px; background: rgba(251, 175, 175, .7);"><span style="color: #304a96">import</span> <span style="color: #004012">QtQuick</span> <span style="color: #601200">2.<span class="bright">0</span></span>
</div><div style="padding: 0 8px; margin: 0 4px; background: rgba(251, 175, 175, .7);"><span style="color: #304a96">import</span> <span style="color: #004012">QtQuick</span><span class="p">.</span><span style="color: #004012">Controls</span> <span class="bright"></span><span style="color: #601200"><span class="bright">2.3</span></span> <span style="color: #004012">as</span> <span style="color: #004012">Q<span class="bright">tControls</span></span>
</div><div style="padding: 0 8px; margin: 0 4px; background: rgba(251, 175, 175, .7);"><span style="color: #304a96">import</span> <span style="color: #004012">QtQuick</span><span class="p">.<span class="bright"></span></span><span class="bright"></span><span style="color: #004012"><span class="bright">Layouts</span></span><span class="bright"> </span><span style="color: #601200"><span class="bright">1.0</span></span> <span style="color: #004012">as</span> <span style="color: #004012">Q<span class="bright">tLayouts</span></span>
</div><div style="padding: 0 8px; margin: 0 4px; background: rgba(151, 234, 151, .6);"><span style="color: #304a96">import</span> <span style="color: #004012">QtQuick</span> <span style="color: #601200">2.<span class="bright">5</span></span>
</div><div style="padding: 0 8px; margin: 0 4px; background: rgba(151, 234, 151, .6);"><span style="color: #304a96">import</span> <span style="color: #004012">QtQuick</span><span class="p">.</span><span style="color: #004012">Controls</span> <span class="bright"></span><span style="color: #601200"><span class="bright">1.4</span></span> <span style="color: #004012">as</span> <span style="color: #004012">Q<span class="bright">QC1</span></span>
</div><div style="padding: 0 8px; margin: 0 4px; background: rgba(151, 234, 151, .6);"><span style="color: #304a96">import</span> <span style="color: #004012">QtQuick</span><span class="p">.<span class="bright"></span></span><span class="bright"></span><span style="color: #004012"><span class="bright">Controls</span></span><span class="bright"> </span><span style="color: #601200"><span class="bright">2.5</span></span> <span style="color: #004012">as</span> <span style="color: #004012">Q<span class="bright">QC2</span></span>
</div></div></div>
<div style="margin: 8px 0; padding: 0 12px;"><p style="padding: 0; margin: 8px;">there are no longer any QQC1 items here; you can remove this import entirely</p></div></div><br /><div style="border: 1px solid #C7CCD9; border-radius: 3px;"><div style="padding: 0; background: #F7F7F7; border-color: #e3e4e8; border-style: solid; border-width: 0 0 1px 0; margin: 0;"><div style="color: #74777d; background: #eff2f4; padding: 6px 8px; overflow: hidden;"><a style="float: right; text-decoration: none;" href="https://phabricator.kde.org/D22176#inline-150386">View Inline</a><span style="color: #4b4d51; font-weight: bold;">ConfigGeneral.qml:65</span></div>
<div style="font: 11px/15px "Menlo", "Consolas", "Monaco", monospace; white-space: pre-wrap; clear: both; padding: 4px 0; margin: 0;"><div style="padding: 0 8px; margin: 0 4px; background: rgba(151, 234, 151, .6);"> <span style="color: #aa4000">Layout.fillWidth:</span> <span style="color: #000a65">true</span>
</div><div style="padding: 0 8px; margin: 0 4px; background: rgba(151, 234, 151, .6);"> <span style="color: #aa4000">Layout.fillHeight:</span> <span style="color: #000a65">true</span>
</div></div></div>
<div style="margin: 8px 0; padding: 0 12px;"><p style="padding: 0; margin: 8px;">These have no effect because the ListView isn't in a layout; you can just remove them</p></div></div><br /><div style="border: 1px solid #C7CCD9; border-radius: 3px;"><div style="padding: 0; background: #F7F7F7; border-color: #e3e4e8; border-style: solid; border-width: 0 0 1px 0; margin: 0;"><div style="color: #74777d; background: #eff2f4; padding: 6px 8px; overflow: hidden;"><a style="float: right; text-decoration: none;" href="https://phabricator.kde.org/D22176#inline-150387">View Inline</a><span style="color: #4b4d51; font-weight: bold;">ConfigGeneral.qml:86</span></div>
<div style="font: 11px/15px "Menlo", "Consolas", "Monaco", monospace; white-space: pre-wrap; clear: both; padding: 4px 0; margin: 0;"><div style="padding: 0 8px; margin: 0 4px; background: rgba(151, 234, 151, .6);"> <span style="color: #004012">QIconItem</span> <span class="p">{</span>
</div><div style="padding: 0 8px; margin: 0 4px; background: rgba(151, 234, 151, .6);"> <span style="color: #aa4000">id: theIcon</span>
</div></div></div>
<div style="margin: 8px 0; padding: 0 12px;"><p style="padding: 0; margin: 8px;">Use a <tt style="background: #ebebeb; font-size: 13px;">Kirigami.Icon</tt> instead as it has better scaling behavior</p></div></div><br /><div style="border: 1px solid #C7CCD9; border-radius: 3px;"><div style="padding: 0; background: #F7F7F7; border-color: #e3e4e8; border-style: solid; border-width: 0 0 1px 0; margin: 0;"><div style="color: #74777d; background: #eff2f4; padding: 6px 8px; overflow: hidden;"><a style="float: right; text-decoration: none;" href="https://phabricator.kde.org/D22176#inline-150389">View Inline</a><span style="color: #4b4d51; font-weight: bold;">ConfigGeneral.qml:101</span></div>
<div style="font: 11px/15px "Menlo", "Consolas", "Monaco", monospace; white-space: pre-wrap; clear: both; padding: 4px 0; margin: 0;"><div style="padding: 0 8px; margin: 0 4px; background: rgba(151, 234, 151, .6);"> <span style="color: #aa4000">enabled:</span> <span style="color: #aa2211">!</span><span style="color: #004012">showAllCheckBox</span><span class="p">.</span><span style="color: #004012">checked</span>
</div><div style="padding: 0 8px; margin: 0 4px; background: rgba(151, 234, 151, .6);"> <span style="color: #aa4000">model:</span> <span style="color: #004012">isPlasmoid</span> <span style="color: #aa2211">?</span> <span class="p">[</span><span style="color: #004012">i18n</span><span class="p">(</span><span style="color: #766510">"Auto"</span><span class="p">),</span> <span style="color: #004012">i18n</span><span class="p">(</span><span style="color: #766510">"Shown"</span><span class="p">),</span> <span style="color: #004012">i18n</span><span class="p">(</span><span style="color: #766510">"Hidden"</span><span class="p">),</span> <span style="color: #004012">i18n</span><span class="p">(</span><span style="color: #766510">"Disabled"</span><span class="p">)]</span> <span style="color: #aa2211">:</span> <span class="p">[</span><span style="color: #004012">i18n</span><span class="p">(</span><span style="color: #766510">"Auto"</span><span class="p">),</span> <span style="color: #004012">i18n</span><span class="p">(</span><span style="color: #766510">"Shown"</span><span class="p">),</span> <span style="color: #004012">i18n</span><span class="p">(</span><span style="color: #766510">"Hidden"</span><span class="p">)]</span>
</div></div></div>
<div style="margin: 8px 0; padding: 0 12px;"><p style="padding: 0; margin: 8px;">Might be cleaner to set up the combobox model like so: <a href="https://cgit.kde.org/kdeplasma-addons.git/tree/wallpapers/potd/contents/ui/config.qml#n82" class="remarkup-link" target="_blank" rel="noreferrer">https://cgit.kde.org/kdeplasma-addons.git/tree/wallpapers/potd/contents/ui/config.qml#n82</a>, and then you could simplify <tt style="background: #ebebeb; font-size: 13px;">currentIndex</tt> and <tt style="background: #ebebeb; font-size: 13px;">onActivated</tt> a lot</p></div></div></div></div></div><br /><div><strong>REPOSITORY</strong><div><div>R120 Plasma Workspace</div></div></div><br /><div><strong>REVISION DETAIL</strong><div><a href="https://phabricator.kde.org/D22176">https://phabricator.kde.org/D22176</a></div></div><br /><div><strong>To: </strong>nicolasfella, Plasma, VDG<br /><strong>Cc: </strong>kmaterka, filipf, broulik, ngraham, plasma-devel, LeGast00n, The-Feren-OS-Dev, jraleigh, zachus, fbampaloukas, GB_2, ragreen, ZrenBot, alexeymin, himcesjf, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart<br /></div>