<table><tr><td style="">tcanabrava updated this revision to Diff 73274.<br />tcanabrava marked 16 inline comments as done.<br />tcanabrava added a comment.
</td><a style="text-decoration: none; padding: 4px 8px; margin: 0 8px 8px; float: right; color: #464C5C; font-weight: bold; border-radius: 3px; background-color: #F7F7F9; background-image: linear-gradient(to bottom,#fff,#f1f0f1); display: inline-block; border: 1px solid rgba(71,87,120,.2);" href="https://phabricator.kde.org/D25375">View Revision</a></tr></table><br /><div><div><ul class="remarkup-list">
<li class="remarkup-list-item">ListElement does not handle i18n calls, use raw array</li>
<li class="remarkup-list-item">Dont complain about null background - Failing on Qt 5.14</li>
<li class="remarkup-list-item">Add Key entries to the kconfigxt generator</li>
<li class="remarkup-list-item">ArtsBell* -> CustomBell*</li>
<li class="remarkup-list-item">kModifiers* -> KeyboardModifiers*</li>
<li class="remarkup-list-item">Rename mouse settings</li>
<li class="remarkup-list-item">Remove deprecated call</li>
<li class="remarkup-list-item">Fix nitpicks</li>
<li class="remarkup-list-item">Fix Qml Style</li>
<li class="remarkup-list-item">Use QFileDialog to look for audio files</li>
<li class="remarkup-list-item">Fix Binary checks</li>
<li class="remarkup-list-item">Mark as Q_INVOKABLE, not Q_SCRIPTABLE</li>
<li class="remarkup-list-item">Use QtQuick Dialogs for the audio file</li>
<li class="remarkup-list-item">Fix orca calls</li>
<li class="remarkup-list-item">Use Label instead of placeholder text</li>
<li class="remarkup-list-item">Fix icon & text for search audio files</li>
<li class="remarkup-list-item">Fix Triggers</li>
<li class="remarkup-list-item">Trigger orcaInstalled() only when entering ScreenReader</li>
<li class="remarkup-list-item">Add explanation for magic number</li>
<li class="remarkup-list-item">Add transient window for the KNofityConfigWidget dialog</li>
<li class="remarkup-list-item">Fix KConfig Misuse</li>
<li class="remarkup-list-item">Explain property</li>
<li class="remarkup-list-item">Audible Bell Layout</li>
<li class="remarkup-list-item">Add string context</li>
</ul></div></div><br /><div><strong>REPOSITORY</strong><div><div>R119 Plasma Desktop</div></div></div><br /><div><strong>CHANGES SINCE LAST UPDATE</strong><div><a href="https://phabricator.kde.org/D25375?vs=73058&id=73274">https://phabricator.kde.org/D25375?vs=73058&id=73274</a></div></div><br /><div><strong>BRANCH</strong><div><div>arcpatch-D25375</div></div></div><br /><div><strong>REVISION DETAIL</strong><div><a href="https://phabricator.kde.org/D25375">https://phabricator.kde.org/D25375</a></div></div><br /><div><strong>AFFECTED FILES</strong><div><div>kcms/access/CMakeLists.txt<br />
kcms/access/accessibility.ui<br />
kcms/access/kcmaccess.cpp<br />
kcms/access/kcmaccess.desktop<br />
kcms/access/kcmaccess.h<br />
kcms/access/kcmaccessibilitybell.kcfg<br />
kcms/access/kcmaccessibilitybell.kcfgc<br />
kcms/access/kcmaccessibilitykeyboard.kcfg<br />
kcms/access/kcmaccessibilitykeyboard.kcfgc<br />
kcms/access/kcmaccessibilitymouse.kcfg<br />
kcms/access/kcmaccessibilitymouse.kcfgc<br />
kcms/access/kcmaccessibilityscreenreader.kcfg<br />
kcms/access/kcmaccessibilityscreenreader.kcfgc<br />
kcms/access/package/contents/ui/Bell.qml<br />
kcms/access/package/contents/ui/KeyboardFilters.qml<br />
kcms/access/package/contents/ui/ModifierKeys.qml<br />
kcms/access/package/contents/ui/MouseNavigation.qml<br />
kcms/access/package/contents/ui/ScreenReader.qml<br />
kcms/access/package/contents/ui/main.qml<br />
kcms/access/package/metadata.desktop</div></div></div><br /><div><strong>To: </strong>tcanabrava, ngraham, ervin<br /><strong>Cc: </strong>broulik, cblack, ervin, ognarb, mart, ngraham, plasma-devel, LeGast00n, The-Feren-OS-Dev, jraleigh, zachus, fbampaloukas, GB_2, ragreen, ZrenBot, alexeymin, himcesjf, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra<br /></div>