<table><tr><td style="">acooligan added a comment.
</td><a style="text-decoration: none; padding: 4px 8px; margin: 0 8px 8px; float: right; color: #464C5C; font-weight: bold; border-radius: 3px; background-color: #F7F7F9; background-image: linear-gradient(to bottom,#fff,#f1f0f1); display: inline-block; border: 1px solid rgba(71,87,120,.2);" href="https://phabricator.kde.org/D26185">View Revision</a></tr></table><br /><div><div><p>I think you may leave ifdef here but set:</p>
<div class="remarkup-code-block" style="margin: 12px 0;" data-code-lang="text" data-sigil="remarkup-code-block"><pre class="remarkup-code" style="font: 11px/15px "Menlo", "Consolas", "Monaco", monospace; padding: 12px; margin: 0; background: rgba(71, 87, 120, 0.08);">qputenv("QT_ENABLE_HIGHDPI_SCALING", "0");</pre></div>
<p>if it's false as <tt style="background: #ebebeb; font-size: 13px;">QT_AUTO_SCREEN_SCALE_FACTOR</tt> is deprecated since qt 5.14.</p>
<blockquote style="border-left: 3px solid #8C98B8;
color: #6B748C;
font-style: italic;
margin: 4px 0 12px 0;
padding: 8px 12px;
background-color: #F8F9FC;">
<div style="font-style: normal;
padding-bottom: 4px;">In <a href="https://phabricator.kde.org/D26185#582742" style="background-color: #e7e7e7;
border-color: #e7e7e7;
border-radius: 3px;
padding: 0 4px;
font-weight: bold;
color: black;text-decoration: none;">D26185#582742</a>, <a href="https://phabricator.kde.org/p/davidedmundson/" style="
border-color: #f1f7ff;
color: #19558d;
background-color: #f1f7ff;
border: 1px solid transparent;
border-radius: 3px;
font-weight: bold;
padding: 0 4px;">@davidedmundson</a> wrote:</div>
<div style="margin: 0;
padding: 0;
border: 0;
color: rgb(107, 116, 140);"><p>After 900f2cb6f7070 in QtBase auto dpi changed it's meaning somewhat. The comment written no longer applies and #ifdef'ing is the correct thing to get the consistent behaviour.</p>
<p>With QT_AUTO_SCREEN_SCALE_FACTOR=0 set, we no longer scale the logical DPI by the screen scale factor which is something we need to deliver high DPI correctly. <br />
i.e on a low res screen with a physical of 96, running QT_SCREEN_SCALE_FACTORS=2 should double the fonts. This patch breaks that which means we've broken the config UI.</p></div>
</blockquote>
<p>On my system, when <tt style="background: #ebebeb; font-size: 13px;">QT_AUTO_SCREEN_SCALE_FACTOR/QT_ENABLE_HIGHDPI_SCALING</tt> isn't disabled and both display scaling & font dpi scaling is enabled it results in double scaling - all qt apps are unproportionately huge which <strong>makes ui broken without this patch</strong>.</p></div></div><br /><div><strong>REPOSITORY</strong><div><div>R120 Plasma Workspace</div></div></div><br /><div><strong>REVISION DETAIL</strong><div><a href="https://phabricator.kde.org/D26185">https://phabricator.kde.org/D26185</a></div></div><br /><div><strong>To: </strong>ahartmetz, Plasma, apol, davidedmundson<br /><strong>Cc: </strong>acooligan, fvogt, asturmlechner, dfaure, davidedmundson, anthonyfieroni, plasma-devel, LeGast00n, The-Feren-OS-Dev, jraleigh, zachus, fbampaloukas, GB_2, ragreen, ZrenBot, ngraham, alexeymin, himcesjf, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart<br /></div>