<table><tr><td style="">mart added inline comments.
</td><a style="text-decoration: none; padding: 4px 8px; margin: 0 8px 8px; float: right; color: #464C5C; font-weight: bold; border-radius: 3px; background-color: #F7F7F9; background-image: linear-gradient(to bottom,#fff,#f1f0f1); display: inline-block; border: 1px solid rgba(71,87,120,.2);" href="https://phabricator.kde.org/D26525">View Revision</a></tr></table><br /><div><strong>INLINE COMMENTS</strong><div><div style="margin: 6px 0 12px 0;"><div style="border: 1px solid #C7CCD9; border-radius: 3px;"><div style="padding: 0; background: #F7F7F7; border-color: #e3e4e8; border-style: solid; border-width: 0 0 1px 0; margin: 0;"><div style="color: #74777d; background: #eff2f4; padding: 6px 8px; overflow: hidden;"><a style="float: right; text-decoration: none;" href="https://phabricator.kde.org/D26525#inline-149716">View Inline</a><span style="color: #4b4d51; font-weight: bold;">image.cpp:554</span></div>
<div style="font: 11px/15px "Menlo", "Consolas", "Monaco", monospace; white-space: pre-wrap; clear: both; padding: 4px 0; margin: 0;"><div style="padding: 0 8px; margin: 0 4px; background: rgba(151, 234, 151, .6);">        <span style="color: #aa4000">if</span> <span class="p">(</span><span class="n">wallpaperDir</span><span class="p">.</span><span class="n">mkpath</span><span class="p">(</span><span class="n">wallpaperDir</span><span class="p">.</span><span class="n">absolutePath</span><span class="p">())</span> <span style="color: #aa2211">&&</span> <span style="color: #aa2211">!</span><span class="n">url</span><span class="p">.</span><span class="n">fileName</span><span class="p">().</span><span class="n">isEmpty</span><span class="p">())</span> <span class="p">{</span>
</div><div style="padding: 0 8px; margin: 0 4px; background: rgba(151, 234, 151, .6);">            <span class="n">KIO</span><span style="color: #aa2211">::</span><span class="n">FileCopyJob</span> <span style="color: #aa2211">*</span><span class="n">job</span> <span style="color: #aa2211">=</span> <span class="n">KIO</span><span style="color: #aa2211">::</span><span class="n">file_copy</span><span class="p">(</span><span class="n">url</span><span class="p">,</span> <span class="n">QUrl</span><span style="color: #aa2211">::</span><span class="n">fromLocalFile</span><span class="p">(</span><span class="n">wallpaperPath</span><span class="p">),</span> <span style="color: #aa2211">-</span><span style="color: #601200">1</span><span class="p">,</span> <span class="n">KIO</span><span style="color: #aa2211">::</span><span class="n">HideProgressInfo</span> <span style="color: #aa2211">|</span> <span class="n">KIO</span><span style="color: #aa2211">::</span><span class="n">Overwrite</span><span class="p">);</span>
</div></div></div>
<div style="margin: 8px 0; padding: 0 12px;"><p style="padding: 0; margin: 8px;">this is for first run when ~/.local/share/wallpapers isn't there yet?</p></div></div><br /><div style="border: 1px solid #C7CCD9; border-radius: 3px;"><div style="padding: 0; background: #F7F7F7; border-color: #e3e4e8; border-style: solid; border-width: 0 0 1px 0; margin: 0;"><div style="color: #74777d; background: #eff2f4; padding: 6px 8px; overflow: hidden;"><a style="float: right; text-decoration: none;" href="https://phabricator.kde.org/D26525#inline-149717">View Inline</a><span style="color: #4b4d51; font-weight: bold;">image.cpp:555</span></div>
<div style="font: 11px/15px "Menlo", "Consolas", "Monaco", monospace; white-space: pre-wrap; clear: both; padding: 4px 0; margin: 0;"><div style="padding: 0 8px; margin: 0 4px; background: rgba(151, 234, 151, .6);">        <span style="color: #aa4000">if</span> <span class="p">(</span><span class="n">wallpaperDir</span><span class="p">.</span><span class="n">mkpath</span><span class="p">(</span><span class="n">wallpaperDir</span><span class="p">.</span><span class="n">absolutePath</span><span class="p">())</span> <span style="color: #aa2211">&&</span> <span style="color: #aa2211">!</span><span class="n">url</span><span class="p">.</span><span class="n">fileName</span><span class="p">().</span><span class="n">isEmpty</span><span class="p">())</span> <span class="p">{</span>
</div><div style="padding: 0 8px; margin: 0 4px; background: rgba(151, 234, 151, .6);">            <span class="n">KIO</span><span style="color: #aa2211">::</span><span class="n">FileCopyJob</span> <span style="color: #aa2211">*</span><span class="n">job</span> <span style="color: #aa2211">=</span> <span class="n">KIO</span><span style="color: #aa2211">::</span><span class="n">file_copy</span><span class="p">(</span><span class="n">url</span><span class="p">,</span> <span class="n">QUrl</span><span style="color: #aa2211">::</span><span class="n">fromLocalFile</span><span class="p">(</span><span class="n">wallpaperPath</span><span class="p">),</span> <span style="color: #aa2211">-</span><span style="color: #601200">1</span><span class="p">,</span> <span class="n">KIO</span><span style="color: #aa2211">::</span><span class="n">HideProgressInfo</span> <span style="color: #aa2211">|</span> <span class="n">KIO</span><span style="color: #aa2211">::</span><span class="n">Overwrite</span><span class="p">);</span>
</div><div style="padding: 0 8px; margin: 0 4px; ">
</div><div style="padding: 0 8px; margin: 0 4px; background: rgba(251, 175, 175, .7);">        <span style="color: #aa4000">if</span> <span class="p">(</span><span style="color: #aa2211">!</span><span class="n">wallpaperPath</span><span class="p">.</span><span class="n">isEmpty</span><span class="p">())</span> <span class="p">{</span>
</div><div style="padding: 0 8px; margin: 0 4px; background: rgba(251, 175, 175, .7);">            <span class="n">KIO</span><span style="color: #aa2211">::</span><span class="n">FileCopyJob</span> <span style="color: #aa2211">*</span><span class="n">job</span> <span style="color: #aa2211">=</span> <span class="n">KIO</span><span style="color: #aa2211">::</span><span class="n">file_copy</span><span class="p">(</span><span class="n">url</span><span class="p">,</span> <span class="n">QUrl</span><span class="p">(</span><span class="n">wallpaperPath</span><span class="p">),</span> <span style="color: #aa2211">-</span><span style="color: #601200">1</span><span class="p">,</span> <span class="n">KIO</span><span style="color: #aa2211">::</span><span class="n">HideProgressInfo</span><span class="p">);</span>
</div></div></div>
<div style="margin: 8px 0; padding: 0 12px;"><p style="padding: 0; margin: 8px;">I would prefer it to ask before owerwriting</p></div></div></div></div></div><br /><div><strong>REPOSITORY</strong><div><div>R120 Plasma Workspace</div></div></div><br /><div><strong>REVISION DETAIL</strong><div><a href="https://phabricator.kde.org/D26525">https://phabricator.kde.org/D26525</a></div></div><br /><div><strong>To: </strong>trmdi, Plasma<br /><strong>Cc: </strong>mart, plasma-devel, LeGast00n, The-Feren-OS-Dev, jraleigh, zachus, fbampaloukas, GB_2, ragreen, ZrenBot, ngraham, alexeymin, himcesjf, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra<br /></div>