<table><tr><td style="">tcanabrava updated this revision to Diff 73061.<br />tcanabrava added a comment.
</td><a style="text-decoration: none; padding: 4px 8px; margin: 0 8px 8px; float: right; color: #464C5C; font-weight: bold; border-radius: 3px; background-color: #F7F7F9; background-image: linear-gradient(to bottom,#fff,#f1f0f1); display: inline-block; border: 1px solid rgba(71,87,120,.2);" href="https://phabricator.kde.org/D25449">View Revision</a></tr></table><br /><div><div><ul class="remarkup-list">
<li class="remarkup-list-item">Correctly extract qml</li>
<li class="remarkup-list-item">Update documentation text</li>
<li class="remarkup-list-item">Remove deprecated calls</li>
<li class="remarkup-list-item">Correct placement of pointer and reference symbols</li>
<li class="remarkup-list-item">Rename variables on kconfigxt and use name and key</li>
<li class="remarkup-list-item">Correct constructor</li>
<li class="remarkup-list-item">Use auto</li>
<li class="remarkup-list-item">Use qAsConst</li>
<li class="remarkup-list-item">Return a map directly</li>
<li class="remarkup-list-item">Inheit from the generated settings to use usrSave</li>
</ul></div></div><br /><div><strong>REPOSITORY</strong><div><div>R119 Plasma Desktop</div></div></div><br /><div><strong>CHANGES SINCE LAST UPDATE</strong><div><a href="https://phabricator.kde.org/D25449?vs=70122&id=73061">https://phabricator.kde.org/D25449?vs=70122&id=73061</a></div></div><br /><div><strong>BRANCH</strong><div><div>arcpatch-D25449</div></div></div><br /><div><strong>REVISION DETAIL</strong><div><a href="https://phabricator.kde.org/D25449">https://phabricator.kde.org/D25449</a></div></div><br /><div><strong>AFFECTED FILES</strong><div><div>kcms/formats/CMakeLists.txt<br />
kcms/formats/Messages.sh<br />
kcms/formats/README<br />
kcms/formats/formats.desktop<br />
kcms/formats/formatsettings_impl.cpp<br />
kcms/formats/formatsettings_impl.h<br />
kcms/formats/formatssettings.kcfg<br />
kcms/formats/formatssettings.kcfgc<br />
kcms/formats/kcm.cpp<br />
kcms/formats/kcm.h<br />
kcms/formats/kcm_formats.desktop<br />
kcms/formats/kcmformats.cpp<br />
kcms/formats/kcmformats.h<br />
kcms/formats/kcmformatswidget.ui<br />
kcms/formats/localemodel.cpp<br />
kcms/formats/localemodel.h<br />
kcms/formats/package/contents/ui/main.qml<br />
kcms/formats/package/metadata.desktop</div></div></div><br /><div><strong>To: </strong>tcanabrava, ervin<br /><strong>Cc: </strong>ervin, davidedmundson, plasma-devel, LeGast00n, The-Feren-OS-Dev, jraleigh, zachus, fbampaloukas, GB_2, ragreen, ZrenBot, ngraham, alexeymin, himcesjf, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart<br /></div>