<table><tr><td style="">ngraham requested changes to this revision.<br />ngraham added a comment.<br />This revision now requires changes to proceed.
</td><a style="text-decoration: none; padding: 4px 8px; margin: 0 8px 8px; float: right; color: #464C5C; font-weight: bold; border-radius: 3px; background-color: #F7F7F9; background-image: linear-gradient(to bottom,#fff,#f1f0f1); display: inline-block; border: 1px solid rgba(71,87,120,.2);" href="https://phabricator.kde.org/D26256">View Revision</a></tr></table><br /><div><div><p>Works great. Just a few code change requests:</p></div></div><br /><div><strong>INLINE COMMENTS</strong><div><div style="margin: 6px 0 12px 0;"><div style="border: 1px solid #C7CCD9; border-radius: 3px;"><div style="padding: 0; background: #F7F7F7; border-color: #e3e4e8; border-style: solid; border-width: 0 0 1px 0; margin: 0;"><div style="color: #74777d; background: #eff2f4; padding: 6px 8px; overflow: hidden;"><a style="float: right; text-decoration: none;" href="https://phabricator.kde.org/D26256#inline-148762">View Inline</a><span style="color: #4b4d51; font-weight: bold;">main.qml:546</span></div>
<div style="font: 11px/15px "Menlo", "Consolas", "Monaco", monospace; white-space: pre-wrap; clear: both; padding: 4px 0; margin: 0;"><div style="padding: 0 8px; margin: 0 4px; background: rgba(151, 234, 151, .6);"> <span style="color: #aa4000">id: raiseMaximumVolumeCheckbox</span>
</div><div style="padding: 0 8px; margin: 0 4px; background: rgba(151, 234, 151, .6);"> <span style="color: #aa4000">spacing:</span> <span style="color: #004012">units</span><span class="p">.</span><span style="color: #004012">smallSpacing</span> <span style="color: #aa2211">*</span> <span style="color: #601200">1.5</span>
</div><div style="padding: 0 8px; margin: 0 4px; background: rgba(151, 234, 151, .6);"> <span style="color: #aa4000">Layout.leftMargin:</span> <span style="color: #004012">units</span><span class="p">.</span><span style="color: #004012">smallSpacing</span> <span style="color: #aa2211">*</span> <span style="color: #601200">0.75</span> <span style="color: #aa2211">+</span> <span style="color: #601200">4</span>
</div></div></div>
<div style="margin: 8px 0; padding: 0 12px;"><p style="padding: 0; margin: 8px;">Don't override this; if it looks bad with the default value, we should fix that in the checkbox control itself</p></div></div><br /><div style="border: 1px solid #C7CCD9; border-radius: 3px;"><div style="padding: 0; background: #F7F7F7; border-color: #e3e4e8; border-style: solid; border-width: 0 0 1px 0; margin: 0;"><div style="color: #74777d; background: #eff2f4; padding: 6px 8px; overflow: hidden;"><a style="float: right; text-decoration: none;" href="https://phabricator.kde.org/D26256#inline-148761">View Inline</a><span style="color: #4b4d51; font-weight: bold;">main.qml:547</span></div>
<div style="font: 11px/15px "Menlo", "Consolas", "Monaco", monospace; white-space: pre-wrap; clear: both; padding: 4px 0; margin: 0;"><div style="padding: 0 8px; margin: 0 4px; background: rgba(151, 234, 151, .6);"> <span style="color: #aa4000">spacing:</span> <span style="color: #004012">units</span><span class="p">.</span><span style="color: #004012">smallSpacing</span> <span style="color: #aa2211">*</span> <span style="color: #601200">1.5</span>
</div><div style="padding: 0 8px; margin: 0 4px; background: rgba(151, 234, 151, .6);"> <span style="color: #aa4000">Layout.leftMargin:</span> <span style="color: #004012">units</span><span class="p">.</span><span style="color: #004012">smallSpacing</span> <span style="color: #aa2211">*</span> <span style="color: #601200">0.75</span> <span style="color: #aa2211">+</span> <span style="color: #601200">4</span>
</div><div style="padding: 0 8px; margin: 0 4px; background: rgba(151, 234, 151, .6);"> <span style="color: #aa4000">checked:</span> <span style="color: #004012">plasmoid</span><span class="p">.</span><span style="color: #004012">configuration</span><span class="p">.</span><span style="color: #004012">raiseMaximumVolume</span>
</div></div></div>
<div style="margin: 8px 0; padding: 0 12px;"><p style="padding: 0; margin: 8px;">This could evaluate to a fractional number. You probably want <tt style="background: #ebebeb; font-size: 13px;">units.largeSpacing</tt> here (the spacing doesn't have to be <em>literally</em> identical to the mockup; it's more important to use standard spacing values)</p></div></div><br /><div style="border: 1px solid #C7CCD9; border-radius: 3px;"><div style="padding: 0; background: #F7F7F7; border-color: #e3e4e8; border-style: solid; border-width: 0 0 1px 0; margin: 0;"><div style="color: #74777d; background: #eff2f4; padding: 6px 8px; overflow: hidden;"><a style="float: right; text-decoration: none;" href="https://phabricator.kde.org/D26256#inline-148763">View Inline</a><span style="color: #4b4d51; font-weight: bold;">main.qml:549</span></div>
<div style="font: 11px/15px "Menlo", "Consolas", "Monaco", monospace; white-space: pre-wrap; clear: both; padding: 4px 0; margin: 0;"><div style="padding: 0 8px; margin: 0 4px; background: rgba(151, 234, 151, .6);"> <span style="color: #aa4000">checked:</span> <span style="color: #004012">plasmoid</span><span class="p">.</span><span style="color: #004012">configuration</span><span class="p">.</span><span style="color: #004012">raiseMaximumVolume</span>
</div><div style="padding: 0 8px; margin: 0 4px; background: rgba(151, 234, 151, .6);"> <span style="color: #aa4000">onCheckedChanged:</span> <span class="p">{</span>
</div><div style="padding: 0 8px; margin: 0 4px; background: rgba(151, 234, 151, .6);"> <span style="color: #004012">plasmoid</span><span class="p">.</span><span style="color: #004012">configuration</span><span class="p">.</span><span style="color: #004012">raiseMaximumVolume</span> <span style="color: #aa2211">=</span> <span style="color: #004012">checked</span>
</div></div></div>
<div style="margin: 8px 0; padding: 0 12px;"><p style="padding: 0; margin: 8px;">Always use <tt style="background: #ebebeb; font-size: 13px;">onToggled</tt> to handle user input, never <tt style="background: #ebebeb; font-size: 13px;">onCheckedChanged</tt></p>
<p style="padding: 0; margin: 8px;">If you're deliberately using <tt style="background: #ebebeb; font-size: 13px;">onCheckedChanged</tt> because it has the side effect of evaluating the logic in here when the applet is first loaded, then don't do that, and instead explicitly call that logic in an <tt style="background: #ebebeb; font-size: 13px;">onCompleted</tt> block</p></div></div></div></div></div><br /><div><strong>REPOSITORY</strong><div><div>R115 Plasma Audio Volume Applet</div></div></div><br /><div><strong>REVISION DETAIL</strong><div><a href="https://phabricator.kde.org/D26256">https://phabricator.kde.org/D26256</a></div></div><br /><div><strong>To: </strong>gvgeo, ngraham, VDG, Plasma, drosca<br /><strong>Cc: </strong>drosca, plasma-devel, LeGast00n, The-Feren-OS-Dev, jraleigh, zachus, fbampaloukas, GB_2, ragreen, ZrenBot, ngraham, alexeymin, himcesjf, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart<br /></div>