<table><tr><td style="">ngraham created this revision.<br />ngraham added a reviewer: Plasma.<br />Herald added a project: Plasma.<br />Herald added a subscriber: plasma-devel.<br />ngraham requested review of this revision.
</td><a style="text-decoration: none; padding: 4px 8px; margin: 0 8px 8px; float: right; color: #464C5C; font-weight: bold; border-radius: 3px; background-color: #F7F7F9; background-image: linear-gradient(to bottom,#fff,#f1f0f1); display: inline-block; border: 1px solid rgba(71,87,120,.2);" href="https://phabricator.kde.org/D26305">View Revision</a></tr></table><br /><div><strong>REVISION SUMMARY</strong><div><p>The base app was always setting Ctrl+F as a search shortcut, even when the toolbar upon<br />
which the search field lives was not visible. This caused the dreaded "ambiguous shortcut"<br />
dialog to appear. The patch fises the issue by setting the shortcut only when the toolbar<br />
contains a search field, and unsetting it when the toolbar is hidden.</p>
<p>BUG: 405030<br />
FIXED-IN: 5.18</p></div></div><br /><div><strong>TEST PLAN</strong><div><p>Hit <kbd style="display: inline-block; min-width: 1em; padding: 4px 5px 5px; font-weight: normal; font-size: 0.8rem; text-align: center; text-decoration: none; line-height: 0.6rem; border-radius: 3px; box-shadow: inset 0 -1px 0 rgba(71, 87, 120, 0.08); user-select: none; background: #f7f7f7; border: 1px solid #C7CCD9;">Ctrl</kbd><span class="kbd-join" style="padding: 0 4px; color: #92969D;">+</span><kbd style="display: inline-block; min-width: 1em; padding: 4px 5px 5px; font-weight: normal; font-size: 0.8rem; text-align: center; text-decoration: none; line-height: 0.6rem; border-radius: 3px; box-shadow: inset 0 -1px 0 rgba(71, 87, 120, 0.08); user-select: none; background: #f7f7f7; border: 1px solid #C7CCD9;">F</kbd> in both sidebar and icons view. In both cases, it focuses the search<br />
field.</p></div></div><br /><div><strong>REPOSITORY</strong><div><div>R124 System Settings</div></div></div><br /><div><strong>BRANCH</strong><div><div>fix-shortcut-conflict (branched from master)</div></div></div><br /><div><strong>REVISION DETAIL</strong><div><a href="https://phabricator.kde.org/D26305">https://phabricator.kde.org/D26305</a></div></div><br /><div><strong>AFFECTED FILES</strong><div><div>app/SettingsBase.cpp</div></div></div><br /><div><strong>To: </strong>ngraham, Plasma<br /><strong>Cc: </strong>plasma-devel, LeGast00n, The-Feren-OS-Dev, jraleigh, zachus, fbampaloukas, GB_2, ragreen, ZrenBot, ngraham, alexeymin, himcesjf, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart<br /></div>