<table><tr><td style="">ngraham accepted this revision.<br />ngraham added a comment.<br />This revision is now accepted and ready to land.
</td><a style="text-decoration: none; padding: 4px 8px; margin: 0 8px 8px; float: right; color: #464C5C; font-weight: bold; border-radius: 3px; background-color: #F7F7F9; background-image: linear-gradient(to bottom,#fff,#f1f0f1); display: inline-block; border: 1px solid rgba(71,87,120,.2);" href="https://phabricator.kde.org/D26275">View Revision</a></tr></table><br /><div><div><p>Ah my mistake. I was confused by the empty overflow issue, which your other patch fixes. I can confirm that this fixes the actual reported issue. :)</p>
<p>However... I wonder if it's also worth fixing ListSectionHeader. It is indeed designed for you to feed it items rather than building your own custom layout, as this was perceived as being more simple. However I can see how this doesn't work at all when you put an ActionToolbar in it since it winds up inside the Rowlayout. I wonder if ultimately the idea was bad and we should just require that you give it your own custom layout... or if maybe it can detect when the item you give it is or has a layout and then replace the RowLayout with it? Or maybe that's a terrible idea.</p></div></div><br /><div><strong>REPOSITORY</strong><div><div>R134 Discover Software Store</div></div></div><br /><div><strong>BRANCH</strong><div><div>sources_actiontoolbar</div></div></div><br /><div><strong>REVISION DETAIL</strong><div><a href="https://phabricator.kde.org/D26275">https://phabricator.kde.org/D26275</a></div></div><br /><div><strong>To: </strong>ahiemstra, Plasma, Discover Software Store, apol, ngraham<br /><strong>Cc: </strong>ngraham, plasma-devel, LeGast00n, The-Feren-OS-Dev, jraleigh, zachus, fbampaloukas, GB_2, ragreen, ZrenBot, alexeymin, himcesjf, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart<br /></div>